From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59C4BA04C2; Mon, 25 Nov 2019 15:02:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97DDC2952; Mon, 25 Nov 2019 15:02:15 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 34E13A3 for ; Mon, 25 Nov 2019 15:02:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 06:02:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,241,1571727600"; d="scan'208";a="206145563" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga008.fm.intel.com with ESMTP; 25 Nov 2019 06:02:11 -0800 To: Jerin Jacob , Pavan Nikhilesh Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev References: <20191123085832.1730-1-pbhagavatula@marvell.com> From: Ferruh Yigit Message-ID: Date: Mon, 25 Nov 2019 14:02:10 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/25/2019 1:00 PM, Jerin Jacob wrote: > On Sat, Nov 23, 2019 at 5:58 PM wrote: >> >> From: Pavan Nikhilesh >> >> Enable Ptype parsing by default, only disable when `rte_eth_dev_set_ptypes` >> is called with ptype_mask as 0. >> This would enable applications that are dependent on packet type parsing >> like l3fwd. This also helps to store the configuration set by 'rte_eth_dev_set_ptypes()', right? Previously it seems this was lost in next 'otx2_nix_configure()' call, not sure if it worth mentioning in commit log. >> >> Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") >> >> Signed-off-by: Pavan Nikhilesh > > Acked-by: Jerin Jacob > > Applied to dpdk-next-net-mrvl/master. Thanks > > >> --- >> drivers/net/octeontx2/otx2_ethdev.c | 4 ++++ >> drivers/net/octeontx2/otx2_ethdev.h | 1 + >> drivers/net/octeontx2/otx2_lookup.c | 7 +++++-- >> 3 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c >> index ddab3aa06..eaf7ba917 100644 >> --- a/drivers/net/octeontx2/otx2_ethdev.c >> +++ b/drivers/net/octeontx2/otx2_ethdev.c >> @@ -622,6 +622,9 @@ nix_rx_offload_flags(struct rte_eth_dev *eth_dev) >> if ((dev->rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP)) >> flags |= NIX_RX_OFFLOAD_TSTAMP_F; >> >> + if (!dev->ptype_disable) >> + flags |= NIX_RX_OFFLOAD_PTYPE_F; >> + >> return flags; >> } >> >> @@ -2168,6 +2171,7 @@ otx2_eth_dev_init(struct rte_eth_dev *eth_dev) >> >> dev->configured = 0; >> dev->drv_inited = true; >> + dev->ptype_disable = 0; >> dev->base = dev->bar2 + (RVU_BLOCK_ADDR_NIX0 << 20); >> dev->lmt_addr = dev->bar2 + (RVU_BLOCK_ADDR_LMT << 20); >> >> diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h >> index eb1626309..987e7607c 100644 >> --- a/drivers/net/octeontx2/otx2_ethdev.h >> +++ b/drivers/net/octeontx2/otx2_ethdev.h >> @@ -276,6 +276,7 @@ struct otx2_eth_dev { >> uint8_t configured_cints; >> uint8_t configured_nb_rx_qs; >> uint8_t configured_nb_tx_qs; >> + uint8_t ptype_disable; >> uint16_t nix_msixoff; >> uintptr_t base; >> uintptr_t lmt_addr; >> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c >> index 17c44e20e..bcf2ff4e8 100644 >> --- a/drivers/net/octeontx2/otx2_lookup.c >> +++ b/drivers/net/octeontx2/otx2_lookup.c >> @@ -67,10 +67,13 @@ otx2_nix_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask) >> { >> struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); >> >> - if (ptype_mask) >> + if (ptype_mask) { >> dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; >> - else >> + dev->ptype_disable = 0; >> + } else { >> dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; >> + dev->ptype_disable = 1; >> + } >> >> otx2_eth_set_rx_function(eth_dev); >> >> -- >> 2.17.1 >>