From: "Varghese, Vipin" <vipin.varghese@amd.com>
To: fengchengwen <fengchengwen@huawei.com>,
dev@dpdk.org, stable@dpdk.org, honest.jiang@foxmail.com,
gmuthukrishn@marvell.com, ferruh.yigit@amd.com
Subject: Re: [PATCH] app/dma-perf: add average latency per worker
Date: Tue, 27 Feb 2024 15:20:50 +0530 [thread overview]
Message-ID: <a6c5dae8-c26a-4b81-8901-6281ba59475b@amd.com> (raw)
In-Reply-To: <9acefd53-f617-28c1-1d6b-21b137d336eb@huawei.com>
On 2/23/2024 3:15 PM, fengchengwen wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Hi Vipin,
>
> On 2023/12/20 0:40, Vipin Varghese wrote:
>> Modify the user display data with total average latency per worker.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
>> ---
>> app/test-dma-perf/benchmark.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
>> index 9b1f58c78c..8b6886af62 100644
>> --- a/app/test-dma-perf/benchmark.c
>> +++ b/app/test-dma-perf/benchmark.c
>> @@ -470,7 +470,8 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
>> bandwidth_total += bandwidth;
>> avg_cycles_total += avg_cycles;
>> }
>> - printf("\nTotal Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n", bandwidth_total, mops_total);
>> + printf("\nAverage Cycles/op: %.2lf, Total Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n",
>> + (float) avg_cycles_total / nb_workers, bandwidth_total, mops_total);
thanks for the suggestions, please find my observations below
> Because this is total stats, suggest add Total prefix, e.g. "Total Average Cycles/op"
I did not follow this, so please let me try to explain my understanding.
For `n` operation we count the average cycles, then
we add the cycles to form `total average cycles`; this is then divide by
`n` operations. Making this per operation what is the
average cycles taken for the round trip time. Hence `Total Average
Cyeles/op` does not sound right, but `Average Cycles / op` does.
> I think print format keep one-digit precision is enough. Also please modify CSV_TOTAL_LINE_FMT
> make sure the csv also have same precision of Cycles/op.
We have checked the CSV formatting a find
1. the precision for average cycle/op is 2 digits precision.
2. already the CVS format has average cycles/op integrated.
Hence no change is required.
>
> Thanks
>
>> snprintf(output_str[MAX_WORKER_NB], MAX_OUTPUT_STR_LEN, CSV_TOTAL_LINE_FMT,
>> cfg->scenario_id, nr_buf, memory * nb_workers,
>> avg_cycles_total / nb_workers, bandwidth_total, mops_total);
>>
next prev parent reply other threads:[~2024-02-27 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 16:40 Vipin Varghese
2024-02-23 9:45 ` fengchengwen
2024-02-27 9:50 ` Varghese, Vipin [this message]
2024-02-27 13:09 ` fengchengwen
2024-02-28 3:06 ` Varghese, Vipin
2024-02-28 3:05 ` Varghese, Vipin
2024-03-06 15:06 ` [PATCH v2] " Vipin Varghese
2024-03-08 1:15 ` fengchengwen
2024-03-08 2:39 ` Varghese, Vipin
2024-03-08 19:06 ` [PATCH v3] " Vipin Varghese
2024-03-12 1:53 ` fengchengwen
2024-03-18 2:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6c5dae8-c26a-4b81-8901-6281ba59475b@amd.com \
--to=vipin.varghese@amd.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gmuthukrishn@marvell.com \
--cc=honest.jiang@foxmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).