From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B21A4A0563; Wed, 15 Apr 2020 10:08:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E4381D44E; Wed, 15 Apr 2020 10:08:12 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9C1A91D166 for ; Wed, 15 Apr 2020 10:08:10 +0200 (CEST) IronPort-SDR: YQv7CgamREkCaTe15DJRJ7nDOTUs9mYTiHTDFwVEE8S8Xo1rtCNOutlHVPzIRdus1SNWxxD/HF RRenKCRSgYkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 01:08:09 -0700 IronPort-SDR: Qjxc10AH0T5u54d9L37vdWt3JszsizfBady2qdAa6SmWJdu+jdTuaRdx+ACAx+IFoTPJHR/bSz yCTyWQKu/RZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="427354730" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.150]) ([10.67.68.150]) by orsmga005.jf.intel.com with ESMTP; 15 Apr 2020 01:08:07 -0700 To: Ori Kam , "bernard.iremonger@intel.com" , "xiaolong.ye@intel.com" , "qi.z.zhang@intel.com" Cc: "dev@dpdk.org" , "jingjing.wu@intel.com" , "yahui.cao@intel.com" , "simei.su@intel.com" References: <20200318170401.7938-5-jia.guo@intel.com> <20200414174225.64120-1-jia.guo@intel.com> <20200414174225.64120-4-jia.guo@intel.com> From: Jeff Guo Message-ID: Date: Wed, 15 Apr 2020 16:08:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, Ori On 4/14/2020 5:48 PM, Ori Kam wrote: > Hi Jeff, > PSB, > > Thanks, > Ori > >> -----Original Message----- >> From: Jeff Guo >> Sent: Tuesday, April 14, 2020 8:42 PM >> To: Ori Kam ; bernard.iremonger@intel.com; >> xiaolong.ye@intel.com; qi.z.zhang@intel.com >> Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com; >> simei.su@intel.com; jia.guo@intel.com >> Subject: [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands >> >> Add some new types, such as eth-src-only/eth-dst-only/svlan/cvlan/ >> l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used >> to configure these rss input set by cmdline. >> >> Signed-off-by: Jeff Guo >> --- >> v4->v3: >> no change >> --- >> app/test-pmd/cmdline.c | 24 ++++++++++++++++++++++-- >> app/test-pmd/config.c | 8 ++++++++ >> 2 files changed, 30 insertions(+), 2 deletions(-) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 863b567c1..df7309f61 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -2299,6 +2299,22 @@ cmd_config_rss_parsed(void *parsed_result, >> rss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY; >> else if (!strcmp(res->value, "l4-dst-only")) >> rss_conf.rss_hf = ETH_RSS_L4_DST_ONLY; >> + else if (!strcmp(res->value, "eth-src-only")) >> + rss_conf.rss_hf = ETH_RSS_ETH_SRC_ONLY; >> + else if (!strcmp(res->value, "eth-dst-only")) >> + rss_conf.rss_hf = ETH_RSS_ETH_DST_ONLY; >> + else if (!strcmp(res->value, "s-vlan")) >> + rss_conf.rss_hf = ETH_RSS_S_VLAN; >> + else if (!strcmp(res->value, "c-vlan")) >> + rss_conf.rss_hf = ETH_RSS_C_VLAN; >> + else if (!strcmp(res->value, "l2tpv3")) >> + rss_conf.rss_hf = ETH_RSS_L2TPV3; >> + else if (!strcmp(res->value, "esp")) >> + rss_conf.rss_hf = ETH_RSS_ESP; >> + else if (!strcmp(res->value, "ah")) >> + rss_conf.rss_hf = ETH_RSS_AH; >> + else if (!strcmp(res->value, "pfcp")) >> + rss_conf.rss_hf = ETH_RSS_PFCP; > > In patch ethdev: add new RSS offload types, you added a define for ETH_RSS_ETH > I don't see any usage for this enum in the code. > Should it be added? Or removed from the first patch? It should be added and please expect it in v5. >> else if (!strcmp(res->value, "none")) >> rss_conf.rss_hf = 0; >> else if (!strcmp(res->value, "default")) >> @@ -2467,7 +2483,9 @@ cmdline_parse_token_string_t >> cmd_config_rss_hash_key_rss_type = >> "ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6- >> udp#" >> "ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#" >> "ipv6-tcp-ex#ipv6-udp-ex#" >> - "l3-src-only#l3-dst-only#l4-src-only#l4-dst- >> only"); >> + "l3-src-only#l3-dst-only#l4-src-only#l4-dst- >> only#" >> + "eth-src-only#eth-dst-only#s-vlan#c-vlan#" >> + "l2tpv3#esp#ah#pfcp"); >> cmdline_parse_token_string_t cmd_config_rss_hash_key_value = >> TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, >> NULL); >> >> @@ -2478,7 +2496,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = { >> "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" >> "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" >> "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" >> - "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only " >> + "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" >> + "eth-src-only|eth-dst-only|s-vlan|c-vlan|" >> + "l2tpv3|esp|ah|pfcp " >> "", >> .tokens = { >> (void *)&cmd_config_rss_hash_key_port, >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 71aeb5413..47256292b 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -79,6 +79,10 @@ const struct rss_type_info rss_type_table[] = { >> ETH_RSS_UDP | ETH_RSS_SCTP | >> ETH_RSS_L2_PAYLOAD }, >> { "none", 0 }, >> + { "eth-src-only", ETH_RSS_ETH_SRC_ONLY }, >> + { "eth-dst-only", ETH_RSS_ETH_DST_ONLY }, >> + { "s-vlan", ETH_RSS_S_VLAN }, >> + { "c-vlan", ETH_RSS_C_VLAN }, >> { "ipv4", ETH_RSS_IPV4 }, >> { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, >> { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, >> @@ -108,6 +112,10 @@ const struct rss_type_info rss_type_table[] = { >> { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, >> { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, >> { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, >> + { "l2tpv3", ETH_RSS_L2TPV3 }, >> + { "esp", ETH_RSS_ESP }, >> + { "ah", ETH_RSS_AH }, >> + { "pfcp", ETH_RSS_PFCP }, >> { NULL, 0 }, >> }; >> >> -- >> 2.20.1