From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B370A0524; Tue, 20 Apr 2021 03:00:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 221E841448; Tue, 20 Apr 2021 03:00:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C385F40685; Tue, 20 Apr 2021 03:00:44 +0200 (CEST) IronPort-SDR: E8dbM/zgDbym5ATX+LI0uZMIj0PJ0w0Jcu2u8KHfitDW9bI1R/GuQPYiP4honcY6uzlJp9jO9B W4Z7NnAs3MIw== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="182916065" X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="182916065" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 18:00:39 -0700 IronPort-SDR: 04wloT1YyEgcTCdCjtO9S6rBDdrWs7OXFJMCG55UayA+zsyiMiIGNTsV2/uqk4Jz67t4Kv5YvB 4XV6wS1oD8MA== X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="452327446" Received: from agrady-mobl.ger.corp.intel.com (HELO [10.213.224.96]) ([10.213.224.96]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 18:00:38 -0700 To: "Zhang, Tianfei" , "Zhang, Qi Z" , "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" Cc: "stable@dpdk.org" References: <20210408085151.54996-1-wei.huang@intel.com> <20210408085151.54996-2-wei.huang@intel.com> <4e1e3b11cfb24c87b3eac9e023a3090d@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 20 Apr 2021 02:00:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/20/2021 1:13 AM, Zhang, Tianfei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: 2021年4月20日 6:36 >> To: Zhang, Qi Z ; Huang, Wei ; >> dev@dpdk.org; Xu, Rosen >> Cc: stable@dpdk.org; Zhang, Tianfei >> Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning >> >> On 4/19/2021 9:12 AM, Zhang, Qi Z wrote: >>> >>> >>>> -----Original Message----- >>>> From: Huang, Wei >>>> Sent: Thursday, April 8, 2021 4:52 PM >>>> To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z >>>> >>>> Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, >>>> Ferruh ; Huang, Wei >>>> Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning >>>> >>>> In max10_staging_area_init(), variable "size" from fdt_get_reg() may >>>> be invalid, it should be checked before assigning to member variable >> "staging_area_size" >>>> of structure "intel_max10_device". >>>> >>>> Coverity issue: 367480, 367482 >>>> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device >>>> driver") >>>> >>>> Signed-off-by: Wei Huang >>>> --- >>> >>> Applied to dpdk-next-net-intel. >>> >> >> This patch is missing the maintainer ack. >> >> Rosen, Tianfei, can you please review the patch? > > It looks good for me. > > Acked-by: Tianfei zhang > Thanks, added in next-net.