From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31BF6A0C4D; Wed, 13 Oct 2021 10:58:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E2BB41168; Wed, 13 Oct 2021 10:58:28 +0200 (CEST) Received: from mail-108-mta47.mxroute.com (mail-108-mta47.mxroute.com [136.175.108.47]) by mails.dpdk.org (Postfix) with ESMTP id 04B9641167 for ; Wed, 13 Oct 2021 10:58:26 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta47.mxroute.com (ZoneMTA) with ESMTPSA id 17c78dfc81f0000b55.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 13 Oct 2021 08:58:24 +0000 X-Zone-Loop: 1ee810f4abc06f825760f3f85b3cae8d1ae9eac76f62 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IxOeUUkCW6GV2uk/wUPAoz1Fd3Kd1zCtv0i+Tv8vX0w=; b=NtJH6R8W66q/wy1BLwPxXA10zv kfOYTCKI8OURBjjfuj0M6fK8WVMrD9iui0Awx8s5x1vTUwRRmmpNeLKYzZoXVMTfRhxJgdKuYMTJ1 P71we2kJzr6+tnmiM9NlbNXb63QFP7pJit74j54FK94wWDTplZN67m8fweuH/5+DJnNh55M6+kxmY 5Kg2tKOGqKYNQVkZMAMW1u0xL2hjcJ/XrrXfRXgpfZl3GWtz9o/If/lrBsBxD8Vdcu5JCiHxXceTh ncdmZ/8Jvq6DWx6SGNQRgHSCaagX9+FuA+aRvtHyaNaMypiAD0Wi00yZa7XoOTDpNK1+TkbyXb/Qy V1hffYXQ==; To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, olivier.matz@6wind.com, thomas@monjalon.net, Bernard Iremonger References: <20210527152858.13312-1-getelson@nvidia.com> <20211012122934.23659-1-getelson@nvidia.com> From: "Kinsella, Ray" Message-ID: Date: Wed, 13 Oct 2021 09:58:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211012122934.23659-1-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, RCPT_COUNT_SEVEN=0, FROM_HAS_DN=0, TO_DN_SOME=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, NEURAL_SPAM=0, MID_RHS_MATCH_FROM=0] Subject: Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/10/2021 13:29, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > create simplified code to match on the IHL value in a flow rule. > The original `version_ihl' structure member is kept for backward > compatibility. > The patch implements one of 2 announced changes to the > IPv4 header. > IPv4 header encodes fragment information into 16 bits field. > 3 bits hold flags and remaining 13 bits are for fragment offset. > 13 bits bit-field cannot be defined both for big and little endian > systems. > > Signed-off-by: Gregory Etelson > > Acked-by: Olivier Matz > Acked-by: Ray Kinsella