From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] i40e Rx descriptor loads ordering
Date: Fri, 24 Sep 2021 11:08:57 +0000 [thread overview]
Message-ID: <a7049c6c293b4997ac3e2c02cb54d5eb@intel.com> (raw)
In-Reply-To: <20210915083339.2424369-1-ruifeng.wang@arm.com>
> -----Original Message-----
> From: Ruifeng Wang <ruifeng.wang@arm.com>
> Sent: Wednesday, September 15, 2021 4:34 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; jerinj@marvell.com;
> hemant.agrawal@nxp.com; drc@linux.vnet.ibm.com;
> honnappa.nagarahalli@arm.com; stable@dpdk.org; nd@arm.com; Ruifeng
> Wang <ruifeng.wang@arm.com>
> Subject: [PATCH v2 0/2] i40e Rx descriptor loads ordering
>
> On Rx path, NIC fills Rx descriptor with data pertains to received packet.
>
> A single descriptor consists of multiple words. Word1 has the bit that indicates
> readiness of descriptor for software to use. So word1 should be loaded before
> other words.
>
> On architectures with weaker memory ordering, barrier is needed to ensure
> the ordering of loads.
>
> This patch set fixed the risk on both scalar path and aarch64 vector path.
>
> v2:
> Updated commit message. Performance impact added. (Honnappa)
>
> Ruifeng Wang (2):
> net/i40e: fix risk in Rx descriptor read in NEON vector path
> net/i40e: fix risk in Rx descriptor read in scalar path
>
> drivers/net/i40e/i40e_rxtx.c | 12 ++++++++++++
> drivers/net/i40e/i40e_rxtx_vec_neon.c | 8 ++++++++
> 2 files changed, 20 insertions(+)
>
> --
> 2.25.1
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-09-24 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 3:31 [dpdk-dev] [PATCH " Ruifeng Wang
2021-09-06 3:32 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path Ruifeng Wang
2021-09-14 18:33 ` Honnappa Nagarahalli
2021-09-15 8:42 ` Ruifeng Wang
2021-09-06 3:32 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix risk in Rx descriptor read in scalar path Ruifeng Wang
2021-09-14 18:06 ` Honnappa Nagarahalli
2021-09-15 8:33 ` [dpdk-dev] [PATCH v2 0/2] i40e Rx descriptor loads ordering Ruifeng Wang
2021-09-15 8:33 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path Ruifeng Wang
2021-09-15 8:33 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path Ruifeng Wang
2021-09-29 15:05 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-09-29 15:29 ` Honnappa Nagarahalli
2021-10-11 16:26 ` Ferruh Yigit
2021-10-19 11:14 ` Zhang, Qi Z
2021-11-05 6:57 ` Ruifeng Wang
2021-11-11 10:27 ` Ruifeng Wang
2021-11-11 12:27 ` Zhang, Qi Z
2021-09-24 11:08 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7049c6c293b4997ac3e2c02cb54d5eb@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).