DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yu, Jin" <jin.yu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Tiwei Bie <tiwei.bie@intel.com>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor vhost-blk example
Date: Thu, 30 Apr 2020 01:42:57 +0000	[thread overview]
Message-ID: <a71e44bb199a4032ba5f1bed2a009536@intel.com> (raw)
In-Reply-To: <7bb6947e-29ef-cb29-020a-3d7ad0a28bf2@intel.com>

Got it. I will check and fix it. 

Thanks.

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Thursday, April 30, 2020 1:54 AM
> To: Yu, Jin <jin.yu@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Tiwei Bie <tiwei.bie@intel.com>; Wang,
> Zhihong <zhihong.wang@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor vhost-blk
> example
> 
> On 2/28/2020 3:32 PM, Jin Yu wrote:
> > Decrease the code and make it easier to read. It's useful for
> > understanding the inflight APIs and how packed ring works. Update the
> > RST because the packed ring patch has been merged to QEMU master and
> > ring_packed parameter changes to packed.
> >
> > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage
> > sample")
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> >  doc/guides/sample_app_ug/vhost_blk.rst |    8 +-
> >  examples/vhost_blk/blk.c               |   13 +-
> >  examples/vhost_blk/vhost_blk.c         | 1139 ++++++++++--------------
> >  examples/vhost_blk/vhost_blk.h         |   39 +-
> >  4 files changed, 494 insertions(+), 705 deletions(-)
> 
> Getting following build error with 32-bit build, can you please check it:
> 
> .../examples/vhost_blk/vhost_blk.c: In function ‘desc_payload_to_iovs’:
> .../examples/vhost_blk/vhost_blk.c:157:9: error: cast to pointer from integer of
> different size [-Werror=int-to-pointer-cast]
>   157 |   vva = (void *)gpa_to_vva(ctrlr,
>       |         ^
> 


  reply	other threads:[~2020-04-30  1:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 15:32 Jin Yu
2020-04-27  8:01 ` Maxime Coquelin
2020-04-28 16:05 ` Maxime Coquelin
2020-04-29 17:53 ` Ferruh Yigit
2020-04-30  1:42   ` Yu, Jin [this message]
2020-04-30  9:08     ` Maxime Coquelin
2020-04-30  9:42       ` Yu, Jin
2020-04-30 17:20 ` [dpdk-dev] [PATCH v2] " Jin Yu
2020-04-30 20:41   ` Maxime Coquelin
2020-04-30 20:53   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a71e44bb199a4032ba5f1bed2a009536@intel.com \
    --to=jin.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).