From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D304A0547; Tue, 15 Nov 2022 12:00:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AC1540DFD; Tue, 15 Nov 2022 12:00:53 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id DBDA340150 for ; Tue, 15 Nov 2022 12:00:51 +0100 (CET) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NBNRD509xzqSMj; Tue, 15 Nov 2022 18:56:56 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 15 Nov 2022 19:00:43 +0800 Subject: Re: [PATCH v10 0/8] app/procinfo: add some extended features To: David Marchand , References: <20220722091236.15469-1-liudongdong3@huawei.com> <20221011111843.3311-1-liudongdong3@huawei.com> CC: , , , From: Dongdong Liu Message-ID: Date: Tue, 15 Nov 2022 19:00:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022/11/15 17:52, David Marchand wrote: > On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu wrote: >> >> This patchset is to add some extended features for dpdk-proc-info. >> >> Thanks to Reshma and Stephen help to review the patchset. >> >> v9->v10: >> - Fix some comments for Rx/Tx descriptor dump. >> >> v8->v9: >> - Fixed some checkpatch warnings. >> >> v7(v4)->v8: >> - Add Acked-by: Reshma Pattan for PATCH 4,6. >> - Add Rx/Tx descriptor dump. >> - Adjust procinfo doc guide. >> >> v3->v4: >> - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7. >> - Rename show-module-info to show-module-eeprom to make more clear. >> >> v2->v3: Fix some comments from Stephen. >> - Use --version option for DPDK version. >> - Add --firmware-version option to show firmware. >> - Use errors on stderr, not stdout. >> - Delete some unnecessary code. >> >> v1->v2: Fix some comments from Reshma. >> >> Dongdong Liu (4): >> app/procinfo: add firmware version dump >> app/procinfo: fix some wrong doxygen syntax >> app/procinfo: support descriptor dump >> doc: add some extended features in procinfo guide >> >> Jie Hai (1): >> app/procinfo: add dump of Rx/Tx burst mode >> >> Min Hu (Connor) (3): >> app/procinfo: add dpdk version dump >> app/procinfo: add RSS RETA dump >> app/procinfo: add module eeprom info dump >> >> app/proc-info/main.c | 324 ++++++++++++++++++++++++++++++--- >> doc/guides/tools/proc_info.rst | 36 +++- >> 2 files changed, 336 insertions(+), 24 deletions(-) > > The last patch was a mix of various changes in the documentation. > Please make sure to update the documentation as part of the code > changes, in the future. > And separate fixes with proper Fixes: tag from other changes. Thanks for pointing this and helping to fix. > > Series applied, thanks. Many thanks for the work. Thanks, Dongdong. >