From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3D1785323 for ; Fri, 14 Sep 2018 13:37:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2018 04:37:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,373,1531810800"; d="scan'208";a="70822229" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.151]) ([10.252.18.151]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2018 04:37:28 -0700 To: Shahaf Shuler , Thomas Monjalon , Andrew Rybchenko Cc: "dev@dpdk.org" References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 14 Sep 2018 12:37:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 11:37:31 -0000 On 9/4/2018 11:02 AM, Shahaf Shuler wrote: > Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: >> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >> >> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >> Without any specific Rx offload flag, default behavior by PMDs is to >> strip CRC. >> >> PMDs that support keeping CRC should advertise >> DEV_RX_OFFLOAD_KEEP_CRC >> Rx offload capability. >> >> Applications that require keeping CRC should check PMD capability first >> and if it is supported can enable this feature by setting >> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() >> >> Signed-off-by: Ferruh Yigit >> Acked-by: Tomasz Duszynski >> --- >> v2: >> * fix flag check >> * add KEEP_CRC flag into "show port cap #" >> >> Note "show port cap #" and >> "show port # [r/t]x_offload capabilities/configuration" >> does same thing, in long term I suggest removing "show port cap" one > > > Acked-by: Shahaf Shuler > Applied to dpdk-next-net/master, thanks.