From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7F42E1B854 for ; Mon, 9 Apr 2018 17:49:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 08:49:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,427,1517904000"; d="scan'208";a="215199733" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.17.130]) ([10.252.17.130]) by orsmga005.jf.intel.com with ESMTP; 09 Apr 2018 08:49:57 -0700 To: Shreyansh Jain Cc: dev@dpdk.org References: <20180405141414.11146-1-shreyansh.jain@nxp.com> <1040d76d-a000-93ed-1cae-34f76007d97f@intel.com> <8660ae8a-61bb-56c4-fd6f-9a70d9b41d3c@nxp.com> From: "Burakov, Anatoly" Message-ID: Date: Mon, 9 Apr 2018 16:49:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <8660ae8a-61bb-56c4-fd6f-9a70d9b41d3c@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: support for hotplugging of memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 15:49:59 -0000 On 09-Apr-18 8:49 AM, Shreyansh Jain wrote: > Hello Anatoly, > > On Sunday 08 April 2018 10:44 PM, Burakov, Anatoly wrote: >> On 05-Apr-18 3:14 PM, Shreyansh Jain wrote: >>> Restructure VFIO DMA code for handling hotplug memory events >>> (callbacks) and --legacy case. >>> >>> Signed-off-by: Shreyansh Jain >>> --- >>> >>> ### >>> This is based on the 16fbfef04a3 github repository. This is assuming >>> that changes already exists as done in patch 26/68. >>> Though, this can be a standalone, replacing 26/88. Though, the Makefile >>> changes don't exist in this. >>> Also, this just a first draft. I will push any review changes after this >>> incrementally over v4. >>> ### >> >> Hi Shreyansh, >> >> I think we can keep the 26/68 as it still works within the context of >> the patchset. I would like to add these changes closer to the end, >> where we enable support for callbacks in VFIO (this could/should come >> as the next patch). > > But then it would also mean that dpaa2 would be broken within the memory > hotplug patches? > I think it would be broken once the memseg ceases to be continuous > physical sets. > Hi Shreyansh, Why would it be broken? Even when memseg change comes into effect, legacy mem is not enabled until much later in the patchset, when all of the callback/multiprocess business is in place. For all intents and purposes, this stays valid for legacy mode, hence not broken. We later enable callbacks etc. on VFIO, but technically they still aren't enabled until 65 (67 in v4), when it becomes possible to actually run DPDK in non-legacy mode. So, for the duration of this patchset, dpaa2 is not broken, as far as i can tell. Keeping in mind that only legacy mode will be available until patch 65/67, what exactly is being broken here? -- Thanks, Anatoly