From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46]) by dpdk.org (Postfix) with ESMTP id 27E2D37B1 for ; Mon, 19 Sep 2016 14:33:16 +0200 (CEST) Received: from BY2PR03CA043.namprd03.prod.outlook.com (10.141.249.16) by DM5PR03MB2443.namprd03.prod.outlook.com (10.168.233.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Mon, 19 Sep 2016 12:33:14 +0000 Received: from BL2FFO11FD010.protection.gbl (2a01:111:f400:7c09::111) by BY2PR03CA043.outlook.office365.com (2a01:111:e400:2c5d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8 via Frontend Transport; Mon, 19 Sep 2016 12:33:14 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD010.mail.protection.outlook.com (10.173.161.16) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Mon, 19 Sep 2016 12:33:13 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8JCX7pE027569; Mon, 19 Sep 2016 05:33:11 -0700 To: Jan Viktorin References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <1473410639-10367-1-git-send-email-shreyansh.jain@nxp.com> <20160918092220.062b95bf@jvn> <20160918111730.1cc74b74@jvn> <20160918120452.29216084@jvn> CC: Jianbo Liu , Shreyansh Jain , "dev@dpdk.org" , David Marchand From: Hemant Agrawal Message-ID: Date: Mon, 19 Sep 2016 18:03:07 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160918120452.29216084@jvn> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131187619939077241; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(377454003)(13464003)(24454002)(86362001)(189998001)(97736004)(8676002)(4001350100001)(31696002)(81156014)(54356999)(19580405001)(11100500001)(8666005)(305945005)(81166006)(76176999)(23746002)(50986999)(36756003)(356003)(19580395003)(77096005)(50466002)(110136003)(15975445007)(31686004)(8936002)(2906002)(47776003)(7126002)(7246003)(93886004)(65806001)(120886001)(230700001)(92566002)(65956001)(64126003)(586003)(7846002)(68736007)(106466001)(4326007)(85426001)(104016004)(65826007)(626004)(561944003)(33646002)(83506001)(87936001)(105606002)(5660300001)(2950100001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2443; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD010; 1:j3qfMqGWFfeKagrt8OsuAgiXoqXHsD8F24h4X5wwBwfvw/hWrSIIaI6t65PIEdOaftyQAYPqrdRlWc3eQ839LzyNKdI6pSGmgikw8ZNwPtmY9cvMnKv2F+2a2mqcjgazvies00EDMcRedJ6ej2BL+N9cNzmQZBFx4mDVmWccHCmnJp6JPgjdtEoIaqk/F53uZQuNJJMlXWP2ogboXg6jmINBNlGIUWwS/GBfuBhRnDF3heSkM6ztyGsFZfjj/7Mm7ne8m1xFdzwIdfADg5aeKac1FypcZbWEjBgG+Ilyg8m+Uwxse2GcWGmE46x1UEyu1AHgGW6tR/8hE/zRv+QxrIBOK+l4BTQ92WeBYPCwC9qR9rPmvfOqYtv2eV99FO/JSPypkmE2BaKvdmzsZ2Qe+epDRRY1QYSGx83pzLN8nJmSpRYztMtDtn9NjpFMejOLVXdF8L+JZDyNEbGsLxbL6AhlXmF4Is5In2zXH3l6oN8MYJYdxh53A5DVUF6QaUDLZz0eVbI1icrTu0X57RnJi4iP5TT6xgETHXndovVJYLiyAxyJMzNwjIzEDxmyPOaHLpdaJLum964XAaeM+bZPuQ== X-MS-Office365-Filtering-Correlation-Id: bea36713-0fd7-45ee-cc79-08d3e0891fdc X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 2:P/N0JVq2scOpAXN2aqzXy9ZwzXhWpTvpzc68594HOihkpKJUCeblHlNsRCpd1mnbIlsj2k6XHWE1YqhpURkhCvXpcvPUG6J0mZv80IfdqbDakijSpP/qtj8csA6ZNyVHdEFLQh2cgZWRbktxSFeuYVWWRXZuYPCB6OwpuZE8d+u7LYDHZVovIAqssgUxpqvZ; 3:D2WtUbVpA8lpl+vOBDEqhvxjB90rq4u4Q9lhV1b+TuAxKNIHhwe+JOh1lCUwynU/oApo7uWPwKsiQ9/5chC0pjIJ+4PSz9AajW1112MUiQ7SLm37O3tAAeUHkrL/6aO923ZfJBWCjuNqtPA9iFlNRQFY7vKhJS/5gdQFK72gmUGx9YMgg2HzsVISasMxkRihaIHclqkh4jP+u1Osc0nKTJpb5oAAlMDdwchrizDOfFs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR03MB2443; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 25:x1JrMUb1YA/B8AtfSuXvgWbREn43hw+5xF//KliHSaVzkwOaGaxZ/SRO7qf71d4FAUruxYioS8lD7JcfLK47DeJ0PYj8vE5YE0DiMDkFwKU5wb40fKaCpOKWEyFB7cQb7UZAduNdpHiUQkFWoZFluIo3pbhFCiTtOgzXqV8U50muUcqiY/d1kGR0TGLJa8nZHcjAHcbC0vN9svPqMDiQkVhglSUQFWAXOAkSEwbuR1VHXo5Ohzd7qj1gmxMZwVOlanGT9hi5BIymDe04JyhQrGxLWos/47ZWBnZcYubpeHfGiu3U+lg6Qh4OrrsbonYXFKoj38hv/Jv77wACIpZSJHn1SbklxMUQDpxqkcQMjSlZxY3PP1RCWKHOWCd3UG3WotsVHrNEaf8UCyPWSvIM2B5r+7Gf3ErNmyQmmQgqMnxXYA+5NumkS8ZrxnBMkYG98BUGrf23hn/5apZ/NR9WTNGBuGLdJbdYLnaSGGGcdjJHdfbTE5AiN/Z04MQNPx/Bvut3lYJy3yEdNH/1qVZBCY2CcLv81s4DLvqyqQXg1MVwhBLzC+YR3GELM7tFHEn2n2J+waLv23IwbF2z1henORSley9tcTyvqbVk2Ne416nBdi8Zbxv0qxAvda/JEtES6n9s6fFuhXKyfKNJIuuM8Lf5AGR1j6Zj6uvKlaMH/aSrD4k186d850T7Ebkh3zNdmPtr3/zl1MadMOF/FtOZ+jGF5EgyWmDRMFjJ9ryzgDWgjKd7+RCZNcO2SKlapBk/SgJA2IFb/DCxhDHCH8azCLnJD6GDesF8oNbklDMJxsoeoCNgwc39rBd4JfzQj7xUO52z9bW4t4T4Lmv3j3CeqAkF6RbWXzlW00xcx8raCQNnfioKJHgt/tL5biEsKYMO X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 31:xQnXduQnnjvzXx1fEeHWFj9Yn0MPjdNPkbZyl96uEJt1VQCrIEGHYmGeqFMiBf+oeogF4GQ5DPFNUgWyC6CTcAR1RvPOKkKf116tmgu2fxOPKDkMHXRMo9MM3XpLOLlm0AB1w26zibOcGW6TBIvFfwEixyQ6n75EYMjNa0iolT57MKZG0wpb2bEAbcTRaX6B1uF6EwqoK6SSs5N8n0Y5xF8pcLfiqqjNCKvFlnM+R9U=; 4:bExW+sfmLLGM2sQQdzyFb2nkFZn54YL6OzbvlXZIytkomn7+cHS+W7UxHWkOEk8VswJA+HMDClyCtFUlWwzmIyhUe0XX8Xj7B7OmvyITS43HONY9e3VyouIiqjMECs8qQ+Ji2gzmxPrCLaTFVcrmhz4tcYCNMaOAllUTL9gaI3TWRCsvGpT06ZCIYL1CSEXcGkrdor8NuTZHbesUUs2uQY+06/ffJcQW9PzIJorD+wC7sx39T6svL+PYcvdeHyt29l0wpZfL/iVuKGuDBm0Pv3wV24TD1oIUWJLkCdZKGeY2GhhJOGHalFTMjlmREMRPdr8e3skpAIjqnbiBrbcPv2P5YXPt1TMLronE/k1SQ93H40gON1GWGV0xuDr5Ybtc4vwhFQSWTPEJo4334RJNHrtYgehc1GBYlbEdI6xTlWVULglr7nUIYAZMaWjpWRtWU0JduJpj5+/VAF+glzbPZvi+fEFtxAkcadF3uuKbjH79zYTs3WS3rMfqWIyTQaW1nVRXQZBfNCyK6y9YQko0sIAMOEe8f+ux4fce+l4t84k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13018025)(13017025)(13015025)(13023025)(13024025)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:DM5PR03MB2443; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2443; X-Forefront-PRVS: 0070A8666B X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2443; 23:5MMxm0U2e41pY54rVx+Qqn0ZgKKYtjJzDYSfR?= =?Windows-1252?Q?Yy4QgpeRFbDeDtu4xcZ3BkWLjFl1mozDEgyczUh3l8x7tjS/Vb8tj3L3?= =?Windows-1252?Q?9HdyGTRYfnq19PsECkuavkwWCosB3es1AZNQ5db3q9arTP/XrDFGOC/X?= =?Windows-1252?Q?dPgFoKFDoRx3hykbYsL2SRqyoBHrVfkpGv6UfUWOfhc9VCoj7ZWcYh6m?= =?Windows-1252?Q?rvt47SQb7PyHY15HRInaEd+EDSrPDnzpmR7n/OuFqrLcM4f1Mh/bl1pW?= =?Windows-1252?Q?UknxTpg7ICvZXjzna86RCEb4wce2WhI1+F+nzI7dwDItlYNMTy5MYwY7?= =?Windows-1252?Q?ABm6ArZQMH8XvnInYN0AWPOav80WeBuyRMgsP2Cgi9ehUYVuOU2G0RwC?= =?Windows-1252?Q?iE6/efbT2pV0glGr8BwLTV+GekV7GGiQRZAXiNO1moi0774OD2IlEiwj?= =?Windows-1252?Q?LCi1zMoCRihQF1bpXgOlnwiaZ+4EoiuHUSAhaWQSuiafNO2LQbhx8oNx?= =?Windows-1252?Q?lunTM5M6EWEVKx+l+2uUbjex3r1cZv6BCKce/3s2iU4VQvF3zbFtIvf5?= =?Windows-1252?Q?tYWUca8OA+9MzJBGr3neG8sBtmBL/t7+fNEQu0PuMGadTAY0QcADGlPE?= =?Windows-1252?Q?3PKwTH4yI9MwFoM9sC6SCbH6AFDbJHvH3TdHK3s3BvUBlZkVPfccLfB2?= =?Windows-1252?Q?Cwca12GXO95UCwWcSN6W3D4BLJJlZzmNS5FWSmHhsnLCzYTDOc2cJvNB?= =?Windows-1252?Q?NvDr4CENjyqmlrZMqUmZDLzArOwysboaRFtTDaEWbW5OAxG3fr6zhFgU?= =?Windows-1252?Q?+sDyV8wAcVqqQKj4UdPi672SngeVHXQEFfnVn7dmDtti+Mt70e8Nw+me?= =?Windows-1252?Q?wQcFmKnykPgECQjnB5eVtpTU6yALZVgu2KVUd/2Q25AoqtxRF8pkuIV5?= =?Windows-1252?Q?aIxGTAZuyUQguTdghvteULe/Sidgy+peH7R2Mlk3gZtLa7X+Ad0viqZ2?= =?Windows-1252?Q?Fmd4iIHRNGYBpT1gT3jgCf+FD7Cf5LZCTGfrG0ewcc1ixlsk+9v537+D?= =?Windows-1252?Q?1bfq+hPzHGbL0Z4AV2ttTdU9BKKh2gJISCfE5p8SH1aN7RXLUzLupZ8A?= =?Windows-1252?Q?SUSVKtblB6XwsmgxARHSqHk3p6K3bSMQhpJI3DZCKOvh/axMQqpT1xQ9?= =?Windows-1252?Q?fDk7LpyXOshysiXLSQLIrfx+3ucpY8od5k+WrCBeTSyvaBN2ZmJzERlg?= =?Windows-1252?Q?A3Ul7kuI45s1VFYZ+31rbtyu/XWp2rsZncKoUNkF7eJFqujQw3c56apv?= =?Windows-1252?Q?fjsURLWZxuyTrMQVvf+Brh6GsVPfgJ3zP2mHnXbjrZBMoTMIMoCEEIDx?= =?Windows-1252?Q?ZYpOelMgYVpp90siwNoUDA75Q8Y26UnVoIv6uk4qVJV03w8dtIWdTSGs?= =?Windows-1252?Q?kK/oJ4Zr0pBu8iNZQ3xlCT5Wx+5FjqyyFiV+oNRi5i/drCo50uMKKcNS?= =?Windows-1252?Q?iKT8f/9xhgcnR/uwXyuBP6bDdIgBXufANTgj2rTEiWLnHX9x3kYw0HQt?= =?Windows-1252?Q?emzTF8IPuQlyZA0wA2Q2JacbiJoNGJLZ677f3KD7GA3d4gBt/NuVMyjF?= =?Windows-1252?Q?DuGX9ta8HvQ4/jwXLZIiUM=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 6:XTf/8PVcm5GetBBj9xRtJBQnr9+cVJzM7zGG64KqBJuu4eQUgat1J6X1TpQMVycVNn0hHIYGo4LXakbp6/DWtDhhkbaAL7W7AcjcZrH2wwRQ2VVMwFJBpcRNcBhQROBMx1gaJ92J+v3m5CK7h4tZsVstLhSS2UHACQ0w9FBAitjv1lBDAgp+cga8iTkPnkVgYVvqxCNSNPn/JLM4ehIaTWcbMJ+4k5C86kIbjQgA9JPVzpoqXnhCSjZ5kiqezKhyECqjRlpk5FjQfn5Od0iLl/tQp4Sw7YbogiouQPL/3V0=; 5:XSuoxhIxrn89YR2lPP6V0WkZdHMcG+yiv/R/RwzcZnbSQDJxWWCW84Bur7IGfFwyh9Db9hxBfsWhtSgcSbKO63XGrcUmJY3S97p3CprHrwXveo9w82SBSh6qqJ15SJEa19+WaHEmPisDEG7RgKjddalKewT25AoWvZtv1vIUcRc=; 24:LCE8Hoc8x2KvEi+ywAJ0xhH2Qyl1pbihNsvDFBYW5kdiXeVKipKuK72vM8yBUaQYrhqd+KoxyAWN9HrPr4dfKE6B+1VXYbSBYgtILWQs71U=; 7:QggzXt0uP6eCBDCRpBb7eP9yjGVOPSi4KyUEtgiIMMIlnJTa+0HGuLBGoS99eT9VQ9M+xnUaR9HjZDGB4U7dtJM1+myEkpoMtVmPhJ6+ugJiiisWshTIaFfC2GM9EHS7K0svh4H0DEIHz9vAU2rlT3lgZTw4r2pOvmGUpDEf18CD+Qz1qyjyM3QryNQPeMZGF05MWtxTHRxWQYdAab1tATDcIG8kQrLk2za2r9RZpKFmL6hEZUP3Bi41rWfL9tjcGIxVPmyPu69Xx8yeGWG2CQQzCwQNPgFvzM9Voj+QOmD4e1hEiOjS2wIWi0GxVTpa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 12:33:13.7361 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2443 Subject: Re: [dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 12:33:16 -0000 On 9/18/2016 3:34 PM, Jan Viktorin wrote: > On Sun, 18 Sep 2016 09:41:55 +0000 > Hemant Agrawal wrote: > >>> -----Original Message----- >>> From: Jan Viktorin [mailto:viktorin@rehivetech.com] >> > > [...] > >>>> And for each platform/product.... >>>> >>>>> I agree, that this can sometimes lead to code duplication. Moreover, >>>>> it opens door for a very non-standard, unsecure and wrong-by-design >>>>> approaches. I'd like more to provide one or more scan >>>>> implementations in EAL and do not put this responsibility on PMDs. >> > > Hi Hemant. > >> [Hemant] A common/default scan function can be added, provided at least one or more PMD driver support it. >> w.r.t Jan's original scan function, it was not suitable for any of the NXP SoC's whether ARM or PowerPC. >> >> Unable to validate the Jan's scan function on a real platform, we have skipped it for next phase. >> Addition of a default scan function can only be done in next phase, when we find a suitable SoC PMD driver supporting it. > > Quite frankly, the situation is same for me. I still have no clue about > your approach which seems to be pretty non-standard. I have no way how > to test it. > Yes! Our first sample to test the above proposal is with a specific bus; NXP's new generation Layerscape devices use fsl-mc bus. https://www.kernel.org/doc/readme/drivers-staging-fsl-mc-README.txt This is neither a platform bus nor a PCI bus. It does not fit the default implementation for platform bus. Our objective is to make the first design of SoC patchset very simple and extendable for future. This will improve, when we have more SoC vendor participation and sharing their requirements. Also, we definitely have a plan to provide default implementation for buses which are generic or have more than one PMD implementation depending on them e.g. use your Platform Bus scan function > My approach can be tested on any Linux machine with platform devices > and device-tree enabled. You would see that I detect those devices (I > don't mean any certain network device, I mean all platform devices) and > if you provide a driver with a proper compatible string it will be set > for you. > > I presume that I don't have any upstreamable PMD for this at the moment. > > From the very generic scan approach, I cannot see, what kernel > infrastructure are you going to use. We should support at least the > VFIO-platform which is standard and with IOMMU, it is considered secure. > Any other approach would require an out-of-tree kernel driver or some > non-secure access to devices. I don't say it is very wrong, but we > should be careful about this. > I agree with your description and approach when the devices are on platform-bus. We plan to address it in next phase. We have identified another NXP device, which uses platform-bus for device detection. We will use that for our testing. >>>>> >>>>>> >>>>>>> detect the devices. This is because SoC may require specific or >>>>>>> additional info for device detection. Further, SoC may have >>>>>>> embedded >>>>> >>>>> Can you provide an example for "additional info for device detection"? > > Can you? > e.g. our fsl-mc bus is more close to PCI bus, where we get object identifiers instead of compatible string. > Regards > Jan > > [...] >