From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5CD542A99; Mon, 8 May 2023 19:47:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A183410ED; Mon, 8 May 2023 19:47:26 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2066.outbound.protection.outlook.com [40.107.237.66]) by mails.dpdk.org (Postfix) with ESMTP id 7BD8940685 for ; Mon, 8 May 2023 19:47:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OEr4NkCmrHfyL8pD2lWzZab+ZH/pPx0vT48/98s603jg5gOROz1E1GhoPfuL2DwwNdR0gK5cmEDwZj+iSmySaViZfb/PNy0wd11TiXSrj8fVgtlaAXcjJ/le9OMLXTgfIk6TX3+FM31ui/ZsL2xfOdTx7bDpp2bP7029Vw2RNoLBqf/2Uhy8QZXBrdOjdRUwcw4XhpaoFGvkdv3YtDH6MA0X4ydLlSEzW8pEo7J7Su4fzPqPdrA4M3+pFOvyu2PLqkb27km96DFtwvulr0FdsLJgqqAxKcbAMnYisP9NGE1slnkgc/Vpkpb4KnEQlg9iL+cWv9w9EBHG8gveRiKoZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NIRB3GEsJnaHFmWXL2MD9+zUK8adUEIabAz+nOv+dwM=; b=VW9xVjyoaztJhpBc9Wv+EmHccvyxmwTO8jwQrqGeSrq1X6mjlG9ZJh1lt0qzpgvuyaB+8IxbFXz3sQqoEnNFKka8ZvY/XA3t0/XSGU/nB7qkWJsq2d43GfT5qOyFB4gPFY2r23UheZ3Q/FXh9TRJF/t6fhE38WI11m8FlfAdz85yLScabHMR2tnSOPCG0GlEROelspAOIvBoIOjUWckdpqJ8A2S8+DGf9xDYbcz62hKs0HHttI2YSKSXxnUZ47rnNqj5OxbNnev6W7Aa0GOvjWdopcdSuC7Y2TO/zWjLHFCXr9lvJq3f6jeE66Dw7smVCkzpjlD9me1iQmlhh5i7Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIRB3GEsJnaHFmWXL2MD9+zUK8adUEIabAz+nOv+dwM=; b=KkP3ERyJ8YzX7S/2Zuwdf4ZvWI1Z2FTfHZPT9KLm1XkRCTWnSW58TK5jmdj5zHDRIeo2fZ03gZFgu0Xq+vq96J901py/cIlXMTIp+ncfnvXBkEFugnX37T/5x9CdN+OmlKCt88B/3QkYVWrIJ2iw+wpehg5xCtsjBke/HFQsR8k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB8532.namprd12.prod.outlook.com (2603:10b6:610:191::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 17:47:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6363.032; Mon, 8 May 2023 17:47:23 +0000 Message-ID: Date: Mon, 8 May 2023 18:47:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX Content-Language: en-US To: Honnappa Nagarahalli , "Gupta, Nipun" , "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" , Ruifeng Wang Cc: "Anand, Harpreet" , "Agarwal, Nikhil" , nd References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230421145406.12831-1-nipun.gupta@amd.com> <20230421145406.12831-6-nipun.gupta@amd.com> <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> <8d729d5d-2de4-fc73-3ad6-d045079274e9@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0274.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB8532:EE_ X-MS-Office365-Filtering-Correlation-Id: 925f6336-a57b-4287-dcca-08db4fec477d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9vcPh+cyLHRngULw1OyNJGrDuh5DCeWvu++JelAh+v3jJxZA/Vs4V0sxF7lhicbkQD7f5TBnChD5qiVmnMd/uRLpAn5BXu6HP2JSceiaTueMotj141GKK2lljxJweoGfyF8UNws1tdMUK/UyyUX4fpwDdp7vCyFnOmFGZ20KVGTOHBcVwQcqCHWnToQf4aLH2lfAKykWyvArqIUDCFl2q6UdqEImfbpQHA3/TE6Nwudcqs/N/TwZnX0n3HNZpYDfTuiO12GRvJBOM8htHxXuktxWT7YVNjaQqxZN73Xo4kURlkAsiwNq8OdH3oScNk9KJfjJK4gTw9gOi31ILM8tIL6mz8ukQw3XKNy18af1HvQ6uGrl1PdmLAJLyU1fg9s+4QNRhJtQ0TouhnjdW4sxQSoP+yYKdKDETcNVtOAsy0kbTKvw7IT4x2bUH9uLqyh1bi3MYkRn7bYCviPOridHZgXaDJ2VeX1GWadrv1lEeu6Xjo7F88galt/TIKUhxEljL4geDEjCgH/gbHRI90WjR4M51oDpJyqpLNUKkr3hi8VTr0EjkY+ld/RG7+Ua58lmZf0p8AfF+JmqWzdIb8LwrabOUNxQ5uyYFkSKI+okATpPEaOwXK8k4DlrXGlq9ZAe3pAMDHEs+UkE0nRdMLuiVA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199021)(2906002)(54906003)(478600001)(316002)(41300700001)(8936002)(8676002)(110136005)(44832011)(6666004)(66476007)(4326008)(66556008)(5660300002)(66946007)(31686004)(6486002)(53546011)(6512007)(6506007)(26005)(186003)(2616005)(36756003)(38100700002)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjEvVVdXMno3YmlWTzJ2d1lYU1NHR3R3RWF4VEMwNEZGZzBlNFBrK01EYXVt?= =?utf-8?B?NVA0Tnk5VVRmekFvYUlsalpiV2plOEpkSmtkb2xvR3FJWVVRWVJ6aHMzTjZ4?= =?utf-8?B?bWdvSU9LdmlFYlNTNGE0SXpKUjRxMXlod2Erd2F3dG93ZXkyck5yWEcyM0c5?= =?utf-8?B?Z3dxRUNEbURUWTc0R3BoUCtzRXUxTVdkT3owRjdtQXk0djBkUnFyNzVSandX?= =?utf-8?B?WU9oa1V6V0VZTlFEcmNpVzlTem5jOThXN3pXS2d6RHhnZXFWc2FFNlEyMVBF?= =?utf-8?B?SEgwUU9RVzl6cDIxV1czdkxyeUhjWG9RYUV3dEZkSlZKK2VoSk85bmFwSXcw?= =?utf-8?B?aENUaDlzUFpHQ2YwTERJTHhaRHpBQmRCQTJVMElqUFpENlZpdm5RTGk1ZUxs?= =?utf-8?B?VnpjRmtnc3V0NjhCblRmdnJycTJtN3NwcE5FY0thY2ZnV0NtZXVBN1VwdUhw?= =?utf-8?B?ajNJUXVQcUNXbTcwQmRVa3N3MGZVTnZ6MXMyY1JiVVU5aklvdU0weGF0R3Bw?= =?utf-8?B?OExCbDJMVHovdnppVS93UllCSUpWUzJKd1BRRnRlbjRCby82ZU4zc1ZySFpi?= =?utf-8?B?NmEzWDBqVDMreGZhL0g4U1FCczQyaDFuUDduaWY1Mmk3Y3lNaVpKR09hVUlY?= =?utf-8?B?YWl5SmhUSVlXUDExc0ZPMWhsZGFxbVllY1puRUVoNFVxOTJFdk56MlA2OExY?= =?utf-8?B?YlZmUW44QjhQenBseHFNd3JVS0c5WGxIZm5aVzR3cWV3WDh6bkhhOE0wQmFD?= =?utf-8?B?NEI5bWNCYXVIbE5YSklGZlVQUFY2b0dNeDcwd3ViRHYxMmRiVURPbEFxWXM1?= =?utf-8?B?Znp0OUdwS2Ftb1NuaHNMekVOMWEzSUVsMnNSTW5ZdzBWc2pyY2lLSjIrcC8r?= =?utf-8?B?b0duK1o0SkhrN29HemR5STZIRE9wMGFjSjAwOFZsaEtlMlhGcXlXUDAxdUhW?= =?utf-8?B?THlEVUJ5N3VOZWpsOVRDRG80UWxRQnF6WGZ3L25nMEJvSTczL1VZcWR3akIx?= =?utf-8?B?dXk3R1BPUndjUnhmdm53RmdRdWRPTEIwUEcrZFRGWmNyWlBMNDdMNG5NT1Zj?= =?utf-8?B?V2x0NWxzUmVYSnU1MmhhdHBFWTRmcGlOWWsyVS9BSndMei8ySGIzWmtpalJn?= =?utf-8?B?d2pibFZ1QW11K2NkaDFiaUFPY0ZPRnhjc0lxdDQ0R3JDWHBsQU05YS9TUngy?= =?utf-8?B?dUV4K1pPc2Y4T1RLWTFaV3NVMnRVUVV1ZitydThKRERMdlIyYS9Mc3ptTmlL?= =?utf-8?B?VEI0dnJZN01kZE1rUytLL2xXQ3VQeDNqWVNGM0o1RHQ4OXRtcFpoKzl5TzZh?= =?utf-8?B?MW0wR3Jtb2pMTjR5czJDM3IwaHlsV3k4dWZoTGpETXZWUklnUHFudnUyQUIv?= =?utf-8?B?T3BpT2lLTFBySTBaWitjVkZWNkczdDN6S1gzOHZ6YWtsQnBtR3RsTlRGRUF5?= =?utf-8?B?ak8vSEtjcG5HNUlNd2FRSVRBV1lRcjRVRGp5WDJvNVo4RksxUVM2TTNhK3Jo?= =?utf-8?B?bC93ZTVYYjFoSlNwZFRITzh2WFVFampRVTh2TXg3TFRyUWlBUGRhKzRWT2lx?= =?utf-8?B?VkxhNis0UWo4a3dxdFBtQWV6VUNRZ0swelJ1TEhrOENjT2ZQczZ4a2dpaFdv?= =?utf-8?B?Z1VvWUJ1VkdWRmdJUjFqVVFyM1MxRWFHdzU3RjdpUjgrSzlxa0FmM0VibHY5?= =?utf-8?B?VW1WdjNIY3VEMjNtVGdoeXdiWWV1WDZDTGtDVFhCR2p6amlJeGFUQ0NmNFM4?= =?utf-8?B?Szh6NytSQ2kyMmlGNGZMUW9BK1E4Z3RtSDNKbHBBSHRJK1ExTjRVa2tzYjhZ?= =?utf-8?B?MWcrOGpqc2ttY3pyN1YrRDljYVpSczZVTEg3NkhpTGRmeHFFeFp1RHYxVExj?= =?utf-8?B?dkx5WUNjNStlZE00UVNHc203Y2x3c0FOT2YxOURzUGdGZVk5N2NjN2hiNHo4?= =?utf-8?B?N0dSZUlPcS91MHVXVTVIYXE4M3Q5WkswZjEzbjloZ09mcnV0UEhmblVIK1Ax?= =?utf-8?B?R0FibFNUeW4yK0ZTYkpkK3BMWmtuK2QwRytwUDJuaVpKNWhoY1MyZzZhMlNS?= =?utf-8?B?M2xkNjNFdFJBSTRldEMzb1cweGRoTy92TU9CamZZazNMV1Jkdks0NldWTjVS?= =?utf-8?Q?WCkZO2zEcxuoRxHO8RMfo+kw8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 925f6336-a57b-4287-dcca-08db4fec477d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 17:47:23.5132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vdiY2tNhpQ1OmNH6PowrlhREpQZKNoSxHfh5p1TuB8zlW8prYnP++P9Wmbxr9/6M X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8532 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 6:16 PM, Honnappa Nagarahalli wrote: > > >>>> >>>> On 4/21/2023 3:54 PM, Nipun Gupta wrote: >>>>> Adding support for AMD CDX devices >>>>> >>>>> Signed-off-by: Nipun Gupta >>>>> --- >>>>> config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ >>>>> config/arm/meson.build | 14 ++++++++++++++ >>>>> 2 files changed, 31 insertions(+) >>>>> create mode 100644 config/arm/arm64_cdx_linux_gcc >>>>> >>>>> diff --git a/config/arm/arm64_cdx_linux_gcc >>>> b/config/arm/arm64_cdx_linux_gcc >>>>> new file mode 100644 >>>>> index 0000000000..8e6d619dae >>>>> --- /dev/null >>>>> +++ b/config/arm/arm64_cdx_linux_gcc >>>>> @@ -0,0 +1,17 @@ >>>>> +[binaries] >>>>> +c = ['ccache', 'aarch64-linux-gnu-gcc'] cpp = ['ccache', >>>>> +'aarch64-linux-gnu-g++'] ar = 'aarch64-linux-gnu-ar' >>>>> +as = 'aarch64-linux-gnu-as' >>>>> +strip = 'aarch64-linux-gnu-strip' >>>>> +pkgconfig = 'aarch64-linux-gnu-pkg-config' >>>>> +pcap-config = '' >>>>> + >>>>> +[host_machine] >>>>> +system = 'linux' >>>>> +cpu_family = 'aarch64' >>>>> +cpu = 'armv8-a' >>>>> +endian = 'little' >>>>> + >>>>> +[properties] >>>>> +platform = 'cdx' >>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index >>>>> 5213434ca4..39b8929534 100644 >>>>> --- a/config/arm/meson.build >>>>> +++ b/config/arm/meson.build >>>>> @@ -305,6 +305,18 @@ soc_bluefield = { >>>>> 'numa': false >>>>> } >>>>> >>>>> +soc_cdx = { >>>>> + 'description': 'AMD CDX', >>>>> + 'implementer': '0x41', >>>>> + 'part_number': '0xd42', >>>>> + 'flags': [ >>>>> + ['RTE_MACHINE', '"cdx"'], >>>>> + ['RTE_MAX_LCORE', 16], >>>>> + ['RTE_MAX_NUMA_NODES', 1] >>>>> + ], >>>>> + 'numa': false >>>>> +} >>>> >>>> Hi Nipun, >>>> >>>> Why we need a new arm platform/config? Is it because of above flags? >>>> If it can work with default values, I think we can drop this patch. >>> >>> Hi Ferruh, >>> >>> CDX driver works with generic ARM compilation too >> (arm64_armv8_linux_gcc). >>> >>> The versal platforms supporting CDX have A78 cores, and adding this >>> cdx config Helps to provide gcc option "march= armv8.4-a" which is for >>> implementer "0xd42" (ARM cortex A78 cores)., whereas for generic ARM >>> compilation "march= armv8-a". >>> >>> Maybe ARM guys can provide more information regarding if there is any >>> impact on using generic architecture flag (i.e. march= armv8a) on A78 cores. >>> >> >> Hi Honnappa, Ruifeng, >> >> Can you please support on this question, what is the difference of 'march= >> armv8-a' flag (comparing march= armv8a)? > I am assuming you meant, 'march=armv8.4-a' vs 'march=armv8-a'. > Yes > 'march=armv8-a' will compile for the ARM V8.0-a ISA which is the base V8-a version of the ISA. This compilation ensures that the binaries can run on any ARM V8-a platforms. > 'march=armv8.4-a' will compile the binary for ARM V8.4 ISA. The binary will use additional (possibly instructions that improve performance) instructions which are not supported in ARM V8.0-a. This binary can run only on machines that support V8.4-a and higher. But, it will provide optimized binary for the target platform. > >> Should we consider adding an arm config file to support this flag? > We support the optimized binary through the config files. We should keep these config changes. > Got it, thanks for the guidance.