From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5D1E02BE5 for ; Thu, 8 Nov 2018 11:27:37 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181108102736euoutp019caa3f1d65c64ecc7db6d809608de6de~lH0uTvvTx2777527775euoutp01y for ; Thu, 8 Nov 2018 10:27:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181108102736euoutp019caa3f1d65c64ecc7db6d809608de6de~lH0uTvvTx2777527775euoutp01y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1541672856; bh=zCIs+jFCMtEsJJi0uUg+m2k3sbboMqdf8jhFXVsYAf4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=FdcBnirnZIsLWdEmiyQIjj1vTsmldgfjsPG/rD3q9G93AWtNs3jBdEh5PMY5Gc8B8 JxgHLV8rHl8/N23bePr78a0h0yE+GASPcQvvjU7xOJwi4t7zSrWuyHwIhLWE0U17Xj X494e8aThRBWp7X/mRZ39Ew53VNr+lFot8yV5dJo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181108102736eucas1p1e90f1ec5f4a3f41744977128b06cbc94~lH0t9G6Sl3200632006eucas1p1u; Thu, 8 Nov 2018 10:27:36 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 69.BC.04806.89F04EB5; Thu, 8 Nov 2018 10:27:36 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181108102735eucas1p223edd13d6c07002706528a4798db9ff4~lH0tC2WuS1754117541eucas1p2g; Thu, 8 Nov 2018 10:27:35 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181108102735eusmtrp27d2e46206ea0434e1c2cc58968295806~lH0s3A4L50769607696eusmtrp2D; Thu, 8 Nov 2018 10:27:35 +0000 (GMT) X-AuditID: cbfec7f5-79db79c0000012c6-0b-5be40f98c5ec Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8F.47.04128.79F04EB5; Thu, 8 Nov 2018 10:27:35 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181108102734eusmtip241cbda5bd8b285d298a4063152c4f39e~lH0sTdUBY0666306663eusmtip2k; Thu, 8 Nov 2018 10:27:34 +0000 (GMT) To: "Burakov, Anatoly" , dev@dpdk.org, Qi Zhang Cc: Wenzhuo Lu , Konstantin Ananyev , Laurent Hardy , Ferruh Yigit , stable@dpdk.org From: Ilya Maximets Message-ID: Date: Thu, 8 Nov 2018 13:27:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHfXbvtqs1vU7L4wqs4ZestKgPF/KtSNqHiAiKyGKteXGSTtuc aQlJmm/4kllcHZrmMJ1WDl8z0tGaDlMWsgKDlWIWzdBKHWTabNtV8tvvnPN//uf84SEwoYEr IlKUmbRKKUsV8/zw3uFl6/6agJnEAz8n+NT0Jx1GzS/0cSj7wCifele0zKd+rDbhlG2MwSnG UMmjXMWrfKpn7C+K95WMV9qR5E9jM1eie+ngSCq629Bp/IJfdBKdmpJFq6JiL/sp7qysYBlm QfbacAHKQx1bSpEvAeRh6LGNcDwsJFsRVLVSpcjPzUsIVmz1XLZYRODqcvI3XtQ5azB20ILg yetmxBa/EDSMGHGPKog8Dw9na70cTMpBN6XjeEQYOeD2fcp4rXjkPnjTbkYeFpCxYOtv5HoY J8Ph7YNpzMPb3EbFk+08VhMII7UzXlNfMgYcffnewzEyBG4v6bksh0HfXJ33PCAH+bC03OVe RriL42C2xrERgmDW0r0eZyes9TdwWL4FkwUOxL4tRsCYXOuDOOj+bvX6YOQe6HgRxbaPgrWk nsfa+8PEXCB7gj/c62Uwti2A4kIhqw6HlVctGMsi+DC/yL+LxNpNwbSbwmg3hdH+39uI8DYU QmvUacm0+pCSvh6plqWpNcrkSHl6Widy/6NRl8X5HA2uXjEhkkDirQLY/TlRyJVlqXPSTAgI TBwssLvcLUGSLOcGrUqXqjSptNqEdhC4OERw02cqUUgmyzLpqzSdQas2phzCV5SHzkjOZigS Lr7/Um20DzgeWXQ+J4+0xH/T3O80CIdP5eqYGNoa+dtUx5SHTjzW50jj24xNRbvKFlLlz/JF hnEOVV4mVVwLjRjTl6THZVwyx2dnWUQBJ2zOhCGVXllo1nJToGKvUegijn3MrfoqlQfsOgfV Yc1DTHTV9kKjVIyrFbKDEZhKLfsHAJM9M0MDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsVy+t/xe7rT+Z9EG/y+IGTx6N5iZot3n7Yz WdzZe5rd4kr7T3aL938WsVhcPjOdxWL6hn42i38df9gttp75y+jA6XGx/w6jx68FS1k9Fu95 yeTRt2UVYwBLlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllq kb5dgl5G6+/fzAVHeCv+H2thbGBcz93FyMkhIWAiMefrDGYQW0hgKaPE1J2ZEHEpiR+/LrBC 2MISf651sXUxcgHVvGeU+LKzAaxBWCBCYt6rmSxdjBwcIgLJEquW6IPUMAvsZ5R4u+gyVMN6 Jom7156ygTSwCehInFp9hBHE5hWwk7i8cwHYBhYBFYnzUx+BDRUFGnr25TqoGkGJkzOfsIDY nAK2Ei+3NzOB2MwC6hJ/5l1ihrDFJZq+rGSFsOUltr+dwzyBUWgWkvZZSFpmIWmZhaRlASPL KkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMAI3Hbs55YdjF3vgg8xCnAwKvHwHpB7HC3EmlhW XJl7iFGCg1lJhPfOP6AQb0piZVVqUX58UWlOavEhRlOg5yYyS4km5wOTQ15JvKGpobmFpaG5 sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQimD4mDk6pBkbV7P7Fv6/6pKU9/X149aTUGg+1gCd/ y0Wez/k4/1zq+a+5dw0MjKqnO2aHu6V/WR78cOd3s6DI9KK5jfZcSUtWZk9bVr5s5fuOriZL 5Twemd3lWzYXP4jLrld8m8lUtnvj5MxHWvZbKrVdeM7F5L/ct1e18PyBwuyNaj0bzf4tdjB4 qrjavFuJpTgj0VCLuag4EQD9yeol1gIAAA== X-CMS-MailID: 20181108102735eucas1p223edd13d6c07002706528a4798db9ff4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181101160505eucas1p1fcf268f3febaa80dcbb3e573b2fc2c68 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181101160505eucas1p1fcf268f3febaa80dcbb3e573b2fc2c68 References: <20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7~P_GOOSRuf0867908679eucas1p1K@eucas1p1.samsung.com> <20181101160459.23586-1-i.maximets@samsung.com> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix busy polling while fiber link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 10:27:37 -0000 On 07.11.2018 18:52, Burakov, Anatoly wrote: > On 01-Nov-18 4:04 PM, Ilya Maximets wrote: >> If the multispeed fiber link is in DOWN state, ixgbe_setup_link >> could take around a second of busy polling. This is highly >> inconvenient for the case where single thread periodically >> checks the link statuses. For example, OVS main thread >> periodically updates the link statuses and hangs for a really >> long time busy waiting on ixgbe_setup_link() for a DOWN fiber >> ports. For case with 3 down ports it hangs for a 3 seconds and >> unable to do anything including packet processing. >> Fix that by shifting that workaround to a separate thread by >> alarm handler that will try to set up link if it is DOWN. >> >> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >> CC: stable@dpdk.org >> >> Signed-off-by: Ilya Maximets >> --- > > On my setup, this commit breaks ixgbe init in pktgen 3.5.7: > > ixgbe_dev_start(): failure in ixgbe_dev_start(): -15 > !PANIC!: rte_eth_dev_start: port=0, Input/output error > PANIC in pktgen_config_ports(): > rte_eth_dev_start: port=0, Input/output error6: [build/DPDK/pktgen(_start+0x2a) [0x560880ec838a]] > 5: [/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fabc654cb97]] > 4: [build/DPDK/pktgen(main+0xe77) [0x560880ec0357]] > 3: [build/DPDK/pktgen(pktgen_config_ports+0x1cf0) [0x560880ef53e0]] > 2: [build/DPDK/pktgen(__rte_panic+0xc5) [0x560880eb11b4]] > 1: [build/DPDK/pktgen(rte_dump_stack+0x2e) [0x560880fde69e]] > Aborted > Hi Anatoly, Thanks for the report. Could you, please, try the following patch I prepared: http://patches.dpdk.org/patch/47939/ ? Best regards, Ilya Maximets.