From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <gakhil@marvell.com>
Cc: <dev@dpdk.org>, <ndabilpuram@marvell.com>
Subject: Re: [PATCH] examples/ipsec-secgw: fix Tx checksum offload flag
Date: Tue, 18 Oct 2022 16:39:26 +0100 [thread overview]
Message-ID: <a7694c88-73e5-d363-29fe-4292446f2455@intel.com> (raw)
In-Reply-To: <20220930124055.2682935-1-radu.nicolau@intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 30/09/2022 13:40, Radu Nicolau wrote:
> Fix a typo in computing port mask for Tx checksum offload capability.
>
> Fixes: 4edcee19fc20 ("examples/ipsec-secgw: use Tx checksum offload conditionally")
> Cc: ndabilpuram@marvell.com
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
> index 8a25b83535..75ba359e69 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -3042,7 +3042,7 @@ main(int32_t argc, char **argv)
> port_init(portid, req_rx_offloads[portid],
> req_tx_offloads[portid]);
> if ((req_tx_offloads[portid] & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM))
> - ipv4_cksum_port_mask = 1U << portid;
> + ipv4_cksum_port_mask |= 1U << portid;
> }
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
--
Regards,
Vladimir
next prev parent reply other threads:[~2022-10-18 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 12:40 Radu Nicolau
2022-10-18 15:39 ` Medvedkin, Vladimir [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-22 9:28 Radu Nicolau
2022-06-22 9:46 ` Zhang, Roy Fan
2022-06-28 8:36 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7694c88-73e5-d363-29fe-4292446f2455@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).