From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0989BA0560; Tue, 18 Oct 2022 17:39:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E749140395; Tue, 18 Oct 2022 17:39:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D86824021D for ; Tue, 18 Oct 2022 17:39:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666107589; x=1697643589; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7f6DenygQCVmhBf7nNYWLzaL4W5gjI+xsVYyj2KNnhE=; b=WF4/fuR1N8T1G87/nZlgxF0UYutxZGmC4ED91YQgyQHFTWgA37Phha+A Fmf/UAbFrKGkvYJccW0TGzNKITw/O4Blke273jYoA1cblgDEHSuUstnW1 2kiJVOiJ8ojs49vjnEdQcsXB5FvMVcBT6EW6K56qK5A4WabfxR/mV6dNo 97O0PEmSQ+VzbAwHYpyeZu7NkBHkFzx5eyfW2Q5RVnMfrMLNZULApgNWQ l+hJCmEpXN4Ui48WOjXAv+QQPXylPSLKNiWWmHVRp2sMpJ37lLveo558R qfcpbjDY67LeDWVYPDDoUjAcK4zF07uBgTcSRLIBeSBpomjOZuh31hz5H w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="286535907" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="286535907" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 08:39:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="754105367" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="754105367" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 18 Oct 2022 08:39:34 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 08:39:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 08:39:34 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 08:39:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j5tgwzpbfZCKhIhmAXqfmrfEV+CROhTq9Ke0jm3Ac8YOLxJC4hCLrJTz1hzY7fMS9bA9Mj+bjDjXTJB+O4ItcaS9GvPBsTc9d9mDFs5d+/VgfmTqLAV9DlaxkixrWmgIqlAkECDrOj76rUZt1+EvmMA/cIwlvXhBhZIsboNeNiC2Ilidcm3wNDeb3N9QOdLjP9fpwAh9ltImevxTydluQr1aHbkDZ96bt686l9XN334MJW/4fdIJ40upb3g9p7H7WVcrNwJWXPELqn+/2WF+K0L2Q7k8x8dqdQAAAY0cxSF86wc1b4AcRooY8ArIXfNxCjM+dKl85sKVVjPWpB1sig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CflqoY0bpGcBHv/EiAOQj8y8UAx2XEeobIz+S2xkHlA=; b=Qu9z5CKIuLq5KbZnMinSt46I7bHOA3fSMapEsVn6/Dba9j0r+7sIN54OhFN19lAXJJxI71cpYhAbmKbZO2P47fkC1RIRqBJQVSK2+AiCgvVAwDPSTnZ3hCGGSycU9ELbO4tapK31LqOr6pA0XDwYNkpyqGNl5d+btZtc+/5l2wdefB/OGRPdlObB5CHdsOKZT3CbvX9r1SyVnEFx89Mh4PfFtL1gmZ/6zHR+hTVFhb8q00nD2x9B3w634a+zyy+VRq4QFco9e7hE1W1tyDRXtSNRk+dh9mSeGkrUOCijAOMy6uvPgYb2iiAYgCjexmZzosvwCMWkiyuBDuAAlxEq+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by DS0PR11MB6421.namprd11.prod.outlook.com (2603:10b6:8:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Tue, 18 Oct 2022 15:39:32 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::eaaf:f212:7fd3:84c2]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::eaaf:f212:7fd3:84c2%9]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 15:39:31 +0000 Message-ID: Date: Tue, 18 Oct 2022 16:39:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] examples/ipsec-secgw: fix Tx checksum offload flag Content-Language: en-US To: Radu Nicolau , Akhil Goyal CC: , References: <20220930124055.2682935-1-radu.nicolau@intel.com> From: "Medvedkin, Vladimir" In-Reply-To: <20220930124055.2682935-1-radu.nicolau@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::23) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|DS0PR11MB6421:EE_ X-MS-Office365-Filtering-Correlation-Id: 05082192-9f20-47e7-8893-08dab11ef362 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1KIWlUESO0YPu5QEL+UqaARX8NZP/YlwTkoUzWcfsmPa6VIDmDp7sA0qJd/RZqtfM8gH4vWXtVFcX8TWFxXNO8sfPKh9epgDFkSReLivvgqKxTGkE/p1h7KKFgGw4MKBL+xZ8kgPwpj6e8b0y98uHXAUdvKJYkQPYAUuxmFMmZll9S+KEKJzksaUXuKommegJho/eQ6VcL3BMIZXuxm3EruOZch4LbJTORORyCP5DH37ea6MfQKfZKN20mlserifM8wM2DNtgLiIsfXn65Pf0A6SMfLS/3SphHO4R+92uSrtqzi/b20KNDXfv6Nas6vj7Z1mHhKKmdT88Nedcz84swwNmiJxl7GVw4Z86i6oGrli9r12FBTgmeUreQxlEBwWpvov/HFQRLSh+3M6HCTgNmFE7Wk6L+6K2s5gPvzBYPfc8UKMptHeHlOLqJN1UVNYImNl9qfHeXGcqH4EsXlxvM7nxOlGZ5tqbzrUK4WfU8E2vidZ6CvkDxvNOyaJO4iCScXkUoNN2MnEinDRkSkevswAA42+GWQAZ706/mFGehnbBOc7KmuelCna5aVK3cXf+Pk+7yEGXw+tRtHJVCiv33YTZHTfXtaTHRmTWu8jHzPCwGzXwr1mQ6M6sjt9UsIq0YjOgocpuGzDuQFPqzjai8+w7R9OJj/zMK3EEBs6S0Vy5MPE9W43h3LrUWh3lcR9WOn43TfmruVXI+Tp9NVGM9WImpq/evVSD/8IW2ekp1e/gaDacXOmYqpD6u2OjN3cT7k+RqEU8MyXkTS/9ueBAa/Mf+9D7WUjAvDagBqeZe4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199015)(8936002)(186003)(8676002)(26005)(31686004)(6512007)(36756003)(83380400001)(6506007)(2906002)(2616005)(5660300002)(66476007)(478600001)(82960400001)(6486002)(53546011)(41300700001)(316002)(66556008)(6666004)(86362001)(38100700002)(4326008)(110136005)(66946007)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWJIUTllZ0lCd1liNnZHWkNRYjFlT3hqNjRhM0RZb05icWNyenEwZStyemJH?= =?utf-8?B?TWkzK3Z3VzVkZzRxT2hHTGFuNUpveER5QjArZ0c0MmkyZGFLbnVMdmpQT2o1?= =?utf-8?B?eWI4ZFhKRDdCdEtCVXRUUko5OHIrYmdwc2FOZVdiVXNBZTJyc1pCakVUTWxz?= =?utf-8?B?UXorWENrTXZFUHBRRGpTUVFPWFhqcmpDRzdPZTlYa2FveFRIdEdMVkZSMEMr?= =?utf-8?B?VnVBejF1RWRwSjl3TSs5amg0Nmw5ckZ1M2VzNHA0TWg0cUJ3cGNGNndZTjAw?= =?utf-8?B?WUd0S3FYSnB6V2svRlhXcU9va01HYXphcXJFWkh4TnVBNTlEOHVwazZVZERD?= =?utf-8?B?Vi83SUtuNDEvMGpsMlJZNVA4ckpHNjhPSEhCSmhnTGxob3V6eEpCRFNCcEpk?= =?utf-8?B?dXpYM2FpUGJaZW9JOCtzOSs1TVViVU9MaWdEUlZ3ek9NRmJSRzdDdnE3SGNh?= =?utf-8?B?aG9IMXVaTmxwTzFWekxZVmdEN29DNjJURk4weWp4bHV3MnBYbFdtdG01SVMw?= =?utf-8?B?dGJETmFZa2s5bGFreTJWNW5NME5yNTI3ZGRYQjNtZUFsd1JoSzE3UmVhbWVS?= =?utf-8?B?Wlo4d1FzRTdRbnpwQ08ybFB0d0tIUkxoWUFlUVdGT09FZ2JHUktkYmQyazZp?= =?utf-8?B?M3pLaTE3NDEvWVRuZGRNUnh6RnNGWGRrczRiQXhPMW5RZ3QweHVjNmJ2T0NV?= =?utf-8?B?Mnc4dUZHWWU1Ynh1SzFaNllaMWNwUGNPRk1aWDdWRGVHVEl6YnBEa0lGeWds?= =?utf-8?B?eFZaT3I2RGJ2ekVkMkhKT2dveFBQNWFhUVF3YXIzYUF5YzNhMEM2NVZZWWwz?= =?utf-8?B?VUJZbDNzTUZiYXI1ZDIrbEpiUFZTZk1QLzN2ZW50OXRKWUYxUi9IVW12SjZ2?= =?utf-8?B?UnVkcitaOG1KZVNXdG5aOWFvQlR6akZ4MEZhTklYTVBNbnF1QU9CZkRWVjBa?= =?utf-8?B?eUZyQnhyWVFGN21JOWwranowRU5UZ3dxNmtybkpqdU5uSGFna29VK2RmcG15?= =?utf-8?B?Nmp0eUFWQ05oRExQYnVrSDVMeC85dDMvQUZGN25UYlJ5MWpOSlZFajlDV1hO?= =?utf-8?B?R2Y1cDdrSFN0dWNXYjlXUlVZSHJIWWdsRVRLclBkSzBPcVg2VTM0U1U5TGpv?= =?utf-8?B?SE1IcTV4dERNSTB4NmNRVkhCZUlPdXU3R2ZBbG5MQTQvMWFKZmZqRHYrTzZY?= =?utf-8?B?NS9MN3hKLzlqdW1CVXVsWWI3ZVNuNnhYNTR3MHBRaUQ5QjIyZUhOSDZ3ZkZR?= =?utf-8?B?QW1vLy9DdW5rTmxVUGowcm5BVmszZ1BOWFRGYTBnYmc1S3lCMk1YaDd1NzZE?= =?utf-8?B?MjVoRkl4UHNxb2RSMGcwRlQ4MzVuT0pwMWhqQUZjdVZLZ2EzeFdGRW9BNnVV?= =?utf-8?B?Sjc4WHdrLzl4NmF2VklKc2RIb21iMG9SNWRuNWlMUTdyS2RKelhYd3Z5bW5Q?= =?utf-8?B?akozREk3UDNsRjhUcnhXc2pMRkRoNVExS09NNmY4aDV4dFl6MGF1WlFYbUox?= =?utf-8?B?ZEVaVHQ4U05zdDVrK3NaeHF1a1hJMTNUR2ErOGJnZ25tZDFHN01iUjFZUEt4?= =?utf-8?B?S1FQZ29VY2xzMzZVWWZQTG1uMzl3VkRvR3NUM3B3RU9PWDdjWXI5N0RIVG5U?= =?utf-8?B?VVp5UTk3dmpCSEp2YzNLQzljUEtSVWhuZlpjajRuK1RWMVViRDl6ZTMrMHRP?= =?utf-8?B?MFVyYzVJeGR1TklhZVYzZ2szY09kRHdXLzNBMVlCSDJac3IzUGNuVUdONEJy?= =?utf-8?B?SDBCQ3R1dmpMeW5FVEs4eEFwbnF2aTlVNnZLWmF5V0l3c3hvdlZvZXVxNEFI?= =?utf-8?B?QU5aUU5XTGhjYno0bDQ3QkEycE1wOEtDZ0FFMFdLWFF5RmxWK0tTZVZPYmk0?= =?utf-8?B?dHFCWTFYYkh2NmNhUnpUYzh5c3REeHF0bFFIKzk2Mks1ZzJxRTBWNHRNaEll?= =?utf-8?B?Z21tdzNBV1E2OVZCcnplQ01KVDlTVGFzNjFwM2ZlcVVhOFFsaGpVU2gvM1A3?= =?utf-8?B?RE5tSys5eFkzbVUrQXdjTitJeHlPY2l0MTBwMFlvTlZESDlxNmtXSzFqZG11?= =?utf-8?B?WnRxckJVYWpyT2hHTG5ZT3h1UldDckJrVWw4TEtHTHhtekFxN1B0TEtMek4x?= =?utf-8?B?cVBLOTJROStkemthb3BSS1A0MS9MdW5qck1rNE85TlQ2NDh1TllQUElaTU5R?= =?utf-8?B?WFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 05082192-9f20-47e7-8893-08dab11ef362 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:39:31.9316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oOqvQDThXJRf/b8CC1qOaW0ku+VTSIWVknvJBgOJA4BOWss84AwCnupNCkmBxqxfviyeEhUl+meXMH3VgXYIpotfVkC7TlLFQr971CtTELI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6421 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Vladimir Medvedkin On 30/09/2022 13:40, Radu Nicolau wrote: > Fix a typo in computing port mask for Tx checksum offload capability. > > Fixes: 4edcee19fc20 ("examples/ipsec-secgw: use Tx checksum offload conditionally") > Cc: ndabilpuram@marvell.com > > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec-secgw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c > index 8a25b83535..75ba359e69 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -3042,7 +3042,7 @@ main(int32_t argc, char **argv) > port_init(portid, req_rx_offloads[portid], > req_tx_offloads[portid]); > if ((req_tx_offloads[portid] & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM)) > - ipv4_cksum_port_mask = 1U << portid; > + ipv4_cksum_port_mask |= 1U << portid; > } > > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { -- Regards, Vladimir