From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0078.outbound.protection.outlook.com [104.47.34.78]) by dpdk.org (Postfix) with ESMTP id EB7B61B32E for ; Fri, 19 Jan 2018 16:25:02 +0100 (CET) Received: from MWHPR03CA0019.namprd03.prod.outlook.com (10.175.133.157) by BN6PR03MB2691.namprd03.prod.outlook.com (10.173.144.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Fri, 19 Jan 2018 15:25:01 +0000 Received: from BN1AFFO11FD009.protection.gbl (2a01:111:f400:7c10::122) by MWHPR03CA0019.outlook.office365.com (2603:10b6:300:117::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Fri, 19 Jan 2018 15:25:00 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD009.mail.protection.outlook.com (10.58.52.69) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.428.12 via Frontend Transport; Fri, 19 Jan 2018 15:24:55 +0000 Received: from [10.214.249.53] ([10.214.249.53]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0JEFUY3010193; Fri, 19 Jan 2018 07:15:31 -0700 To: Jia He , , Thomas Monjalon References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-3-git-send-email-hejianet@gmail.com> CC: Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , , Jia He From: Hemant Agrawal Message-ID: Date: Fri, 19 Jan 2018 19:45:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1516161831-28719-3-git-send-email-hejianet@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131608491002690858; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(376002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(85426001)(54906003)(83506002)(58126008)(316002)(110136005)(67846002)(23746002)(65806001)(47776003)(65956001)(68736007)(106466001)(5660300001)(86362001)(229853002)(498600001)(230700001)(104016004)(77096007)(36756003)(26005)(59450400001)(53546011)(2906002)(76176011)(97736004)(31696002)(64126003)(2950100002)(81166006)(8936002)(81156014)(31686004)(8676002)(53936002)(50466002)(105606002)(65826007)(6246003)(305945005)(356003)(107886003)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2691; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD009; 1:n6OU6bKRx8ZHmmmpTaIvRPmKkPqBPNdJG6OiPr4ak7LAxNY7YQ2pYTCXcSPyI8uTtURA+O5lbPw/0Xg5AiaHhzzQ23ufBZONqqCmoDWP62Y2p/JpZcqkaUsUPv9MwEkP X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c294233c-88b6-4def-fd2a-08d55f50ce1a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:BN6PR03MB2691; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 3:HC+28qERIapp3MKtJZ2ozzUyFvM66bUHHIvHZZUPFw4zRJ3+x9mFXJy6YBUjG30gf7pQoJCrfWxrrFiSet3dxKBVMzC9Ndht4i2Io/cOO2+SExdPps0bpT1yd5QpfIzx2WWmf4Xma3orD5Ve8KbSm8SEBVtwPmMgFS0zitWaYktuOBg0gWBrHGjbo+bFMeDR3cwANqvvxEiJRp+dDTlHKK6iMT1cQlCriqij8mFKZ6Mh6qIhuXINVSS3YTCHsXiRCA/FFngUF5eIz+aUIaYPlqO6yQPToN5KuIAf82/a3hvBgitJmd1g5PLUJLbeou4Rude282eDILaBtcw2JRZX2H4nPMZ+bE3LWVk/qNg+BBk=; 25:otukPEb0JVkw0XmbQ/vQR8Y0zbAW/yRLthk0n5IA0HWxH6fI7WDvHADbdDbP1GmoYdhCKbAKvbRjTuQ5cUWuOHGIi4FUpS8Vm/a29SHQlEu6O5ppal8/+iz4dFP+TT8K9eQBs8GTicUOYFAm9e19D9NPxdnFe7KsL7JMmPZ10wRnvmbjKobfrsk+kUJm5bgZWfNsr7eumG2oTvl/MLZsH3t0kSo6Ps9/LNhTaXSvDrdp1MCTmKrDfgLuVVnz+jNUMhnsp3zPlp+UGpUDfy48PpFwwnZAA04D9Q13LnCPiZANn3QppTMANLDxdbMKMrCMH0NN32ea3/ELv5CbAIJAEQ== X-MS-TrafficTypeDiagnostic: BN6PR03MB2691: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 31:/8oCcOa4GU9u05Jml4i2syBzRn06MOsfVwnKw7SXqvrS9P37/v4Ce0aa2bGnccSZ/qO90kh441ZsEDWjl8cl6EgxBRCX7RBpJRNXtdGc9zRTlTOQATXNXJDK5x5KWH+ScBdeIwwghqJN5GZ5T7e2aFic4XLtVe3a+VKeZ8TXf58ppNwzOJaCYlgmz0OjnWICG83rrDPCv+H8/nfxZ3dG0Xn5DQXTMkUEZTTsFkew4ZA=; 4:Wad8OO8sDEE0TDEK89J059hWL/3fUPk3/t4UafRDu89Ydndy+Niw9BpaPQ5ZDIKUsOpKlivoWl8TrR5tEPEIBwfdYJwuIoLSolDzRbt7B4d8cryWIcxuOxP+tmDX0fsCtc6clOflVXZxDmPlIiyfu9IjKhdgc6JbZUZoO0+w7C7v9dcc2AdqEGrWxX6TXC4tyY8IA4xTaXZwcyGXiaEaEtQdBG8mY0X/Wm3kh+J0GMUGkRw8MOHUbWHe0dKychCV0UHA6gEwTUC+wD1xeQScS1M5/ZnUAKRTSvw9dCrthxmB3/vXTYaD27s9ssZQRZAc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231023)(2400079)(944501161)(10201501046)(6055026)(6096035)(201703131430075)(201703131433075)(201703131448075)(201703151042153)(20161123565025)(20161123563025)(20161123561025)(20161123556025)(20161123559100)(201708071742011); SRVR:BN6PR03MB2691; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2691; X-Forefront-PRVS: 0557CBAD84 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2691; 23:Fq+nLCnvEekzVmpNQoqRlNgy552QRPHCyx5bd?= =?Windows-1252?Q?00/48fbnJtTN0uRGHo6mT1fECbyD51EHIt9ODlgPnl34NZUcmwfPpHG9?= =?Windows-1252?Q?hwklO0S3/y0Q21UUbQD1zKIDcywLleNhXxJX9fuD/MrM+kKXltKKvifI?= =?Windows-1252?Q?DfCM/qwGppl9P+L0r8+ssdawpzwpZZewKc4njeHjdLNDWrFVGXBbQpox?= =?Windows-1252?Q?R93SxEJhkmEceqp550x2O/g+N6yxIPFJ1y/23Yz9Hq7LLHWLu3ZEW194?= =?Windows-1252?Q?O+lZ6v/nfReqDsPgxUm/9xXyV9tBhGmfQCrdjRD+iaJw6HEkklRKIbWd?= =?Windows-1252?Q?oRfCRQ7I1a6wVP850NEV9mb2ukEWxwuCzAwnaGcltQ90FlkFI4eaNfJg?= =?Windows-1252?Q?+z8DzEJAZnCrqC8Vi5nruowfz1q/o/sEc0hCoajPvtYJCBlQc1jcW7K2?= =?Windows-1252?Q?Q0nf2jLhVy719DU6PHfJ9mBj1ES3hH6E3iE3v39O+VU2Gpy3o9ue8OIw?= =?Windows-1252?Q?nvhPegae65tIvoG5eUZwMgLyJN2tlGHKhcAfrqtLq8wgd6i5N8WSVUUj?= =?Windows-1252?Q?BppPKiYb4tmutz1u6/lFJFDTyY0CsktEEOThELZEpnPiE1U0sjTITV5/?= =?Windows-1252?Q?q0kvDtb7uIlFesymCMD/TMyUMhs4/spVwrEZMVxJ3jYUTmVvrjlVisNY?= =?Windows-1252?Q?Jew7I0bxthqxfmqIsw+OA3xsYNaxsWdWlJAjWKFH39SV4Vm4J2wKcZck?= =?Windows-1252?Q?z7VtEyCn6GFZ1UVC3Mkq2cHBBncLpuDhMzIsIpj14VGu/06JeBI78BT9?= =?Windows-1252?Q?nsZBihItCC5xfbGDzpvr4UMNUsFCQe+/vlMVlLmiOtKs8RTllj3HzN7F?= =?Windows-1252?Q?qezUKyMq1zItaiJbdf0xp2U9L5oTWZX26S/Igr62vx2kf5Fgr5k2UhEj?= =?Windows-1252?Q?oYZA2bYpGtlqv4KkFXFjhCQWDTQVPFjprHVceGuhOeRmdLgwFE7Ar5GV?= =?Windows-1252?Q?xx8tBzo9j8gFmJqGx9pY/NZol7hORovVQCThls04CxImXLw9MLiunO6D?= =?Windows-1252?Q?CepN21CUxtO105/Z/CQ8HWrBgBL5LfCjMmiDoFUnZMlv+MlRVUNUUBVg?= =?Windows-1252?Q?aFvXNuQQ9vUcMKXWeqfcEMNFQueA3q6EAoJrklyrhs3T/adRHOFk4oyX?= =?Windows-1252?Q?UkD9KWJrBZWu1RLpwMX7XOCKo+2nkETnsXJFi2QySZivN1acSBRg7YUb?= =?Windows-1252?Q?X9yt5U0+Wr+cgflpiT3zLlWGje6zGKN0vlNlpulm9o0wDqZCbTYL5AuX?= =?Windows-1252?Q?JHCoZDPlHmkN+8A7kSklg5e+bbqTEVEt7oVjSSga85aSCKGiRbIvp8sB?= =?Windows-1252?Q?/zxYwcwSWTY7HANYiWy9r6cfSRngzLZhw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 6:8ufv7r0zkt7xEsv7lEnkJS/ujaAzalZbvLHNS/I27ZSlMc7TQfoypdrnv5f/w81O1o9XJfpqV4o1Y+fFIJWcg5pdd8zPj08bMp66ZV6qHsCXOeHoGybzbPLymnc45b6c7RKR0mqnC8zOT3YgbOxfBv+WnEmgNwdi7H4TiJrVGZwcZ+yPYXgNGILEa4dQ8eWv+s+xe/K2239ucnigm3mn8nc3QQyHk2cZfVD7EvxQDCdLZ2qEdFIkRwVAghIgXyLeo9p995SO/N615A/G9Sb7T9/boom4yrmqtwUqHsUD/NbaL2di09VsaIoyTdPMB7oD1cyM4H/BB9vqRi8E41OD8IWQMvbz5jGw9AbqKC4uvYM=; 5:pc3LBHm/sS6Y4KHAwcczX2tOfqAKVeJI5RtRhF7uN7LLhVkQu4+aZu3zBGgcblJ+9rRXs4c2kvMjmavHekI71FNVr6lPFVxagKS/7Ooj3yKVj7X1ttxC3LYTK7Ww0KdeMWhRG75JHHbDGrWwOP8v7NoZH0L7iSzIpmeBKvd7fF0=; 24:ESIV8+Rchv5n5/9wWk+p9/UIwuL56hVqYayFM1LY7zILkTEUe0o9HvYIKBOtmw6jtgNHSccepW1xBUtjU6580UXeSqbmkW7Qnq3JlJA2c1M=; 7:WJ55kZDHbNZM/jNHI9rCUIVVl4qyWi9EABRc4W5XWTpWcIay2dlgDb+bjgOiSOFPAEfAELZBy69LTmlujyc/UNnHoCW+qPcE7Htvfj6HNLdUbRHBJTTBnNkXtlcIQkxuKokkbULDfkdVihslilGP2rR3/Th2aHOradYTpO8RfftQcDo97DltwOQIBJjq0vHoBnyS8ud9+K/sZXjv6wG1fbQTasDCE/S3JRwvtgbZ/PcSMmUgMBoLpKMrlOSDxJFq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2018 15:24:55.2770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c294233c-88b6-4def-fd2a-08d55f50ce1a X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2691 Subject: Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 15:25:03 -0000 Hi Jia, On 1/17/2018 9:33 AM, Jia He wrote: > Move the common part of rte_ring.h into rte_ring_generic.h. > Move the memory barrier part into update_tail(). > > No functional changes here. > > Signed-off-by: Jia He > Suggested-by: Jerin Jacob > Suggested-by: Ananyev Konstantin > Acked-by: Jerin Jacob > Acked-by: Olivier Matz > --- > diff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h > new file mode 100644 > index 0000000..01f2cae > --- /dev/null > +++ b/lib/librte_ring/rte_ring_generic.h > @@ -0,0 +1,202 @@ > +/*- > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * SPDX-License-Identifier: BSD-3-Clause The SPDX should be first line. See other files for Intel or NXP. > + */ > + > +/* > + * Derived from FreeBSD's bufring.h > + * > + ************************************************************************** > + * > + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions are met: > + * > + * 1. Redistributions of source code must retain the above copyright notice, > + * this list of conditions and the following disclaimer. > + * > + * 2. The name of Kip Macy nor the names of other > + * contributors may be used to endorse or promote products derived from > + * this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > + * POSSIBILITY OF SUCH DAMAGE. > + * > + ***************************************************************************/ > + This is BSD-2-freebsd, which is not a approved license for DPDK. Can you ask Kip Macy, if he/she is ok to re-license it with BSD-3? Please check with legal, if you can just keep the copyright of Kip Macy and re license it with BSD-3. I see the BSD-3 license to be permissive enough to be re-licensed as BSD-3. But I am not a lawyer.