From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B0C3BA0548;
	Sat, 16 Oct 2021 09:50:52 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 42C0840040;
	Sat, 16 Oct 2021 09:50:52 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 893A74003F
 for <dev@dpdk.org>; Sat, 16 Oct 2021 09:50:51 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EFD907F567;
 Sat, 16 Oct 2021 10:50:50 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EFD907F567
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634370651;
 bh=tJyxMVEWdTaEbI8CnxhQMhS+MxEpM8coXoUaeW254c4=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=XmtXwEsXGB8WmmA9e2IHU+5qDMCKcPLli92bDuIM5NMckQICl75nsdOI+wraBbXIg
 Y8tcGSPVs5h/nhFAe5XGIFFc0cyGiRWxro+8rze6vju1ETdZIKojca9dCOipihp70D
 gaZAB+tl8n2ghLveghKJ6apZTpaq/FTAGGqK3laM=
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
References: <20210929214817.18082-1-olivier.matz@6wind.com>
 <20211015192408.21798-1-olivier.matz@6wind.com>
 <20211015192408.21798-3-olivier.matz@6wind.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <a779f5da-0875-76b6-be93-500eedba91eb@oktetlabs.ru>
Date: Sat, 16 Oct 2021 10:50:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211015192408.21798-3-olivier.matz@6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as
 deprecated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/15/21 10:24 PM, Olivier Matz wrote:
> The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are
> marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
> VLAN flags") (2017). But they were not using the RTE_DEPRECATED
> macro, because it did not exist at this time. Add it, and replace
> usage of these flags.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

I'd remove these flags completely. 4 years is definitely
enough. Yes, I realize that because of missing
RTE_DEPRECATED markup users were not warning on build.