From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DCDD45E2D; Wed, 4 Dec 2024 10:48:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22C5140B9D; Wed, 4 Dec 2024 10:48:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id DE15B40B99 for ; Wed, 4 Dec 2024 10:48:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733305737; x=1764841737; h=message-id:date:subject:from:to:references:in-reply-to: content-transfer-encoding:mime-version; bh=1sZs9o8CQdXtRw037sHL1+kH50yRQX0fWbWvfBGgPGY=; b=PDXnPLWy4T4p5H9544XRMpUazzsYq+BVV1O+k4/9eHUv2FKE4OEc2KZV smkNXMvS3oj0EW0vCpPnPvJjMgP2G8C3ssA5uiq2CKa2sEiNxEbbyV3Ly WXeClqS846Rv21rDAVcdsAU200hihy14gYkaMeS3pzh9IuhqsoiK5/mZ3 9whKnYCG8n5wEVb4wu22S7lyRUvCWYLFDTljRBdNgvWyi0D/4tBZbeYqH ugeEQ1lHLlrCP27igYmVkJJD8UEqsICdXiR9O7X6FOcywof1KOUXUpdzU ZE224Ff717IGCLCM9KmKvAJdmDeHWYcx+ySCAuIpADAgUdLQxDzqirlXI w==; X-CSE-ConnectionGUID: hEPKZJ+RRF+1eS0gHtB6Pg== X-CSE-MsgGUID: jmBk0z9LSiCDBcghkxp87g== X-IronPort-AV: E=McAfee;i="6700,10204,11275"; a="51095283" X-IronPort-AV: E=Sophos;i="6.12,207,1728975600"; d="scan'208";a="51095283" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2024 01:48:54 -0800 X-CSE-ConnectionGUID: xsohlBdJTaezIwH9s/ePzA== X-CSE-MsgGUID: DOp3CimnTKWbVy9p3MxMHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,207,1728975600"; d="scan'208";a="98704723" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Dec 2024 01:48:54 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 4 Dec 2024 01:48:53 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 4 Dec 2024 01:48:53 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 4 Dec 2024 01:48:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WGK6D8udmCs3shaE8DvXVBHEUMejWjRVEpl6hPMOZ1ZuxXndR991THmkNSTkwWZ4lJEi0rKSwWgfYPcOo1VdkSjxIysVDWXN6pMEpOHKe79xN1pW7aIkjbi2XvTcHhjcekEqDjc4uguasCuzldILnubvgSHtV4OKG6UlDyhjMGBcqYUB3gsa10W94AeiCOLKD1iiq1H9r3FWtPvGZ6R67y+bQ7Bx56YkDu8PD6I5QByP2fDFlgnGFFG9lTgYotuutwMse6pDlNfkAbttuHQA90kVXY49jYKOiWX5BZBxB+lE//zDojjrLTO0chzfSplLZC67LAJrcuJSPPgaV73xaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XixRNsMpEIdo5hWtNewQ/ePkQM9PmbF09UnPubAmLec=; b=zPLkk9EmSEIF5kcXtdzAiAJPGREmL+hDrpJCIjDE7aifCUsYlxt0NLwKuaw3K4sxurfJCP95zpAbSGXAIrKyE/GajTDdpsbLFrYt67Gkp0mO7iZ4TFIwQ8XNUVDSmqBOI2IcYDQYnhwGNWRPwNZuT1JTM6EzZlgyhyYhUd0cCrHX2c06+ka9x9eCEADEjHzEq+2iQY/tkFay8074Qfg2Oa1fEeoZJnqcpLcgTzuRQf4KMmPoqo8agJQUWOnhpyUpcaMlBeExBudI+0BGcynuMYo3suZoNGe8Vh8Uco+NkGztm5v+94KAW514RHbKjV+YjHbk0IKgHDVUhfbL2wSA1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SA1PR11MB8426.namprd11.prod.outlook.com (2603:10b6:806:38d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.19; Wed, 4 Dec 2024 09:48:51 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%3]) with mapi id 15.20.8207.017; Wed, 4 Dec 2024 09:48:51 +0000 Message-ID: Date: Wed, 4 Dec 2024 10:48:47 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/1] Rewrite devbind From: "Burakov, Anatoly" To: References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR05CA0019.eurprd05.prod.outlook.com (2603:10a6:10:1da::24) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SA1PR11MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bac1610-df54-4252-7bc7-08dd1448db6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MjhDdUYxNEpFMWl4Sm5FOGh3b01NbnhZOEV6VFlFbi94VHFpeExhZndPWmsw?= =?utf-8?B?WndpMHdkVnFsMUpYUDNKTUIxc2h2eUg2ZHMyUE9Qb0o5bHN4UlA4M2xJRE9v?= =?utf-8?B?ZXkxZkdNcHpnNjFKTStJeER3ZVkwZFQ1Q1dqemVRT1BXTXNPaDkyRUE1dkxF?= =?utf-8?B?MWtFRVBwa2FENlFmT3lrTGU1TUllditMY2pPOG95bVAvNkxya21mSWRCcmht?= =?utf-8?B?UXBVWWJFay94WHdqaDVtUXJjRnZIVERpYjFYT1pNdGU4NllvcUtPeEl1VzZL?= =?utf-8?B?ZVEzNmYyNlNDa1hPejYxeXpidkx5SzhzbVBLb0x2YzlLb0VuZjliY2J2YUJy?= =?utf-8?B?UkZMYVNsaWtYeEFKQjN1NmZYQzNGbVdwbHNmcno1SGpKRWNySlExNG5weG5r?= =?utf-8?B?cHRSbi85bEtEQ1JNU0U5cThrR211OWpKWGZFVDlEbWZPUjIwRGt3dmltOW9z?= =?utf-8?B?cGxDdEYrelR1dEtTbXRqbDVvWFlobXhRY0ozbVdVcit2aDB3Q0Vyc2NUVHB6?= =?utf-8?B?aTUzdVBPeGNFOWlKdDRHTnJZbnVyd3VUZ21XTXdwZ2ZmV0p1WTV5MUF0dm8v?= =?utf-8?B?czBLRTdhbS9wN0VKcFVkOVByOVVrN1hTcTFxUFJvemlsVTJwazIyckRucXB4?= =?utf-8?B?NjZxejNveHVPYWY5MDZiL1NITk9IS0YrRzVtd2hsamI3VXkzUVVBUjBOaWR6?= =?utf-8?B?VWI3SW5sbnFPSVhRQUFvZHZjY09Wd3FtMEFhb0tEczk0ZlJod0dJSE80QXpK?= =?utf-8?B?R3V6MHZaSkFjOXpNUXRRaU5ZZ0FLUXMvRkcyeFVlRjMrU3dLWC8yZ3hnV3FB?= =?utf-8?B?VThhTW40eXhNOWtPKzFzSTNiOGFZcXJieUNsSExxcWxrU2ZaSVBESml6MWU3?= =?utf-8?B?U0FSaDh1Q3hmQUxIem96NUR2TXRsL0tYcDMyd1FvTnh2MGVzblcrblBiZy84?= =?utf-8?B?SzhUOFoyTXNmYTQ4dmJ3VkhrYjF1U3drWGJNRDdzWml5SjhrUGkvNm9HMllj?= =?utf-8?B?ckhFSFI1Y2k0K3BFNGxDQ0R2K1cxV1RLNEQwM25nSERGRGFjcDNKTUEzb1JW?= =?utf-8?B?bm4rRjJWK0hvOGVkbS95SWRrZ2M2NWFtM2k1VzhwTloraFRBcGRMWmQ0OWFo?= =?utf-8?B?WVl5SGJLeGFXYWpORmVITWoyN29PVElsNktYeXdWRVNVbEVsZll4WVpoSzVj?= =?utf-8?B?cXRrOXhnV0xxRHVaVW1lYS9BZEU5TUNXaVNKcllqUnRPZXNkN1RBQWpxbVVm?= =?utf-8?B?YVl6RE8xdE44dUNMcWc2TXg1akJIVXdUQW5vaGJ3b0xQSEVtVHlJRWlpaGx2?= =?utf-8?B?R2FJZlA5cmJuaEhJSUNnTkUrOUxUOGRrVnBrcEdWcEQ4WjBWSjNHY3YycHor?= =?utf-8?B?UnpWR3NaRUduKzFERE80dnZNNFBoU0ovQzkveG4rbC9hLzMyUXF0b3krYVBl?= =?utf-8?B?ODVsZE4xeGtUY000WWRpNml6Tit1MTVFV2x5REtjTEZNd0gzMm5nQVo1Ym9R?= =?utf-8?B?MXU4Ykl6dlVUWUVwa2Q0UW1vL0dlSW8wSmh2eWxFSXRaMVBkcndJLzdlRlBK?= =?utf-8?B?VTREdTU2VGNNTFIyODNCeUVma0dFNGV3TnIxQ213eWY5OXF4bEJVY1lTN0Za?= =?utf-8?B?R3ZtR0U3a2dKQk1uSitLQzlGSnppVGY5QUpRZDlxY1BMcGVJTWZxeE8rVzZ4?= =?utf-8?B?NFcyMHc2Qm5EL2VvU0hUYWxJYUtoV2lQQVhUalNaUVZHUkJjUWpPVnV3eFhT?= =?utf-8?Q?1d4liy3I3k462CAuUweNF/XHQoM4Aseul6A2UOs?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXRqbGtCOFprWW0wYnpTMzQ3cTVXZmNSWng1Z2szYWZDclArT3E3UTg0Zzg1?= =?utf-8?B?WnZSWGdIVmlhMEdjTi9SaWkzZ2R4VWRtTFZjV2ZGUU8wZlFFZlJ5S1R1SXlx?= =?utf-8?B?ZWcrd2VTaHRCck9lU1BzUWVmU1pBQSszbVA2ZzB4T0dHUzg3NUdBN3dWR0Ro?= =?utf-8?B?cVdmSEdkVHRLV0ZzYUVFbDZlbVVYaHJ4NEdVSnFKT1JWUUloVlpFSVh0YXNO?= =?utf-8?B?Z2NZakpzLzhiMGVWMVR5ZXY5NExwSDlWZ0I0UDBHK3BLMWgrVHNiR085K1A5?= =?utf-8?B?d2hSdHlnQ0dpZS9ER1pxQVR1YzI1bGhydDFPa3RMOTE0OGpzL0kxK1orOCtm?= =?utf-8?B?bjNDN1FIWkpJTDlGWWxvaGNUaTZZSUlmRURWa2hPTU9BMDhQSjlmY0JXa3d1?= =?utf-8?B?aEN0UjlJdTRnS3JCVG9Ubi9EeUtZa05iRUQ0MUYwdjlzQXZNNDg1ZmtuOGt3?= =?utf-8?B?U2hUS2x6Y3d3V2ZmckpQZ3ZMR1RiWkxpWUxQKzkrRmdPdzV2MWlnaDZQSUVZ?= =?utf-8?B?OXF5cDc4aGdtMS9uRHpJMDlRWEpXMUIzVDBJVC9rTUxUQ3BoYTdXcDU2WjJJ?= =?utf-8?B?c1NmRnZQKzlCWHlvQUJVTHZGL1RkMVpYUUlFcUlvcWE2UmcxU2cxelA2MGRO?= =?utf-8?B?OGs1YU8zWGR0bUd2bGNEaGJSNExrRUgrb2l0YmROZERyTTFSUFZDS2RWZ1J3?= =?utf-8?B?MW9BUktxTmx5UlV2ak1nUnF1dGdTeG5wNDM0VTdHUjVPNjhGM3I1NEZ6aUFI?= =?utf-8?B?L3pGYzZuM0toL2VvSDhaMXJzY0Y1aG5ZZElzUXd1TGl1SDlRdFp2akw4bm1K?= =?utf-8?B?Ym10UDNyNGtPNkdVVmZTUm5QejRKajlLVDh5cTJFUnJrQVN2UGJKTUI1czdl?= =?utf-8?B?VzJtbzF0Kzl6bVpGMTN2UFZnUlJqc0JSbmc1V2M0K0V5eXVRSjZTWnZKa2Rk?= =?utf-8?B?ZktSaW1NbHg5eklEQm11MlpjMllJN2pkdEJtOWkyQnUrMENRT2lEWkI3ZWp2?= =?utf-8?B?b3ZjczN6bk42VzMweG5DRTA5ZE5HRDZxU3U2R1VIVG01RkpLRnA1R1NFZWJI?= =?utf-8?B?OS9lcFVjdVNrZk14SXpySzFuZi9OVUJ5N2M3Rzc3RnZLTHlJRXJlR0FDZmRl?= =?utf-8?B?eExwQkJ4Vkt3NkpscmRiS2VLSVJaVXhBSStvazYrNDZpc0tDeHp2NzIwVW1Q?= =?utf-8?B?REh0QmZpL2JlbWdXSUFFRlZsWjB4NFVuU1BhQnR3aGNZQUI2eDhkbk82MmxT?= =?utf-8?B?WEJuSEFQNlVtbXNXN2h4Z1orS045Q2R4cjArRWtNR2RRN1hMNmlkVThQTXQx?= =?utf-8?B?eUVheDc4ZDlMcVpoSTN6dzNSS3dLbGZWQzJKUXpjNzE1NkVvdG8vbS9SL2c2?= =?utf-8?B?S2FGQ1l4Mk1ROGNSeGhSWGVXWjNOSnZhTTk1NFk1c2Z6TEswekxBaWM5alVJ?= =?utf-8?B?QzdUMTQ1VWtGWWhudHkxenNFeHNnZ0JXa0wzT3JCYXF5cHBQSmZvZkNGUFF1?= =?utf-8?B?dmUvYmwxR0tyZ1pCMWtRUnFWMGR5VHUzTUs4VnVGQzg4cU9sQUFSSW5HZkxt?= =?utf-8?B?aW5DbmhLMGxGV0RSc2swZHh5NklLSVhqanhobUMxTGpzUy9vcklKOXZ0QzQz?= =?utf-8?B?V1R3YmpYR25YcGdHL1NEYkhWTHdHaFF4aXlmRlY3b3JMOXhtZDhXSTRyeWEy?= =?utf-8?B?RGgrcTJ4UXpGbFUvU2owT1NNMTZabEpOclIrVFZZT2lxOUo4dWJDSEg3TGFB?= =?utf-8?B?UGswbmUyeVNNME80U2ZUV3pjRGNDMThpMldwSWp6ZGNpUVFBRU56R0hLNDhU?= =?utf-8?B?ellrenNkR1ZaLzF4U2F0WTZwUkpQak1nYVowZ0hDbVYvRG9JNmF5WUg0YlZp?= =?utf-8?B?ejg0ZjhqZ2luODJXa1Q4VkZid3I5V3ZTQlVvSThZQ3VmZ01nNlliclNtMlNE?= =?utf-8?B?Sm9SYmk0MW4rcGRkS0NjcGJwOGZJeEtnVXQzK0ZLOXp5SnBKWk1WdGhRU05y?= =?utf-8?B?TU40Vnc3bVNIOTJ2dkp0UnoyVEQvK2V2dytIOGtvSFk3b3BnMDhGeFJmV2ZG?= =?utf-8?B?Vi9kTlZITVdMT085ckU0YVNPUXYydHI4V3FadVJtcnE5b0trcDBSZzRueEhS?= =?utf-8?B?Z2Ztekl2b0ZwZEZ3RkRSTXdNbCtnVE9HK0UyOXY4em5iOXhscnJBYjE5cFJM?= =?utf-8?B?ZlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0bac1610-df54-4252-7bc7-08dd1448db6c X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2024 09:48:50.9118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6l1V7qQ7tI8SXRt83nuCPYCbfTwDTc0TT5T0c7V+xWnnzd2v7MREa0vtKNB2Ek4adqfjmEoLM9gC/SFgfD3vAuwULT2qKGVK399mjm79Nos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8426 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/4/2024 10:45 AM, Anatoly Burakov wrote: > It has been suggested [1] that a major cleanup/rewrite of devbind would be > beneficial in terms of long term maintainability of the code. I was in a > coding mood over the weekend, and so I've went ahead and rewritten devbind. > > Note that this is one giant patch, rather than a series of patches adjusting > existing code. Making it a patch series is possible, however the internal > code architecture diverges quite significantly from the original devbind > script due to its copious usage of string operations/pattern matching and > global variables, so it is unclear whether subdividing this patch would be > worth the effort. Instead, as has been suggested [2], the patchset now > consists of creating a new file, followed by a removal of old file and > rename of the new file. It is expected that this will be squashed on apply. > > The script has become slightly bigger - 1000 lines instead of 800, however > I would argue that since most of that increase is infrastructure, comments, > and sacrificing code golf for code readability (such as expanding one-liners > into multiple lines), the trade-off between being able to read and reason > about what happens in the script is worth the added line count. > > [1] https://patches.dpdk.org/project/dpdk/patch/c2bf00195c2d43833a831a9cc9346b4606d6ea2e.1723810613.git.anatoly.burakov@intel.com/ > [2] https://patches.dpdk.org/project/dpdk/cover/cover.1733151400.git.anatoly.burakov@intel.com/ > > Anatoly Burakov (1): > usertools/devbind: replace devbind > > usertools/dpdk-devbind-new.py | 995 ------------------- > usertools/dpdk-devbind.py | 1683 ++++++++++++++++++--------------- > 2 files changed, 913 insertions(+), 1765 deletions(-) > delete mode 100755 usertools/dpdk-devbind-new.py > Please disregard this, scripting mishap. -- Thanks, Anatoly