From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 540562BC9 for ; Mon, 28 Aug 2017 18:42:59 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2017 09:42:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,442,1498546800"; d="scan'208";a="123302180" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 28 Aug 2017 09:42:56 -0700 To: Alejandro Lucero , dev@dpdk.org References: <1503591622-16232-1-git-send-email-alejandro.lucero@netronome.com> <1503591622-16232-3-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Message-ID: Date: Mon, 28 Aug 2017 17:42:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503591622-16232-3-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/16] nfp: add specific pf probe function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 16:42:59 -0000 On 8/24/2017 5:20 PM, Alejandro Lucero wrote: > Configuring the NFP PMD for using the PF requires access through the > NSPU interface for device configuration. This patch adds a specific probe > function for the PF which uses the NSPU interface. Just basic NSPU access > is done by now reading the NSPU ABI version. > > No ethernet port is created yet. > > Signed-off-by: Alejandro Lucero <...> > + /* Check NSP ABI version */ > + if (nfp_nsp_get_abi_version(nspu_desc, &major, &minor) < 0) { > + RTE_LOG(INFO, PMD, "NFP NSP not present\n"); > + goto no_abi; > + } > + PMD_INIT_LOG(INFO, "nspu ABI version: %d.%d\n", major, minor); > + > + if (minor < 20) { > + RTE_LOG(INFO, PMD, "NFP NSP ABI version too old. Required 0.20 or higher\n"); I believe it worth documenting this detail in commit log and documentation. <...> > > -RTE_PMD_REGISTER_PCI(net_nfp, rte_nfp_net_pmd); > -RTE_PMD_REGISTER_PCI_TABLE(net_nfp, pci_id_nfp_net_map); > -RTE_PMD_REGISTER_KMOD_DEP(net_nfp, "* igb_uio | uio_pci_generic | vfio-pci"); > +RTE_PMD_REGISTER_PCI(net_nfp_pf, rte_nfp_net_pf_pmd); > +RTE_PMD_REGISTER_PCI(net_nfp_vf, rte_nfp_net_vf_pmd); Now pf and vf drivers are separated. For existing drivers this has been documented in features file as another file (another column in table), but we are looking for better representation for this. What do you think, does two drivers has significant enough differences to be documented as two different drivers? > +RTE_PMD_REGISTER_PCI_TABLE(net_nfp_pf, pci_id_nfp_pf_net_map); > +RTE_PMD_REGISTER_PCI_TABLE(net_nfp_vf, pci_id_nfp_vf_net_map); > +RTE_PMD_REGISTER_KMOD_DEP(net_nfp_pf, "* igb_uio | uio_pci_generic | vfio"); > +RTE_PMD_REGISTER_KMOD_DEP(net_nfp_vf, "* igb_uio | uio_pci_generic | vfio"); > > /* > * Local variables: >