DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
	Patrick Robb <probb@iol.unh.edu>
Subject: Re: [PATCH v3 3/4] dts: add per-test-suite configuration
Date: Tue, 19 Nov 2024 16:41:27 +0000	[thread overview]
Message-ID: <a7e923af-11bd-44bc-8085-083f2e8349d6@arm.com> (raw)
In-Reply-To: <CABD7UXNU-0h=F2OugK2yqy=d3wR7GWM-VOjN3rhO=Y8H-S=Eug@mail.gmail.com>

On 19/11/2024 16:31, Dean Marx wrote:
>> So... this is a weird one. I've integrated the code generation under
>> dts-check-format.sh, so nobody should really worry about it, as that
>> should be run before submitting. If it's not, then the CI will
>> eventually pick it up when dts-check-format will be in place.
> 
> Right, and that definitely makes sense logically but I think maybe
> even just throwing in a comment in conf.yaml similar to the one you
> used below (timeout: 20               # optional field from
> HelloWorldConfig) would be beneficial, even if just to show where the
> customized fields should go. If you'd rather leave it as is though
> that's totally fine with me, this is kind of a nitpick suggestion
> anyways

Oh ok, yes it makes sense. It's a good shout. Although, this patchset 
may change how it will be once we start splitting the configuration file 
in multiple ones. I guess we'll see what happens then! This will 
probably stay on standby until we reach an agreement on what to do.

Thank you for your review!

Luca

  reply	other threads:[~2024-11-19 16:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 16:13 [PATCH] " Luca Vizzarro
2024-09-27 17:45 ` Jeremy Spewock
2024-11-08 13:38 ` [PATCH v2 0/4] " Luca Vizzarro
2024-11-08 13:38   ` [PATCH v2 1/4] dts: add tests package to API docs Luca Vizzarro
2024-11-08 13:38   ` [PATCH v2 2/4] dts: fix smoke tests docstring Luca Vizzarro
2024-11-12 20:03     ` Dean Marx
2024-11-08 13:38   ` [PATCH v2 3/4] dts: add per-test-suite configuration Luca Vizzarro
2024-11-08 13:38   ` [PATCH v2 4/4] dts: update autodoc sorting order Luca Vizzarro
2024-11-08 13:45 ` [PATCH v3 0/4] dts: add per-test-suite configuration Luca Vizzarro
2024-11-08 13:45   ` [PATCH v3 1/4] dts: add tests package to API docs Luca Vizzarro
2024-11-12 19:55     ` Dean Marx
2024-11-08 13:45   ` [PATCH v3 2/4] dts: fix smoke tests docstring Luca Vizzarro
2024-11-08 13:45   ` [PATCH v3 3/4] dts: add per-test-suite configuration Luca Vizzarro
2024-11-13 21:44     ` Dean Marx
2024-11-14 12:39       ` Luca Vizzarro
2024-11-19 16:31         ` Dean Marx
2024-11-19 16:41           ` Luca Vizzarro [this message]
2024-11-08 13:45   ` [PATCH v3 4/4] dts: update autodoc sorting order Luca Vizzarro
2024-11-12 20:04     ` Dean Marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7e923af-11bd-44bc-8085-083f2e8349d6@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).