From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 405C441C30; Tue, 7 Feb 2023 15:49:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F9C142B71; Tue, 7 Feb 2023 15:49:23 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2082.outbound.protection.outlook.com [40.107.96.82]) by mails.dpdk.org (Postfix) with ESMTP id 1EEB342670; Tue, 7 Feb 2023 15:49:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ziz/lN3xMxBQ3aSPvt2sAo89CVfB2Lxo7QUB9Rzi5R44FuuWJPY1q4miH0c7EOdwkIKaWUCBKOCHDkteuXfGrR9khW0sveNZrQ5NdiO4i+Uol3ZEvltjjpiJR/Yv3LSnmhfD1ByX7qPDk+i5ybL338wkt9ePCaNTQV52UB23yHeLtrgDcwpfGHs0Ha+LGKhM5TAmzxlVPtRpbxyqtR+W88w3nIG/WHmLKkSOFlScG049wCpkkfwOFiYpITey+45zxsumkRNWRG1QFV3ry8enn2NiWzEu1DN8ednrFSzcaKcIS6nziluEy4ijkYgNy+Xc0BC7FPXgbgkNoVGl2Jeb3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1UNOWOBL0xj5qwco+1PBDoG2y1kTh9sjk6GJDoI8e8=; b=Ua+JbSuyB/SW1oxOevo8gzfCOMPVOjICfTHNZS+TG9hjY4LDnwiZav/2oYm65xiUUylCtxNCTBhOuZIiDwqeseMvvX40S2edO4enA1Z40b4VrONEl3Ac9QET0D1ePzu/ByQSW7iDpJKvCd03qLMyCnvB0Q25NA0NoQFB6B1MaoI2JP8KoJ3NqaDQj0e/D5d4NweQ0l5ovxgDivREwoIss0e5XUOHq9Sh3GI42rD70t6rJXE/LPoxnXXS0VR2e0sNwgSCLXynxdgpA5pClUBGgTwOArUjaRPqLSFGT0hbeRNm9OyFuOYbvbOIRt7zXrSX0g6v7Fq54Gt09pn+cVrn0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1UNOWOBL0xj5qwco+1PBDoG2y1kTh9sjk6GJDoI8e8=; b=twvuddqIupivJirLDceEbwD6rvpROhpji7KnuMrcW5uc2RZo4I+GhWmtP3B9itTfoAjPDo0pqDBoZ37FSJG7B92CrWiSgsVh3CAAIKPeQqHKHaJ8pQ4cFjyOWBHIjQIuGGOZKBqXgezuaxyjE5sVwxiHl70kfk/lJh6TlAEHB+c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6728.namprd12.prod.outlook.com (2603:10b6:806:257::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 14:49:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 14:49:20 +0000 Message-ID: Date: Tue, 7 Feb 2023 14:49:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v11 3/3] testpmd: cleanup cleanly from signal Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org Cc: stable@dpdk.org, Aman Singh References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> <20230203191409.97567-4-stephen@networkplumber.org> From: Ferruh Yigit In-Reply-To: <20230203191409.97567-4-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6728:EE_ X-MS-Office365-Filtering-Correlation-Id: 569cf5e0-5128-42d9-cf35-08db091a7ea9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r/7t7TzG0Py7A7+9nZWlABQM/VFeE4EoaKGku/HBMgzLIB8ftDzZrM7J/N09i/S6V+X9tyAfBhuDl2ao0yI4ZImhlEIoDQQY6CI6Y7yWxDAW06etvwxUQcY4+sPj94AsYKrmepfAltb4ffcgDbxlyuVK8KT1HFJ9Khavh3cjsQ8nvxmZcB+PCgZ+emZT4oYF49QRhv0mGPuXkSElQIqbNHg9x+kfRJSJyKihEvoGEIf5D9tWFJn+trKNg3rxpTlzNEh0C4Jj+Rlr4GTwnbBZiZbllQD+Jcu0sYiP4+dEAETd0BOkePwOE6FYbUkuzgnlnmMLwZHjl4fpuJyTR32mom43vrz9VMvK6O8iZLmBdyoDbkoIFU82RBSFq3sKhJhJhawbq2kBpHuNU/SV+udGGNxX+efDFi1wzLffQhG9XJgbQ5kdFWA2iEjUwLsQg6GHjogNWj9gaoRRSsYvZKoQR/xqzjOsFIrbH22Gp/UvSJdPrygAQA+THRWKiS/mpgzbZRuGOQGF212CK7Kad5X9zJmbFYyaPwIEk3RHavigYBJ4wh+6FLleYitrcYgQizHdoCe4xA8iOSAKKZDpOZxfqVB91JGUBBK5vk0Om1gtF9z9kk2CKn8+zvWD63lzaMX/DoivHel+eczysj+CcSKZzgcpDH/c0MoD4U78/zaSBAY3G73IGNudE3mT9TCmF2DxlgxPA9rkGNplFCdDkDpzrHBtPKN/t0y1fhitVEAfvaM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199018)(2906002)(38100700002)(83380400001)(316002)(4326008)(66476007)(8936002)(66556008)(41300700001)(8676002)(44832011)(4744005)(66946007)(5660300002)(2616005)(6666004)(53546011)(6506007)(6486002)(26005)(478600001)(186003)(6512007)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVdyTmtYVDlBeVVONi9nbGN5ak9UaWVISW1PU3J2MzFHcEc5S3M0L0xIeWpu?= =?utf-8?B?RmtKVHMxSmZaL21tcThPV1o3TVlGdm56L0l6N0p3aWxuYVltR1lhbHFIT1g1?= =?utf-8?B?dkF4UnZRWGhWYVFiTUFXUXRYa3BCL2x0Mmg4VHhnRC9BWk1ZM2w4M0pqb3lQ?= =?utf-8?B?clJnOWIwWW5YZWRiaDQ0b1U2ZGd1dnJQSzFPZURtYkZmQ1hYOG0yWnpKTWpC?= =?utf-8?B?RXRnZS9VU2gxUVdkUEliVHFJL1lNRzkyMENNcFFGS2hySVNNd3hJcXBHdmRW?= =?utf-8?B?YmROU1V1NkwzU3VxWGYyQnp1Y28rcFIvbDRJdzRQQ1lpZDZSUVgzZnV2MEFU?= =?utf-8?B?THIwZWttVUY3ZGRuOW9TM0wxM2QyK3RRNFBiRHExK3ZhSVhsanBWRDM5LzVx?= =?utf-8?B?c3NUN1kvV2szVHBOTTF1UWtYdTIxcmJXY2pEeSs4bmtDdlUycUpWNnZjTGdj?= =?utf-8?B?dGkwUDYrclViNWdoZ24vRmkxaTRYampObm5ycUZ4VnU5NHBJYy9PTUFYUGVZ?= =?utf-8?B?Q0l4dlVnWWdmVzgvTFE0Q3lzRzJqS0lxLzRGMkpLTWtDMUdEdDI5RzJIV29Z?= =?utf-8?B?VjhWZjBldXE0ZUs4WHZLM1lsWDdvbTRQbXpmRlJYM1R6MDlrOXVJQnJCNTd5?= =?utf-8?B?d0FJVWlSd3FOejNaWDZITmFOWXltSnl6M1BzWHZNMDEyYjRCRElLeXpCTmpN?= =?utf-8?B?YWhCSVJiVk5XdTA4SGFoZmtRWXNRVStYaCttN0ZVOFQxdG10UWRYS0NCclVp?= =?utf-8?B?bUV1ZE1TZ2d0N0h5TlhrOW9rTkJPcEhxVS9pbjh2ZmJRSDNVMmRXQ0xDSkhD?= =?utf-8?B?MEpnaHhiR0RpbXVEcEc5NldpenlOcFp1c3l5QlJIU0w2T240bGlWY2ozVFVv?= =?utf-8?B?cDNZR3RFVmY1SnNhWUl5UGRESDhNSHU5Wk1FQWJidDhBaDhTOHBCbEd6UTFT?= =?utf-8?B?NmVxNEo4Qk1ybW9lNFZaNnA2ZVplTDFwREhwQzZvMFNVQjlmNWs5OEx3dnF5?= =?utf-8?B?OXBsZEYxK0hEUnR0RVV3cmFWR3pGSytLUFZNbEJvZjU4R0gxeHZWcGFWZnQ5?= =?utf-8?B?b3p6MTFQaU93V2cweFE2d2VaRHNDRGJCei9kMmx0Y25lR3Z0RDVxalpEa1Uw?= =?utf-8?B?WllUOHUzOGNlOE5wb1pQY3paTWJlRytZOGNzb29tTkdMWkNkVkpHMjNtUHQ3?= =?utf-8?B?aVlSMklsckJTWTF4Y3JBSWp5cmxLN2puSTVRWjUrV2JnZU5GQlI0SjdxWkVX?= =?utf-8?B?UmRqV1hSbTQxRkZsSDB5czB0N1hkK1FnZzErbkJPMFVuUmRyQk83RVczWVV2?= =?utf-8?B?Z0M2VC95R1pzRDdtTGFaSXBDc0FDc2VMZWlRckVyQkFhWjVlaURZcS9JZlRS?= =?utf-8?B?ZFVKNnZtNE55Vmp4NmRJM1p3WnNBTWVIL2hOajRDc3E0dlZWRHlDeWdYcnlp?= =?utf-8?B?R09oaVRCdUJNOUhWR1Z2d1FKOU1jQWRQNVVvVmplSlp5b3ZmMDZ5V1hLZjI1?= =?utf-8?B?Sk5XSEZKcFExUDFLaTJTZFpJM21CTEl5cVhTcmhlbGhNd0t3N0JHeVlsN1lL?= =?utf-8?B?d3FHU1pLUWR2OXpTakQvbTRXcHJqQzJicUZJZWNGQ1J5dnllVGxXMExMamgx?= =?utf-8?B?R2dUdTl1NzFSdFlYeUlzc3RIUFVpRDZqOVNPZkRSeTRBenVJRzNKK1ZhWGdo?= =?utf-8?B?VktvanA5WUh5MHcxRXFuMVZUTW1KNjVsNGV0RlFRcnBuUVkvTXQxVXBIeWN1?= =?utf-8?B?MjU5STVhMFZXdjZ0VTVBemlha2FNTTBPUGpranFtRmtyTGkzT1ZPZDZoUEdF?= =?utf-8?B?K3FTd3krNUtDNGdkTzNmbDhVa2ZzczU3NEpRUUQ0cDMxQmZHNjR4RFQ5NjdK?= =?utf-8?B?ZVZJelhUNVBQYkF5YkkvR1VGd0h4aHk0WVl4SEg4N0xnckhCcVM5S3ZRRzM0?= =?utf-8?B?WkF4ZmdnaFpRbXM1c09tZ0RFZHpMazBNQ2lVcHJTRGpyQ0hPNHZiZGFLV2tQ?= =?utf-8?B?UHQwQlRzMGVCc2NKdHNzTVkwcGFINjRhdVpxNHVmWmsrWHVsV0R3K1laQy9J?= =?utf-8?B?SStBUWxwdlNWMmRnMHUxK0t4NVZ2bURjNE5HMDBlVS9mcUxLbHBPS0RYdW1k?= =?utf-8?Q?7XDZsT13kT13Vel5nFsAn/FYm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 569cf5e0-5128-42d9-cf35-08db091a7ea9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 14:49:20.4101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1HwOr75NeOTUsh3PFZXfPN7J/z1KG+2s6/dHEkvB62u6Hrvi/HuVK0Uv2FjvAvQX X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6728 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/3/2023 7:14 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; instead of > having testpmd kill itself. This fixes the problem where a signal could > be received in the middle of a PMD and then the signal handler would > call PMD's close routine leading to locking problems. > > The cmdline structure no longer needs to be global it can > just be local to the prompt() function. > > An added benefit is it gets rid of some Windows specific code. > > Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") > Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit