From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E3A4A034F; Wed, 24 Feb 2021 13:18:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ED88160816; Wed, 24 Feb 2021 13:18:43 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5293A4069B; Wed, 24 Feb 2021 13:18:40 +0100 (CET) IronPort-SDR: Yv8WIJT4K2/hEi8YgN3k+Vrl38elF789THPQz7C/K7AOkTHuaHY+47YfC2F9okS03OgjRB43st QewAXOtuLxzA== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="182674672" X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="182674672" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 04:18:40 -0800 IronPort-SDR: M4VI49g588h2TT/k4veM8ZoFvPu6M327M2UVx4CRx/nmsCrX43Gvzr3WZ1tmOr8WlaF4uCza/r Alu96vUP9myg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="433487576" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 24 Feb 2021 04:18:38 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 04:18:37 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 20:18:35 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.002; Wed, 24 Feb 2021 20:18:35 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , "Yu, DapengX" , "Wang, Haiyue" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/e1000: remove MTU setting limitation Thread-Index: AQHXCl53k/sG8i/8HkG5vV9dWUOuFKpnOYGw Date: Wed, 24 Feb 2021 12:18:35 +0000 Message-ID: References: <20210219100323.102093-1-dapengx.yu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Guo, Jia > Sent: Wednesday, February 24, 2021 11:38 AM > To: Yu, DapengX ; Wang, Haiyue > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/e1000: remove MTU setting limitation >=20 > Seems that this is align with the fixing process of the other pmds(ixgbe/= txgbe) > and it is not bad. Thanks. >=20 > Acked-by: Jeff Guo >=20 > > -----Original Message----- > > From: Yu, DapengX > > Sent: Friday, February 19, 2021 6:03 PM > > To: Guo, Jia ; Wang, Haiyue > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > > Subject: [PATCH] net/e1000: remove MTU setting limitation > > > > From: Dapeng Yu > > > > Currently, if requested MTU is bigger than mbuf size and scattered > > receive is not enabled, setting MTU to that value fails. > > > > This patch allows setting this special MTU when device is stopped, > > because scattered_rx will be re-configured during next port start and > > driver may enable scattered receive according new MTU value. > > > > After this patch, driver may select different receive function > > automatically after MTU set, according MTU values selected. > > > > Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu Applied to dpdk-next-net-intel. Thanks Qi