DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files
@ 2018-07-08  5:24 Rasesh Mody
  2018-07-09 21:07 ` Thomas Monjalon
  2018-07-14  1:33 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
  0 siblings, 2 replies; 8+ messages in thread
From: Rasesh Mody @ 2018-07-08  5:24 UTC (permalink / raw)
  To: dev; +Cc: Rasesh Mody, hemant.agrawal, ferruh.yigit, thomas, Dept-EngDPDKDev

We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
directly include SPDX tags in source files.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/bnx2x/LICENSE.bnx2x_pmd |    3 ---
 drivers/net/bnx2x/Makefile          |    2 +-
 drivers/net/bnx2x/bnx2x.c           |    2 +-
 drivers/net/bnx2x/bnx2x.h           |    2 +-
 drivers/net/bnx2x/bnx2x_ethdev.c    |    2 +-
 drivers/net/bnx2x/bnx2x_ethdev.h    |    2 +-
 drivers/net/bnx2x/bnx2x_logs.h      |    2 +-
 drivers/net/bnx2x/bnx2x_rxtx.c      |    2 +-
 drivers/net/bnx2x/bnx2x_rxtx.h      |    2 +-
 drivers/net/bnx2x/bnx2x_stats.c     |    2 +-
 drivers/net/bnx2x/bnx2x_stats.h     |    2 +-
 drivers/net/bnx2x/bnx2x_vfpf.c      |    2 +-
 drivers/net/bnx2x/bnx2x_vfpf.h      |    2 +-
 drivers/net/bnx2x/ecore_fw_defs.h   |    2 +-
 drivers/net/bnx2x/ecore_hsi.h       |    2 +-
 drivers/net/bnx2x/ecore_init.h      |    2 +-
 drivers/net/bnx2x/ecore_init_ops.h  |    2 +-
 drivers/net/bnx2x/ecore_mfw_req.h   |    2 +-
 drivers/net/bnx2x/ecore_reg.h       |    2 +-
 drivers/net/bnx2x/ecore_sp.c        |    2 +-
 drivers/net/bnx2x/ecore_sp.h        |    2 +-
 drivers/net/bnx2x/elink.c           |    2 +-
 drivers/net/bnx2x/elink.h           |    2 +-
 23 files changed, 22 insertions(+), 25 deletions(-)
 delete mode 100644 drivers/net/bnx2x/LICENSE.bnx2x_pmd

diff --git a/drivers/net/bnx2x/LICENSE.bnx2x_pmd b/drivers/net/bnx2x/LICENSE.bnx2x_pmd
deleted file mode 100644
index 64c6ef2..0000000
--- a/drivers/net/bnx2x/LICENSE.bnx2x_pmd
+++ /dev/null
@@ -1,3 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2014-2018 Cavium Inc.
- */
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 150b4cf..f5221f8 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -2,7 +2,7 @@
 #    All rights reserved.
 #    www.cavium.com
 #
-#    See LICENSE.bnx2x_pmd for copyright and licensing details.
+#    SPDX-License-Identifier: BSD-3-Clause
 include $(RTE_SDK)/mk/rte.vars.mk
 
 #
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 84ade5f..24663f8 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #define BNX2X_DRIVER_VERSION "1.78.18"
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 4150fd8..adc69a2 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef __BNX2X_H__
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 6a9cd58..7636e73 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.h b/drivers/net/bnx2x/bnx2x_ethdev.h
index f05be7e..233d55d 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.h
+++ b/drivers/net/bnx2x/bnx2x_ethdev.h
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef PMD_BNX2X_ETHDEV_H
diff --git a/drivers/net/bnx2x/bnx2x_logs.h b/drivers/net/bnx2x/bnx2x_logs.h
index 69a2fe1..67ee348 100644
--- a/drivers/net/bnx2x/bnx2x_logs.h
+++ b/drivers/net/bnx2x/bnx2x_logs.h
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef _PMD_LOGS_H_
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 331884c..727a72a 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.h b/drivers/net/bnx2x/bnx2x_rxtx.h
index 94b9e1b..84979f1 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.h
+++ b/drivers/net/bnx2x/bnx2x_rxtx.h
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef _BNX2X_RXTX_H_
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index e3880ab..47d8a3e 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
index 6fcaf60..8729619 100644
--- a/drivers/net/bnx2x/bnx2x_stats.h
+++ b/drivers/net/bnx2x/bnx2x_stats.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef BNX2X_STATS_H
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c
index dacad77..dd5ba98 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/bnx2x/bnx2x_vfpf.c
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.h b/drivers/net/bnx2x/bnx2x_vfpf.h
index c4675d4..702afe3 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.h
+++ b/drivers/net/bnx2x/bnx2x_vfpf.h
@@ -5,7 +5,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef BNX2X_VFPF_H
diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h
index d10dd10..eace530 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -9,7 +9,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_FW_DEFS_H
diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h
index 0220e5f..94879c5 100644
--- a/drivers/net/bnx2x/ecore_hsi.h
+++ b/drivers/net/bnx2x/ecore_hsi.h
@@ -9,7 +9,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_HSI_H
diff --git a/drivers/net/bnx2x/ecore_init.h b/drivers/net/bnx2x/ecore_init.h
index 8d00abb..a17ca19 100644
--- a/drivers/net/bnx2x/ecore_init.h
+++ b/drivers/net/bnx2x/ecore_init.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_INIT_H
diff --git a/drivers/net/bnx2x/ecore_init_ops.h b/drivers/net/bnx2x/ecore_init_ops.h
index dd5df3d..a93e7b4 100644
--- a/drivers/net/bnx2x/ecore_init_ops.h
+++ b/drivers/net/bnx2x/ecore_init_ops.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_INIT_OPS_H
diff --git a/drivers/net/bnx2x/ecore_mfw_req.h b/drivers/net/bnx2x/ecore_mfw_req.h
index c798c74..6a20285 100644
--- a/drivers/net/bnx2x/ecore_mfw_req.h
+++ b/drivers/net/bnx2x/ecore_mfw_req.h
@@ -9,7 +9,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_MFW_REQ_H
diff --git a/drivers/net/bnx2x/ecore_reg.h b/drivers/net/bnx2x/ecore_reg.h
index 9800baf..6520897 100644
--- a/drivers/net/bnx2x/ecore_reg.h
+++ b/drivers/net/bnx2x/ecore_reg.h
@@ -9,7 +9,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_REG_H
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index 7532967..cd8d5ee 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 772c8b1..1fd0caf 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ECORE_SP_H
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 34a2937..0f312db 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/elink.h b/drivers/net/bnx2x/elink.h
index 236f936..2c716ff 100644
--- a/drivers/net/bnx2x/elink.h
+++ b/drivers/net/bnx2x/elink.h
@@ -10,7 +10,7 @@
  * All rights reserved.
  * www.cavium.com
  *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
 #ifndef ELINK_H
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files
  2018-07-08  5:24 [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files Rasesh Mody
@ 2018-07-09 21:07 ` Thomas Monjalon
  2018-07-10 15:57   ` Mody, Rasesh
  2018-07-14  1:33 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2018-07-09 21:07 UTC (permalink / raw)
  To: Rasesh Mody; +Cc: dev, hemant.agrawal, ferruh.yigit, Dept-EngDPDKDev

Hi,

08/07/2018 07:24, Rasesh Mody:
> We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
> tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
> directly include SPDX tags in source files.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> --- a/drivers/net/bnx2x/Makefile
> +++ b/drivers/net/bnx2x/Makefile
> @@ -2,7 +2,7 @@
>  #    All rights reserved.
>  #    www.cavium.com
>  #
> -#    See LICENSE.bnx2x_pmd for copyright and licensing details.
> +#    SPDX-License-Identifier: BSD-3-Clause

The SPDX line should be the first line.

You can take a look at doc/guides/contributing/patches.rst

Thanks

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files
  2018-07-09 21:07 ` Thomas Monjalon
@ 2018-07-10 15:57   ` Mody, Rasesh
  0 siblings, 0 replies; 8+ messages in thread
From: Mody, Rasesh @ 2018-07-10 15:57 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, hemant.agrawal, ferruh.yigit, Dept-Eng DPDK Dev

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, July 09, 2018 2:07 PM
> 
> Hi,
> 
> 08/07/2018 07:24, Rasesh Mody:
> > We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX
> > licensing tag from all the source file. Remove the LICENSE.bnx2x_pmd
> > file and directly include SPDX tags in source files.
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> > --- a/drivers/net/bnx2x/Makefile
> > +++ b/drivers/net/bnx2x/Makefile
> > @@ -2,7 +2,7 @@
> >  #    All rights reserved.
> >  #    www.cavium.com
> >  #
> > -#    See LICENSE.bnx2x_pmd for copyright and licensing details.
> > +#    SPDX-License-Identifier: BSD-3-Clause
> 
> The SPDX line should be the first line.

I will send a v2 with the change.

Thanks!
-Rasesh
> 
> You can take a look at doc/guides/contributing/patches.rst
> 
> Thanks
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files
  2018-07-08  5:24 [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files Rasesh Mody
  2018-07-09 21:07 ` Thomas Monjalon
@ 2018-07-14  1:33 ` Rasesh Mody
  2018-07-16  6:29   ` Hemant
  2018-07-27 15:47   ` [dpdk-dev] [PATCH v3] " Rasesh Mody
  1 sibling, 2 replies; 8+ messages in thread
From: Rasesh Mody @ 2018-07-14  1:33 UTC (permalink / raw)
  To: dev; +Cc: Rasesh Mody, hemant.agrawal, ferruh.yigit, thomas, Dept-EngDPDKDev

We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
directly include SPDX tags in source files.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/bnx2x/LICENSE.bnx2x_pmd |    3 ---
 drivers/net/bnx2x/Makefile          |    9 ++++-----
 drivers/net/bnx2x/bnx2x.c           |    4 +---
 drivers/net/bnx2x/bnx2x.h           |    4 +---
 drivers/net/bnx2x/bnx2x_ethdev.c    |    4 +---
 drivers/net/bnx2x/bnx2x_ethdev.h    |    4 +---
 drivers/net/bnx2x/bnx2x_logs.h      |    4 +---
 drivers/net/bnx2x/bnx2x_rxtx.c      |    4 +---
 drivers/net/bnx2x/bnx2x_rxtx.h      |    4 +---
 drivers/net/bnx2x/bnx2x_stats.c     |    4 +---
 drivers/net/bnx2x/bnx2x_stats.h     |    4 +---
 drivers/net/bnx2x/bnx2x_vfpf.c      |    4 +---
 drivers/net/bnx2x/bnx2x_vfpf.h      |    4 +---
 drivers/net/bnx2x/ecore_fw_defs.h   |    4 +---
 drivers/net/bnx2x/ecore_hsi.h       |    4 +---
 drivers/net/bnx2x/ecore_init.h      |    4 +---
 drivers/net/bnx2x/ecore_init_ops.h  |    4 +---
 drivers/net/bnx2x/ecore_mfw_req.h   |    4 +---
 drivers/net/bnx2x/ecore_reg.h       |    4 +---
 drivers/net/bnx2x/ecore_sp.c        |    4 +---
 drivers/net/bnx2x/ecore_sp.h        |    4 +---
 drivers/net/bnx2x/elink.c           |    4 +---
 drivers/net/bnx2x/elink.h           |    4 +---
 23 files changed, 25 insertions(+), 71 deletions(-)
 delete mode 100644 drivers/net/bnx2x/LICENSE.bnx2x_pmd

diff --git a/drivers/net/bnx2x/LICENSE.bnx2x_pmd b/drivers/net/bnx2x/LICENSE.bnx2x_pmd
deleted file mode 100644
index 64c6ef2..0000000
--- a/drivers/net/bnx2x/LICENSE.bnx2x_pmd
+++ /dev/null
@@ -1,3 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2014-2018 Cavium Inc.
- */
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 150b4cf..55d1ad6 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -1,8 +1,7 @@
-#    Copyright (c) 2014 - 2018 Cavium Inc.
-#    All rights reserved.
-#    www.cavium.com
-#
-#    See LICENSE.bnx2x_pmd for copyright and licensing details.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2014 - 2018 Cavium Inc.
+# All rights reserved.
+# www.cavium.com
 include $(RTE_SDK)/mk/rte.vars.mk
 
 #
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 84ade5f..317578c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #define BNX2X_DRIVER_VERSION "1.78.18"
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 4150fd8..34a5d65 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef __BNX2X_H__
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 3a554b8..922c454 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.h b/drivers/net/bnx2x/bnx2x_ethdev.h
index f05be7e..6208ac7 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.h
+++ b/drivers/net/bnx2x/bnx2x_ethdev.h
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef PMD_BNX2X_ETHDEV_H
diff --git a/drivers/net/bnx2x/bnx2x_logs.h b/drivers/net/bnx2x/bnx2x_logs.h
index 69a2fe1..5e53580 100644
--- a/drivers/net/bnx2x/bnx2x_logs.h
+++ b/drivers/net/bnx2x/bnx2x_logs.h
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef _PMD_LOGS_H_
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 331884c..e4460ed 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.h b/drivers/net/bnx2x/bnx2x_rxtx.h
index 94b9e1b..d1b3bac 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.h
+++ b/drivers/net/bnx2x/bnx2x_rxtx.h
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef _BNX2X_RXTX_H_
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index e3880ab..d9ba437 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
index 6fcaf60..107ef20 100644
--- a/drivers/net/bnx2x/bnx2x_stats.h
+++ b/drivers/net/bnx2x/bnx2x_stats.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef BNX2X_STATS_H
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c
index dacad77..8610ec7 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/bnx2x/bnx2x_vfpf.c
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.h b/drivers/net/bnx2x/bnx2x_vfpf.h
index c4675d4..90003d1 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.h
+++ b/drivers/net/bnx2x/bnx2x_vfpf.h
@@ -1,11 +1,9 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
  *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef BNX2X_VFPF_H
diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h
index d10dd10..1364813 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_FW_DEFS_H
diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h
index 0220e5f..712bafb 100644
--- a/drivers/net/bnx2x/ecore_hsi.h
+++ b/drivers/net/bnx2x/ecore_hsi.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_HSI_H
diff --git a/drivers/net/bnx2x/ecore_init.h b/drivers/net/bnx2x/ecore_init.h
index 8d00abb..530f42d 100644
--- a/drivers/net/bnx2x/ecore_init.h
+++ b/drivers/net/bnx2x/ecore_init.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_INIT_H
diff --git a/drivers/net/bnx2x/ecore_init_ops.h b/drivers/net/bnx2x/ecore_init_ops.h
index dd5df3d..9664e6b 100644
--- a/drivers/net/bnx2x/ecore_init_ops.h
+++ b/drivers/net/bnx2x/ecore_init_ops.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_INIT_OPS_H
diff --git a/drivers/net/bnx2x/ecore_mfw_req.h b/drivers/net/bnx2x/ecore_mfw_req.h
index c798c74..2f3e212 100644
--- a/drivers/net/bnx2x/ecore_mfw_req.h
+++ b/drivers/net/bnx2x/ecore_mfw_req.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_MFW_REQ_H
diff --git a/drivers/net/bnx2x/ecore_reg.h b/drivers/net/bnx2x/ecore_reg.h
index 9800baf..3914ce0 100644
--- a/drivers/net/bnx2x/ecore_reg.h
+++ b/drivers/net/bnx2x/ecore_reg.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_REG_H
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index 7532967..fb3e47d 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 772c8b1..4ce2c74 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_SP_H
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 34a2937..5972d74 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -1,4 +1,4 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/elink.h b/drivers/net/bnx2x/elink.h
index 236f936..7861aa2 100644
--- a/drivers/net/bnx2x/elink.h
+++ b/drivers/net/bnx2x/elink.h
@@ -1,4 +1,4 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ELINK_H
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files
  2018-07-14  1:33 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
@ 2018-07-16  6:29   ` Hemant
  2018-07-16 20:05     ` Mody, Rasesh
  2018-07-27 15:47   ` [dpdk-dev] [PATCH v3] " Rasesh Mody
  1 sibling, 1 reply; 8+ messages in thread
From: Hemant @ 2018-07-16  6:29 UTC (permalink / raw)
  To: Rasesh Mody, dev; +Cc: ferruh.yigit, thomas

Hi Rasesh

On 7/14/2018 7:03 AM, Rasesh Mody wrote:
> diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
> index 6fcaf60..107ef20 100644
> --- a/drivers/net/bnx2x/bnx2x_stats.h
> +++ b/drivers/net/bnx2x/bnx2x_stats.h
> @@ -1,4 +1,4 @@
> -/*-
> +/* SPDX-License-Identifier: BSD-3-Clause
>    * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
>    *
>    * Eric Davis        <edavis@broadcom.com>
> @@ -9,8 +9,6 @@
>    * Copyright (c) 2015-2018 Cavium Inc.
>    * All rights reserved.
>    * www.cavium.com
> - *
> - * See LICENSE.bnx2x_pmd for copyright and licensing details.
>    */
>   
>
I see that some of the files have the Cavium copyright two times (like 
above).  you may want to clean it in future patch.


  Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files
  2018-07-16  6:29   ` Hemant
@ 2018-07-16 20:05     ` Mody, Rasesh
  0 siblings, 0 replies; 8+ messages in thread
From: Mody, Rasesh @ 2018-07-16 20:05 UTC (permalink / raw)
  To: Hemant, dev; +Cc: ferruh.yigit, thomas

Hi Hemant,
> From: Hemant [mailto:hemant.agrawal@nxp.com]
> Sent: Sunday, July 15, 2018 11:30 PM
> 
> Hi Rasesh
> 
> On 7/14/2018 7:03 AM, Rasesh Mody wrote:
> > diff --git a/drivers/net/bnx2x/bnx2x_stats.h
> > b/drivers/net/bnx2x/bnx2x_stats.h index 6fcaf60..107ef20 100644
> > --- a/drivers/net/bnx2x/bnx2x_stats.h
> > +++ b/drivers/net/bnx2x/bnx2x_stats.h
> > @@ -1,4 +1,4 @@
> > -/*-
> > +/* SPDX-License-Identifier: BSD-3-Clause
> >    * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
> >    *
> >    * Eric Davis        <edavis@broadcom.com>
> > @@ -9,8 +9,6 @@
> >    * Copyright (c) 2015-2018 Cavium Inc.
> >    * All rights reserved.
> >    * www.cavium.com
> > - *
> > - * See LICENSE.bnx2x_pmd for copyright and licensing details.
> >    */
> >
> >
> I see that some of the files have the Cavium copyright two times (like above).
> you may want to clean it in future patch.

We'll clean it up.

Thanks!
-Rasesh
 
> 
> 
>   Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v3] net/bnx2x: move SPDX tags to source files
  2018-07-14  1:33 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
  2018-07-16  6:29   ` Hemant
@ 2018-07-27 15:47   ` Rasesh Mody
  2018-08-03 14:48     ` Thomas Monjalon
  1 sibling, 1 reply; 8+ messages in thread
From: Rasesh Mody @ 2018-07-27 15:47 UTC (permalink / raw)
  To: dev; +Cc: Rasesh Mody, hemant.agrawal, ferruh.yigit, thomas, Dept-EngDPDKDev

We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
directly include SPDX tags in source files.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/net/bnx2x/LICENSE.bnx2x_pmd |    3 ---
 drivers/net/bnx2x/Makefile          |    9 ++++-----
 drivers/net/bnx2x/bnx2x.c           |    4 +---
 drivers/net/bnx2x/bnx2x.h           |    4 +---
 drivers/net/bnx2x/bnx2x_ethdev.c    |    5 +----
 drivers/net/bnx2x/bnx2x_ethdev.h    |    5 +----
 drivers/net/bnx2x/bnx2x_logs.h      |    5 +----
 drivers/net/bnx2x/bnx2x_rxtx.c      |    5 +----
 drivers/net/bnx2x/bnx2x_rxtx.h      |    5 +----
 drivers/net/bnx2x/bnx2x_stats.c     |    4 +---
 drivers/net/bnx2x/bnx2x_stats.h     |    4 +---
 drivers/net/bnx2x/bnx2x_vfpf.c      |    5 +----
 drivers/net/bnx2x/bnx2x_vfpf.h      |    5 +----
 drivers/net/bnx2x/ecore_fw_defs.h   |    4 +---
 drivers/net/bnx2x/ecore_hsi.h       |    4 +---
 drivers/net/bnx2x/ecore_init.h      |    4 +---
 drivers/net/bnx2x/ecore_init_ops.h  |    4 +---
 drivers/net/bnx2x/ecore_mfw_req.h   |    4 +---
 drivers/net/bnx2x/ecore_reg.h       |    4 +---
 drivers/net/bnx2x/ecore_sp.c        |    4 +---
 drivers/net/bnx2x/ecore_sp.h        |    4 +---
 drivers/net/bnx2x/elink.c           |    4 +---
 drivers/net/bnx2x/elink.h           |    4 +---
 23 files changed, 25 insertions(+), 78 deletions(-)
 delete mode 100644 drivers/net/bnx2x/LICENSE.bnx2x_pmd

diff --git a/drivers/net/bnx2x/LICENSE.bnx2x_pmd b/drivers/net/bnx2x/LICENSE.bnx2x_pmd
deleted file mode 100644
index 64c6ef2..0000000
--- a/drivers/net/bnx2x/LICENSE.bnx2x_pmd
+++ /dev/null
@@ -1,3 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2014-2018 Cavium Inc.
- */
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 150b4cf..55d1ad6 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -1,8 +1,7 @@
-#    Copyright (c) 2014 - 2018 Cavium Inc.
-#    All rights reserved.
-#    www.cavium.com
-#
-#    See LICENSE.bnx2x_pmd for copyright and licensing details.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2014 - 2018 Cavium Inc.
+# All rights reserved.
+# www.cavium.com
 include $(RTE_SDK)/mk/rte.vars.mk
 
 #
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 84ade5f..317578c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #define BNX2X_DRIVER_VERSION "1.78.18"
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 4150fd8..34a5d65 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef __BNX2X_H__
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 3a554b8..0949330 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.h b/drivers/net/bnx2x/bnx2x_ethdev.h
index f05be7e..3178245 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.h
+++ b/drivers/net/bnx2x/bnx2x_ethdev.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef PMD_BNX2X_ETHDEV_H
diff --git a/drivers/net/bnx2x/bnx2x_logs.h b/drivers/net/bnx2x/bnx2x_logs.h
index 69a2fe1..9e232a9 100644
--- a/drivers/net/bnx2x/bnx2x_logs.h
+++ b/drivers/net/bnx2x/bnx2x_logs.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef _PMD_LOGS_H_
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 331884c..d9a4127 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.h b/drivers/net/bnx2x/bnx2x_rxtx.h
index 94b9e1b..6ad4928 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.h
+++ b/drivers/net/bnx2x/bnx2x_rxtx.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef _BNX2X_RXTX_H_
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index b67a711..edc86cc 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
index 0ffd308..635412b 100644
--- a/drivers/net/bnx2x/bnx2x_stats.h
+++ b/drivers/net/bnx2x/bnx2x_stats.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef BNX2X_STATS_H
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c
index dacad77..50099d4 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/bnx2x/bnx2x_vfpf.c
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.h b/drivers/net/bnx2x/bnx2x_vfpf.h
index c4675d4..cc6fef9 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.h
+++ b/drivers/net/bnx2x/bnx2x_vfpf.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef BNX2X_VFPF_H
diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h
index 544ec23..5984acd 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_FW_DEFS_H
diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h
index c9c5ba7..57085eb 100644
--- a/drivers/net/bnx2x/ecore_hsi.h
+++ b/drivers/net/bnx2x/ecore_hsi.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_HSI_H
diff --git a/drivers/net/bnx2x/ecore_init.h b/drivers/net/bnx2x/ecore_init.h
index dcf409d..f2de07e 100644
--- a/drivers/net/bnx2x/ecore_init.h
+++ b/drivers/net/bnx2x/ecore_init.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_INIT_H
diff --git a/drivers/net/bnx2x/ecore_init_ops.h b/drivers/net/bnx2x/ecore_init_ops.h
index 5cc6730..2b003af 100644
--- a/drivers/net/bnx2x/ecore_init_ops.h
+++ b/drivers/net/bnx2x/ecore_init_ops.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_INIT_OPS_H
diff --git a/drivers/net/bnx2x/ecore_mfw_req.h b/drivers/net/bnx2x/ecore_mfw_req.h
index fe7fe0e..fe94504 100644
--- a/drivers/net/bnx2x/ecore_mfw_req.h
+++ b/drivers/net/bnx2x/ecore_mfw_req.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_MFW_REQ_H
diff --git a/drivers/net/bnx2x/ecore_reg.h b/drivers/net/bnx2x/ecore_reg.h
index 87a98b5..ae8a93b 100644
--- a/drivers/net/bnx2x/ecore_reg.h
+++ b/drivers/net/bnx2x/ecore_reg.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -8,8 +8,6 @@
  * Copyright (c) 2014-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_REG_H
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index b790400..0c8685c 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index d0d4082..6b65a49 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ECORE_SP_H
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index f7e097a..b63fd23 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -1,4 +1,4 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/elink.h b/drivers/net/bnx2x/elink.h
index 7556797..40000c2 100644
--- a/drivers/net/bnx2x/elink.h
+++ b/drivers/net/bnx2x/elink.h
@@ -1,4 +1,4 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis        <edavis@broadcom.com>
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef ELINK_H
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v3] net/bnx2x: move SPDX tags to source files
  2018-07-27 15:47   ` [dpdk-dev] [PATCH v3] " Rasesh Mody
@ 2018-08-03 14:48     ` Thomas Monjalon
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2018-08-03 14:48 UTC (permalink / raw)
  To: Rasesh Mody; +Cc: dev, hemant.agrawal, ferruh.yigit, Dept-EngDPDKDev

27/07/2018 17:47, Rasesh Mody:
> We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
> tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
> directly include SPDX tags in source files.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-08-03 14:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-08  5:24 [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files Rasesh Mody
2018-07-09 21:07 ` Thomas Monjalon
2018-07-10 15:57   ` Mody, Rasesh
2018-07-14  1:33 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
2018-07-16  6:29   ` Hemant
2018-07-16 20:05     ` Mody, Rasesh
2018-07-27 15:47   ` [dpdk-dev] [PATCH v3] " Rasesh Mody
2018-08-03 14:48     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).