From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0067.outbound.protection.outlook.com [104.47.36.67]) by dpdk.org (Postfix) with ESMTP id 3C334276C for ; Wed, 27 Sep 2017 11:20:06 +0200 (CEST) Received: from BN6PR03CA0008.namprd03.prod.outlook.com (10.168.230.146) by CY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 27 Sep 2017 09:20:04 +0000 Received: from BL2FFO11FD008.protection.gbl (2a01:111:f400:7c09::176) by BN6PR03CA0008.outlook.office365.com (2603:10b6:404:23::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Wed, 27 Sep 2017 09:20:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD008.mail.protection.outlook.com (10.173.161.4) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Wed, 27 Sep 2017 09:20:03 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8R9K1HK019064; Wed, 27 Sep 2017 02:20:02 -0700 To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-3-shreyansh.jain@nxp.com> <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> <7cf232e2-000a-85f4-2628-2945e1e7ddb1@nxp.com> From: Shreyansh Jain Message-ID: Date: Wed, 27 Sep 2017 15:00:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131509776043090279; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(376002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(377454003)(199003)(24454002)(189002)(5660300001)(68736007)(77096006)(229853002)(316002)(189998001)(97736004)(8656003)(104016004)(58126008)(6666003)(53936002)(83506001)(50466002)(6246003)(36756003)(85426001)(65826007)(4326008)(8676002)(54906003)(81166006)(81156014)(64126003)(8936002)(65806001)(65956001)(23676002)(86362001)(31696002)(105606002)(50986999)(76176999)(33646002)(31686004)(54356999)(356003)(2870700001)(305945005)(2906002)(106466001)(93886005)(498600001)(53546010)(6916009)(2950100002)(47776003)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD008; 1:ip+plczPjIJjltFzumVMDxlwWCI8nztAP2+vCITNtn9s4lqOxcMggPjQICM3NoHKsbogPVID4kYtJ6weZCMtEmyhQXnvpB0zkQp9U7JEeXXa5PfrZ6v/Caxg3A0tHl7F X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83d08c53-9da6-4729-b4fe-08d50588efeb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2362; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 3:vFI5r5RCtnEWJv2Vi5aNvKCQ6gEoSHoNoCkS0xPjdSfw16F4DkAOrf5qpzZM1Cmih5XvmO3bdTARgFmE4szsSZPGNIEYQytIeYm4JV2CIgqSc13Oc6WAPEpY1D9OGQUvlfHnw3H7xUl417uBN73u4G/UpyBV0qZfN09d8Tc9s41eTJso1OiUGfrVAXqCjdSQ4CnvbkR7ujSXmlh5tyDBU4UwqQ4MhttPpf5X8urGQRv39xYB7qxNsj3QCjyAjq9NumwTEu7HHLw1jXNejvUUOirbyFkGSz7VGVwd+Bwv7flBOaDjhpI8Oxzl+VpecXeJwQkpFaJFC9l4wEgFARq0MEIXxncaCaLJa2H15EIWb6g=; 25:gM9S+Cp6FEQU8d5YnpvuYdl/War/IQ5ENOt7p9RfdlZopIDFSHBeXXklmoXjmlbs93W3bQ/Z0I93qn6gR9S7+9lLxN/yIeDRZN3UHLxiaxyJQF3HH1CzJNmmhC4pc09Tju/gKMw3TuJM/6cWJWlmhpumQI96zMiQZXpcd0H9x8TZrALZ5q7BoyD5BbVDHDndRMyiHre/iuhgTOJ25mI9iBHNUIvWZATtkOdwA11dp4GpCqkR5yuVhAwpuJ9WzoEy9u0YDUHjDTQgWVaS1O8rBYEB6PmeWiYuptMyZe5KVjlQtUOsgW65CVRsLa3QpXH9PIwVN4FiCk1ks+vbnAxfyw== X-MS-TrafficTypeDiagnostic: CY1PR03MB2362: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 31:rwBCz1aadHKEsHbZlMabicjMQzFyfzHolJBhILwriCXbZSjwzznC8IoLVJlsbHFBw6WTw7k1bfaUbaK8golN7WtSSXh9VEjkH3zrOesoLE7WEvUpbNlXNTmQWfp3XXMeEzr6x5RB2kQefcNnz/n9GjzQAE9L1OSjj94yE8n84Cc1G4rfjJNhYYfORsQsdR6YcqQUzBp/GJsFnj4Qup/PMJviqAEsU1EsXwDLeo+Hcbo=; 4:fsGrScCYUUK6e85uRHWOrCDMZOPVLnP7TXkG1qpRtPOuW3KkynZbDrzVx59JUbs8GF2eFev4wAhlK9fUATKb8YEVAqgXtQnVWVInabd6SRqHHwtRlN6hL2zQA1lpULFAEd8M7xyTyrBxiqiEeakZLfgqO5h4vodWEk4UnS4OcLE2xdFhSv8UgyGPye44tgUam/VFLaJJDfGCOisg50J4F+qkV0tKfNytbDOSUXc8OUI/6NCKUWQtOu9UK01vJiUFwdMltuOCrKSNnzRMXWrc8+YFyjNJc/oSd87BLwih5so= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123556025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123559100)(20161123563025)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2362; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2362; X-Forefront-PRVS: 04433051BF X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYyOzIzOmp5N1N2UFRRUDhraCtvc1FxeWFkU2p3QmJW?= =?utf-8?B?QVYzYVAxL3Q0SEdEWEtscFVFY1FKVUdwelZ3b3R0b3FSUW9FV3NRemcwY0hp?= =?utf-8?B?bVhrejdFaThvWGc5MzlleU4wbXFWdnppNUZ1M1hwN21EQnlYazc3UFZ0cVFm?= =?utf-8?B?OVd1bS9YSHpaYWwxYnRRamxLVGlVVGNYZDlZalN0Y1p1VExPUUdCV1piZFVt?= =?utf-8?B?R1ZyWWs4RFI5YnJ0OXlvZFFXK0EwOTRNQXN2YUc3L2xjVnk4WUVvV251eitv?= =?utf-8?B?K3g3WGpPc2xzaDMwWWNkMldRcTV6ZUNodzMzK1pBbnJDQjNwTmFhSWF5MHVy?= =?utf-8?B?azdkWHZkY3ZmR09YZFZ5cW5LbFJaeG5FSlBBM294a2JCK0hPL3hkdzhvVTV0?= =?utf-8?B?RHZtVHI4SEd5eWRENXdIWkRHSjNYTTNwc3EwK0dHNG03RnFTYlU3d2diZ0tD?= =?utf-8?B?VkI5T3BIcWFPLzAvd3VVZGFmV2RucU9SdHFoN2tqQzdxZFRjOWoxSWRPcHhz?= =?utf-8?B?UUwyM3pQb3lub1hVdkU2Q05DV3RYZ1kvQys0RGlSUUtiVm5DL2tHWnIzMUtB?= =?utf-8?B?T0M5VW9CQnl6UUtrWVpZaWtkV0RaT2kvbS9JSEIwdmlvU3FJOWlmbVVsZm5h?= =?utf-8?B?N0plcEt3dG1OKzZlT2pwQXhITEc4bitza1NLSkx6NldiRzVrUDdJdGdFaWll?= =?utf-8?B?OFR0bld1S3gyR3pSQlZ5ZlVBcHZNQjVOcmZtL05PMkJtTFBrdCttTzFYS2lW?= =?utf-8?B?SGdCOUJ3NEZlVEpPWmdGNGpGc0hOYUNRQytBUlBUTmFKTml2Z2NDYzl4RmNj?= =?utf-8?B?Qk9LVkROaVVUd1pZM3RFbGxOanlhb2F1WjFab1paMlZ0RGRMWFN1MVJ5RitC?= =?utf-8?B?ZEdWNWltdGFzY1dWK3NMcllONEpodTA4bnV4L0ZLMUh4NG1ra2hHM2xMMk12?= =?utf-8?B?dEQ5MjJndExwTm1EckpLN3ZnSW1vN2hZbGxtV0tsZkZBM2d2L0Y2NVorVkh6?= =?utf-8?B?bHd4MmlqdTRPTEkxYlJDVTV0WFh0dEZRTGlqNlhwaVo3dmhoRFRGQlBuVDho?= =?utf-8?B?MUFPMzAreE5SLytIZ1ducCsxQmtSemdVeTV6WTBTL3V2QmFyK0xPem83NjNn?= =?utf-8?B?Mk5ibGVoMU5CM21zeGV2Q1pvMDhuYlRVYTVORThjUXBJQ0p0ODVjOGh1NmJD?= =?utf-8?B?UVVvSW1qTTh2Zm1PQVVoNXJ3bkZOYXVwYzU1ZXB4Rm8vcHU5SUI4ekZZT3lZ?= =?utf-8?B?ZHF6UU1HQXNnL2pUaVRQY1JrZGNwTklaY1J3SUpLM2w2RTc5QzNrZGJZOXl2?= =?utf-8?B?U0t3dWhiNUN3U1BES2tXVnZuZXNSTlUvaElxYzlaUTJ4YWdiaXZDU1ovSjdF?= =?utf-8?B?TmhjeUU2bTB5bUo0WmQvUnhOZWVUS3hYRCtlV3hUVXBPTmNQRjlDYU1PVXpy?= =?utf-8?B?R0NnNWFzWnBLNXNxR1hQbHRZZE5FVmFhTXh3M1RUQ3FVZ1pldHo2M1E0ZGwz?= =?utf-8?B?aTcyVG92MDlPZERTaUNwOHRUWkU5NlJMZTdOLzlKK29pTmR6cHMxL0FTcWgy?= =?utf-8?B?T3IrT2RZa0Z1WHA3THl5emVzUXRXSEZiNWV3d0ZNeklRWUx2bVQrTlBvWDE0?= =?utf-8?B?TisySm95WjdzY2pqc1hqa3ozbWJmL1p1REpxcVcyNGYyakJ0eS9keW1xbndP?= =?utf-8?B?cFNZaWZ3NWliT0JwZnRkbUJqQnkwbEp3SnVWeXFiWm45Ri9iVitYTzlCMWts?= =?utf-8?B?S0tZVzZiblpSOWx0eldIMGFHa0pnMGgyTkJRY2NZWUxrS040REg1YVRQa3FE?= =?utf-8?B?ZnJqVG9GaGJMbzd0VEhlNnd1ZGRQRnZidUtBQTRvdFh1VEJyeGJaZjh6a0V1?= =?utf-8?B?SjQra0s2ZktSNmNBU2J4cXFNd3VhaWxwTmpKc0p1ZVBDSnBjL0RmQ0pTcTJa?= =?utf-8?B?QTBPai9qWkpsckxOM3hEek0xZDZuZ2VNa09wSjZGRXJPNmNPUXZTVU5GdElr?= =?utf-8?B?RTRMRk42YTNtWEZ5RXp2VElpSjhmejd5eWlFdz09?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 6:VxoEz02e/M/xpLwupyF14CeyAlYtL7Znf/baOHjwIGMabj+bPI5trnMwE6N2SyrIsEKSelfG8DpPjiRT1CGnzbrsxgqzhGqAo6L7KE2UfoHDeVZh8AagJHXazZ8fvklFFoYv2az0Y4x1Q910zhxBow1LsMLNckRoaQM00cndk5Zx+KWSaskGcQPgGniCRLqSzELA/SPRE6tFIieJRv8cDDDin+cStUOhv2PQJTcriqBD1+V6WVB3nCm1i6+Z1wFW27BQzfSFTUIhDyRN1YwrOau8wl1GsNdP3avFseyPQYe17kD8E9Y4WV45H8wYqlUw2ff7gyDPy1wqVLYItALnDA==; 5:rFJH4wVTudMZROJs6XrvT2kQArv+VdktZrlfCM93CEZMcXSaJc2IeNEzBdrpTKR1u1nOQWfsSwbC5juq7i5nPH46QbOGgif4Pa+GdcAZ+7fYW7gphkVCukNxImhU1dIdVLkYbBZ/0NGNH/b/W9DKUg==; 24:Mem4//FoNpZcru3cZH6V4uIDusiKdUO8KUAly+IffeiDdeSQ0q1WsF2nsT7UVIn3IIC2ujCa88g+5PNaXUQe5BUS0ZRQNVuO20c/rHDOUuQ=; 7:XDVtTI7RM4De4ay7YKNBU62I78tCv9pqugOPevk5u17oj2rTZTGbrFAbS+MisyVzlDeThSOV11JxB4zQOBS7f84DcaaO635J1/HhwX+TQQ5V4nlNuxpAsEPGYam7wfOWUQqjZplTxGjc8u7b5NCuSSG3PHjKJ9tesCTyOossVEqB3OSGpmL575sdnqNksQ1SvoA4EB/B7REl8gzzcOhLNekXxX+oG6bDUJxWgIOLbV8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2017 09:20:03.9814 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2362 Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 09:20:06 -0000 On Monday 25 September 2017 08:41 PM, Ferruh Yigit wrote: > On 9/25/2017 3:32 PM, Shreyansh Jain wrote: >> On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote: >>> Hello Ferruh, >>> >>> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>>> Signed-off-by: Shreyansh Jain >>>>> Signed-off-by: Hemant Agrawal >>>> >>>> <...> >>>> >>>>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> new file mode 100644 >>>>> index 0000000..d97a009 >>>>> --- /dev/null >>>>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> @@ -0,0 +1,7 @@ >>>>> +DPDK_17.11 { >>>>> +    global: >>>>> + >>>>> +    rte_dpaa_driver_register; >>>>> +    rte_dpaa_driver_unregister; >>>> >>>> "local *;" ? >>> >>> Agree. I will change this. >>> Currently rte_dpaa_driver_* functions are being used locally within >>> bus/dpaa. >>> >> >> Even though I agree earlier that I will change this (append 'local *:' >> to the file), probably I will have to skip this. >> Further in the patch series, there are some symbols which are added >> which are required by the mempool and net drivers (and crypto, in >> future). Shared compilation fails for them if I add 'local: *;' here. > > It should be OK if this is last item in the first group. > > Technically I believe it will be OK to remove that line, but not quite sure. > > Lets be consistent with exiting usage and keep it, there are many sample > map files. > I had a look at the various map files in code. There is a mixed usage. Most don't have 'local' tag in their last blocks which exposes symbols. Some, like octeonx, bnxt have both. I am not very sure of how this changes the scope of variables. So, as of now I have made DPAA to have both - global and local in its 17.11 symbol block.