DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
	Tudor Cornea <tudor.cornea@gmail.com>
Cc: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails
Date: Thu, 21 Oct 2021 02:54:38 +0000	[thread overview]
Message-ID: <a8222130dfcb44e584869f734ca49ffb@intel.com> (raw)
In-Reply-To: <DM4PR11MB5518FD72F0C64E625F7CAEF7F7BF9@DM4PR11MB5518.namprd11.prod.outlook.com>



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, October 21, 2021 9:14 AM
> To: Tudor Cornea <tudor.cornea@gmail.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Zhang, AlvinX <alvinx.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v2] net/ixgbe: initialize port even if mtu config fails
> 
> > -----Original Message-----
> > From: Tudor Cornea <tudor.cornea@gmail.com>
> > Sent: Thursday, October 21, 2021 02:14
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, AlvinX
> > <alvinx.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > dev@dpdk.org; Tudor Cornea <tudor.cornea@gmail.com>
> > Subject: [PATCH v2] net/ixgbe: initialize port even if mtu config
> > fails
> >
> > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't
> > seem to initialize anymore, while running testpmd.
> >
> > Configuring Port 0 (socket 0)
> > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed.
> > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to
> > start port 0: Invalid argument Configuring Port 1 (socket 0)
> > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed.
> > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) Fail to
> > start port 1: Invalid argument Please stop the ports first
> >
> > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely,
> > we will not be able to initialize the ports correctly.
> >
> > The behavior seems to have changed since the following commit:
> >
> > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set")
> >
> > We can make this particular use case work correctly if we don't return
> > an error, which seems to be consistent with the overall kernel ixgbevf
> > implementation.
> >
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre
> > e/drivers/net/ethernet/intel/ixg
> > bevf/ixgbevf_main.c#n2015
> >
> > Signed-off-by: Tudor Cornea <tudor.cornea@gmail.com>
> >
> > ---
> > v2:
> > * Change title
> > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c
> >   It's already fixed as part of Ferruh's changes in next-net branch,
> >   so this part should be redundant, now
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> 
> Thanks!
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> > --
> > 2.7.4
> 


  reply	other threads:[~2021-10-21  2:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 14:06 [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if rlpml_set_vf fails Tudor Cornea
2021-10-15 14:20 ` Tudor Cornea
2021-10-19 12:58   ` Ferruh Yigit
2021-10-20  3:08     ` Zhang, AlvinX
2021-10-20  7:13       ` Tudor Cornea
2021-10-20  7:29         ` Wang, Haiyue
2021-10-20 18:13 ` [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails Tudor Cornea
2021-10-21  1:14   ` Wang, Haiyue
2021-10-21  2:54     ` Zhang, Qi Z [this message]
2021-10-21 15:33   ` Ferruh Yigit
2021-10-21 16:40     ` Tudor Cornea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8222130dfcb44e584869f734ca49ffb@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=tudor.cornea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).