DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ziyang Xuan <xuanziyang2@huawei.com>, dev@dpdk.org
Cc: cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com,
	rami.rosen@huawei.com, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 01/11] Add HW registers
Date: Mon, 20 May 2019 12:35:12 +0100	[thread overview]
Message-ID: <a823afb1-e86c-58e3-0a42-ce20b1aafea4@intel.com> (raw)
In-Reply-To: <1558341095-26467-1-git-send-email-xuanziyang2@huawei.com>

On 5/20/2019 9:31 AM, Ziyang Xuan wrote:
> ---
>  drivers/net/hinic/base/hinic_csr.h | 172 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 172 insertions(+)
>  create mode 100644 drivers/net/hinic/base/hinic_csr.h

Hi Xuan,

Your mails are not reached to the mail list because of "Post by non-member to a
members-only list", technically we can release those mails but I prefer not to
do, because it can be better to fix a few things and try again:

1- It is better to register to the mail list, we will have many iterations after
this point and it is good to clarify that communication is not blocked.

2- Mail is not threaded, each patch sent as individual patch, this makes it hard
to follow. Can you please use following git send-email options while sending the
patches:
sendemail.smtpserver=smtp.intel.com
sendemail.chainreplyto=false

3- Patches are missing sign-off, can you please add them before sending?
And this may mean './devtools/checkpatches.sh' & './devtools/check-git-log.sh'
scripts not run before sending the patches, can you please verify they pass
before sending the patches?

Thanks,
ferruh

           reply	other threads:[~2019-05-20 11:35 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1558341095-26467-1-git-send-email-xuanziyang2@huawei.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a823afb1-e86c-58e3-0a42-ce20b1aafea4@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=rami.rosen@huawei.com \
    --cc=thomas@monjalon.net \
    --cc=xuanziyang2@huawei.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).