DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Ferruh Yigit <ferruh.yigit@xilinx.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH] ethdev: fix dev close in secondary process
Date: Wed, 1 Jun 2022 09:33:09 +0800	[thread overview]
Message-ID: <a84481cc-2ebd-9cc5-350b-88556f7a3145@huawei.com> (raw)
In-Reply-To: <20220531104017.47e59978@hermes.local>

Hi,Andrew, Stephen ,
	I fixed the comment, thanks for your comment.

在 2022/6/1 1:40, Stephen Hemminger 写道:
> On Tue, 31 May 2022 20:08:55 +0300
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> 
>> On 5/27/22 05:35, Min Hu (Connor) wrote:
>>> From: Min Hu <humin29@huawei.com>
>>>
>>> Shared memory like port private resources should only be reserved
>>> by primary process. Secondary process should not start dev, and
>>> the state of 'dev_started' is only meaningful to primary process.
>>> While secondary process need to close dev to release process private
>>> resources.
>>>
>>> This patch limited the scope of 'dev_started'.
>>
>> I agree with the patch since secondary process should not be
>> obliged to wait for device stop before closing ethdev. In any
>> case closing ethdev in secondary process should do nothing
>> harmful to the primary process.
>>
>> However, the patch description pretends to limit dev_started
>> scope for secondary processes in general. It is wrong since
>> secondary processes need the information and that's why it is
>> stored in shared memory.
>>
>>>
>>> Fixes: febc855b358e ("ethdev: forbid closing started device")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu <humin29@huawei.com>
>>> ---
> 
> Also secondary processes are used differently by different application models.
> 
> Some applications only use secondary process for information.
> But some have a primary process that only inits DPDK and do everything
> in a secondary process.
> .
> 

  reply	other threads:[~2022-06-01  1:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  2:35 Min Hu (Connor)
2022-05-31 17:08 ` Andrew Rybchenko
2022-05-31 17:40   ` Stephen Hemminger
2022-06-01  1:33     ` Min Hu (Connor) [this message]
2022-06-01  1:30 ` [PATCH v2] " Min Hu (Connor)
2022-06-01  2:01   ` Ajit Khaparde
2022-06-01  3:18     ` Min Hu (Connor)
2022-06-01 13:45       ` Ajit Khaparde
2022-06-01  3:15 ` [PATCH v3] " Min Hu (Connor)
2022-06-01 10:38   ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a84481cc-2ebd-9cc5-350b-88556f7a3145@huawei.com \
    --to=humin29@huawei.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).