From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D132A0C57; Mon, 1 Nov 2021 18:38:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4003C40E28; Mon, 1 Nov 2021 18:38:39 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 129FC40DF6 for ; Mon, 1 Nov 2021 18:38:36 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="229785984" X-IronPort-AV: E=Sophos;i="5.87,200,1631602800"; d="scan'208";a="229785984" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 09:59:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,200,1631602800"; d="scan'208";a="727453600" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 01 Nov 2021 09:59:57 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 09:59:57 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 09:59:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 09:59:56 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 09:59:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=muQTKdW3Wyh78/9J2IXOiI8kQvbKWI94HsDVa6Qhaxbs7hLhYUv2vrSeXo4wqAH8BWbhBPbTBcCbwdM8SJ5XC1G2VZE+oxs7Kffck6a54hZshWNXiXbRSNVm/TfI7GytmWCwn0rfTsnShRwf8VxZaPoAS7EpE9H5BkziCBwfSn8kPXGRtjxd8cqgZMViD2ORswXJk32jIkhB2bdaM/jFjWyW+jffR5gOvF2jNQ/fNmWN48/1KPIFpexCZPsYotlcOZTfpUxsjp2ZkROLtpKZABurTWKNq8bdQyfaZPe8Vj0DuHmmO7GY2+T6LR1/bM1FTjZN6q+h6knQZbzTVIMfMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6+dbOYzyo/jFWDxtziDbxm5m/hPzICH5fxbfx0zeLw=; b=gLmCUNAe/YGffYb+beafQMYvujyjik/ZmGTSXeCspVlQ3Z5bgeCmAYIcUL++zIXi4WVyDt3tsqGhejG4FWkA8IelQrMFosWiGTjG32VLwMpmcNvYHV8Ev3pJ092i7mQHj7Ph4XaurjgGeLM4qLxz6ilThCQTB16u4vtsX2KRjXlixhmdomrMC0ejp3y03omXZ1Jt/kjrou1C7LoZ7Q7JAoi6eYyTkSIs2WYuSmmHh77o3vrUINTWAwR3At7UrYzLdHyeFkuG2qXrmBS+XrExnAn07Iqt8wslHPnFdvZhFQbhnThUC/bMNleXQ+b7wE7kgm/CrdCnsbsRXkJk8w5ZxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6+dbOYzyo/jFWDxtziDbxm5m/hPzICH5fxbfx0zeLw=; b=BiBv5WKVNkIel9LPptxEAmRJxMBx9/W2G/x9zPPU4v1hehOe7eo57cyVyFLyfT8AiG+6C29EYnLzjycrkc7iOAgRBISNxcQ9lZzbzqcF1EZkrDvMAOabNhIPxOXlg0e0IawoUSnZAWFQeGyUrRkWGN+j22TwI0E1StWdd4ENnrs= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4904.namprd11.prod.outlook.com (2603:10b6:510:40::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 16:59:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 16:59:48 +0000 Message-ID: Date: Mon, 1 Nov 2021 16:59:09 +0000 Content-Language: en-US To: Andrew Rybchenko , Dmitry Kozlyuk , CC: Ori Kam , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "Rahul Lakkireddy" , Hemant Agrawal , Sachin Saxena , "Haiyue Wang" , John Daley , "Hyong Youb Kim" , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Rosen Xu , Liron Himi , Jerin Jacob , Rasesh Mody , Devendra Singh Rawat , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , "Jiawen Wu" , Jian Wang References: <20211019123722.3414694-1-dkozlyuk@nvidia.com> <20211021063503.3632732-1-dkozlyuk@nvidia.com> <20211021063503.3632732-4-dkozlyuk@nvidia.com> <8ba989e2-bb50-7533-6037-c934c005c7ae@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <8ba989e2-bb50-7533-6037-c934c005c7ae@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0241.eurprd04.prod.outlook.com (2603:10a6:10:28e::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0241.eurprd04.prod.outlook.com (2603:10a6:10:28e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Mon, 1 Nov 2021 16:59:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16833382-3a73-4c8e-a981-08d99d59034b X-MS-TrafficTypeDiagnostic: PH0PR11MB4904: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ebf30Q0dZHpoqsfCP78ApWu8ZSRiW0poBm60fKyxd01PjcGNdhpxiyg4Zr4TECBse0TTgHezLanmV2DZBWA96dbbG4e9fG5SbOnK1ELrLt2Ekh5NADkYekfPUb9mUawA33BaJkSPFjig/cDoHNerURsi2h2/NACIpZwoUs/0YKRs858zKG3awzINCC3fSfU52iH9vM617JZvhLkUGDv/voy3wMm/es0DLfGRAwR5Z1NsDqfI0h0WPeSbZ+f2oJ1Wei368ZNYfiMggX4RDWlT7V2KGZV5ta7J7bmFFs84sLUDbQpEdVxLzhz2pQiGcyNXbIH8goLIYHFbXUHzQ1CFouGq1BSSd0iQNkrkN2Ler7wfep0f9ejV10A56PpRStheIEJXm7v4pr3V5vQIW8OfmUrcKwY4rjjbawmWU5L4uN13QrplaHWaZDdwEnnJ2cz1VDzFzxWOAfqTZiqhO3/AeZPv6RxDbyuYY7aIDszZB6y92/8aNe1E54iDBoC2uh6YEYDcfy6qhB4dCZU/DKMC9WY5adKJ8ozK1ASw54F9DFiRlFBbLT2x2MS1F+4GIKW1UxsUyvtvIlPvrBbMpFFrN0nWb/tLBqBbtpe8uGxEbSgQrZFb89VIurZ1mjT3rAtfJQ7hCgkW80387djp8wJNJ1HCPz0iz+7Io76GibijYUF4MJpN6nccLjNwnEar7wify4wYvTYaHDhOYp3kIPTjdA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(31696002)(8676002)(8936002)(44832011)(66556008)(66476007)(316002)(508600001)(2616005)(956004)(110136005)(54906003)(2906002)(83380400001)(26005)(16576012)(38100700002)(7416002)(4326008)(82960400001)(86362001)(186003)(6486002)(5660300002)(53546011)(36756003)(31686004)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFpqN2hUYlYwUm9Ea2NYbjVMVDFmakxPeHZEck9jekFFY0Qzc29WS0ViOFpG?= =?utf-8?B?ME9ENzFTUlAzMUkrSUlQOWN2cnZyYVJHTjJaSFF4NDQ1SU16T25LNjRhYzVJ?= =?utf-8?B?QUtObXJKM1pVODd1THZmYVM4TXU0RDlyZVdYVEkzcnBUS3lUN0dEOFpna04y?= =?utf-8?B?Qk1QSFZWMmJ3ZzlmNnp4ck04TVJxQWZVY0o1TVd4dU9RbmprZW0xYVRSbkpK?= =?utf-8?B?NnJMdzlHYVIyK1lGTXFCM0Jta0gyTDYxWkE5ZzRrNHB4a1J5TmhUdUFLYmVi?= =?utf-8?B?NW5xTmxQMmhpOHNJRGxLOHZxZ1hwdW9qNUZKdWxVb28reXZad0V0TVgwRjVw?= =?utf-8?B?Z0kvVnpSSGlCOTIvMTRzYUtiM0ExTDhDU0F0U3dFYUdXQ0hKd1E2dXNhUzRC?= =?utf-8?B?NXUvSExBemxXSHFyc3NjbXB0ZHZ5VTJxMThKdWVWSGVRMnpaMkt3ekx2Um1R?= =?utf-8?B?YUZPbDFSYXh6WmxYWjBqandWanB3OXFONVE4SUpIZ0hycFY5MS8vVnNkSk4y?= =?utf-8?B?M29WQjNWUlY0bzJTVzU3M205U3BrVUE5MVU5OU80QjVHUUMzRURVYzlwbURv?= =?utf-8?B?ZUZ4MW5Wa1JUWlZZd2pPWnNwQnNiS1lqQkFXMzFzN2p6U3IyVUJreWt5aUd3?= =?utf-8?B?R3RTakMxMmM5ekRIRGlCNitVengvSFZaNVZIdERYQWJ1RzU2ak9JRk8zR1JR?= =?utf-8?B?SmFmeFYyMkcyenRmYVJLZXpaNTVmaUFIcXpXc2RlNHcvemhuN0VOaXRRRVA1?= =?utf-8?B?dTVRa3Vsd0dBZytCdklicU0rQ1pGRHFHUW9RbFAyTDJwaFAwMzRWUkIxSFBx?= =?utf-8?B?Y3VRQzMxV2pDeC9veFpMYnpEdnVYRDQ2N3FVQjdXZ0xneXFac1lqVDJkNVFs?= =?utf-8?B?TlpHNUk4Z0crVnhJQVN4dDZkTERnenY5MGh6SS9qbzRxYUo4MTEwQTdqeFN1?= =?utf-8?B?bEx6N1VWeCs2eWdKenRVTmRGcnVSV3ZVeEhGbm9pYU5QOTk4Ni9rd1pTdHZC?= =?utf-8?B?ZXk1b051SXJraVF0N21jUjlMNHNwYXFIYjhDUEpyMnVvTG9LK1VLYWo3TzBx?= =?utf-8?B?NE5welA3amI4ZXpzNWRhVFdRNEN0K1pxMkFoMzIzR0ZCNGVEMmk0N3RDRzg5?= =?utf-8?B?L3djM3owL1hMT090dW0xaG02Q201WGZ5TVRRMHMyQ3lJaGVsc1FzMjk4cWRw?= =?utf-8?B?QlByQjhzN1A5ZWI5MkhVRXlRTk11UHpwdnVtUG1OWkhTOFB5ZUZ0Rjl5WTRU?= =?utf-8?B?MXlhQ2xJaWhYWFdqSTNvWFJySnRyZFEweXk1L2hERWg3ZEdGYVh4THdrQVB5?= =?utf-8?B?cjI1RGhGYjAraUNrUzg0Vjg5ZE5yU3BvZXpYalF0R3NlV0N3a2QrSzRDK0dp?= =?utf-8?B?NHQ2WWo4Y3hGT29JRm9Qajk1OUY5MXZLcjVxVWs3bkVCTUpYUmNBOEI2NXAx?= =?utf-8?B?eGUycHlqS0FZUkNiKzB2bE9NUTMybHpLSlR6aldzTGNnYjlsSTNSNFFKakJm?= =?utf-8?B?SzFRdzJ6S1VLa1hUbjFOM1lnSS93Y1dEZ0N4Vm9meXFGNkpCeTJ1a3MvdVQ3?= =?utf-8?B?REMxV3Q2VnNDcFJQckRtWUxnS3c5Y0xPTFQyaHpia1p1RDdsUEJJeDVSeW5q?= =?utf-8?B?eU5VU1M2Z2ZYdUlpd1R0OUFrYUtxZEdqaUdxcmU3cDAybklMS0hIekJjcFBv?= =?utf-8?B?WUpQWkxsZlBIdHN0SGQwTnN0dSsxa2FOd3B3SVNGTncwMXdnTE81Sit5a0tY?= =?utf-8?B?WnU0Sk9OSVpDZ24vd003TmhoNm1iWUhjVEVxcmtLeDh3V2lOMWVYblkyL2F2?= =?utf-8?B?RUVHeXRuc1ZKVEtnZ2VFS2lTOWlHOEc5V1pkeTJ0NGFPLzV0QVVjY1Fsa2hn?= =?utf-8?B?cjNqenRjK2ZtSHBvSkE5ZjY0U0hpdTlQcUJxa3NTUC90MS83TDc5TXUwK0kw?= =?utf-8?B?WmQ5eTRCeUVlb0p1MmxPQjNUUUhkbms5T2hpZzVqa05lYXBiSEtMank2Q0Rj?= =?utf-8?B?dmxZUDE4WmJsSDRTa29vMUh0SkpPenEzS1I5M0E5VXJPK21LSlV0RnR6QU9k?= =?utf-8?B?T1B1WXhNeUVWd20xdWJNOUkwNXViVU5qc3Iza3o5SENCSnprSlh6emNpemc5?= =?utf-8?B?UGhLZkhtb1lpd0RlZGVFK3NYeTFaUTRkbENycEZRWUR3cmwrcmJRdWwwbEEx?= =?utf-8?Q?rXZ6mcQZw5iF0fbkQDpO8C8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 16833382-3a73-4c8e-a981-08d99d59034b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 16:59:48.6747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VbElXUS1KNmKsreewL4Lsl9xlZYPzuIbDY4MoPSraGH0JzMsXQHVhygIy3EK5xfZqU6BwbgEZmF0SIjCE3PF/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4904 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/2021 3:06 PM, Andrew Rybchenko wrote: > On 10/21/21 9:35 AM, Dmitry Kozlyuk wrote: >> When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, >> the specified behavior is the same as it had been before >> this bit was introduced. Explicitly reset it in all PMDs >> supporting rte_flow API in order to attract the attention >> of maintainers, who should eventually choose to advertise >> the new capability or not. It is already known that >> mlx4 and mlx5 will not support this capability. >> >> For RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP >> similar action is not performed, >> because no PMD except mlx5 supports indirect actions. >> Any PMD that starts doing so will anyway have to consider >> all relevant API, including this capability. >> >> Suggested-by: Ferruh Yigit >> Signed-off-by: Dmitry Kozlyuk > > I'm sorry, but I still think that the patch is confusing. > No strong opinion, but personally I'd go without it. It is confusing alright to add a flag that has no impact. But again my concern is some PMDs maintainers not being aware of this new capability flag that has an impact in the user application. See the level of comments to the patch from PMD maintainers. This way gives a visibility to both PMD maintainers that some action is required, and gives visibility to application developers and maintainers to track the support. By time the should go away. Updating ethdev without updating all drivers is hard to manage.