From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0C6A243927;
Mon, 22 Jan 2024 11:03:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7B66340291;
Mon, 22 Jan 2024 11:03:19 +0100 (CET)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40])
by mails.dpdk.org (Postfix) with ESMTP id BDE404028B;
Mon, 22 Jan 2024 11:03:17 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=X91BME1PjZLkA/C4CTFQOa/w3DeJETV0GzB+H9UGTcg2mAb2c8Kn6Hqc1zR/W36Bv5v9lYXlDhQGOr7IvLAbMXoDf5kLrhf+ZLOLsKpvoNe2sDQRQMUPgQCT9e/CWtjeTrWeqTvItHpsW++/vI+qKZSUISQ3+7QR8RNlMJ2HdGh9Tz27/FL6tF+TaDjBTkAf3hpGYbU9ZJzIDuz9QyuwGQWnaCn1aAU6hTuXdS1DBOZeThqB81aIQ/PAjGfBVTOuIh46jZTTHFiBvSp0YZ0FW0Gpix+p0+ckhtxi6H8Ml45hKTbHf+t0RpH0l/5IxnJCfn7vdWkiU3Rbzqi8Er2Mxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=20dB6YEWWg/OMtdEDQroWPJglqL7hxCjq2ZjMuYqxOU=;
b=LCtNUf3nQ5LUFU8wmaBRwDvJZLNZC7DAuQiKPQvhu+2tgyNpbUNXdU0Lg/hAETpsba3zI9iS1+f8vsOiV3BzNpzvU5FN7xZQZvazAODi/cbnbc4qL18HwNYZHb41kRzOlWTViZLVrMX+yU+B7VWbYmQCn3IkbCIcenNTp4ZzPLSlztKwhjKbUwzo1ngqvOu9OwnvPfcVerlbDijPAciIaxAH2bAcjZ8Ry6j0vG0c9iq5S2m1+KcXYjB/h3Fal2z+R9PN45gr12VqNtxmdoh++mWHPF8h0VyaB0wzl6sRMXKmtQP71AYvcyvP68Wc2J7TGctNULt2q3u8KL/5lfks5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=20dB6YEWWg/OMtdEDQroWPJglqL7hxCjq2ZjMuYqxOU=;
b=WYX5/xcAgu3ZOSIXQdUjYIgNVat/eO5bx1tdY2z5nZBJ6BpqV695Bm2Ollju0Cl8GBC8x6VxlrN6uMJ79NVaV17DxWURVRu/apN092Tbd5vp2T83SQ9MLh5zhIoUgCSfI1cOLflEYP7IS/cGO9NtyeB4K5kn68ipPa1X7UgMhmA=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by PH7PR12MB6936.namprd12.prod.outlook.com (2603:10b6:510:1ba::7)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Mon, 22 Jan
2024 10:03:15 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7202.031; Mon, 22 Jan 2024
10:03:15 +0000
Message-ID: <a867c823-6c38-4202-9da5-489061ca64a6@amd.com>
Date: Mon, 22 Jan 2024 10:03:07 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list
Content-Language: en-US
To: "Power, Ciara" <ciara.power@intel.com>,
"Sivaramakrishnan, VenkatX" <venkatx.sivaramakrishnan@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>, Zyta Szpak <zr@semihalf.com>,
Liron Himi <lironh@marvell.com>, Chaoyong He <chaoyong.he@corigine.com>,
Gagandeep Singh <g.singh@nxp.com>, Jerin Jacob <jerinj@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pascal.mazon@6wind.com" <pascal.mazon@6wind.com>,
"shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
"tdu@semihalf.com" <tdu@semihalf.com>,
"qin.ke@corigine.com" <qin.ke@corigine.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"stable@dpdk.org" <stable@dpdk.org>
References: <20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com>
<20240118120741.1434286-1-venkatx.sivaramakrishnan@intel.com>
<a321e825-5508-4e5d-af4d-7ae0b30c56e4@amd.com>
<SN7PR11MB7639C87A52C682484A90F972E6702@SN7PR11MB7639.namprd11.prod.outlook.com>
<287729b3-6ad4-4488-886d-b53e169df923@amd.com>
<SN7PR11MB7639E8689E2077DE2CC44E54E6752@SN7PR11MB7639.namprd11.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@amd.com>
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
In-Reply-To: <SN7PR11MB7639E8689E2077DE2CC44E54E6752@SN7PR11MB7639.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM
(2603:10a6:d10:95::6) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6936:EE_
X-MS-Office365-Filtering-Correlation-Id: 45367799-8289-496e-dd62-08dc1b31590b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: I2enYwnR/SqFdG0s/DLM+32NtZBjTOMFOH8EazUZi3F1j+lf+oDmVZ7e/Q4Ora/RC87T2wlBS1Hm8CrkWs/VdkNoUMIVNkGZsBNT9FknkoH/KeBKkrGZoTKRvtf8Bjs73fEJXgHsU2de2mlpajrIhquQt6nYIsnuS18oW627OFesLI6ydcczrpVeCUCm6R/ThfZDJOGMUJ41UBeJsWMwy/7bOdldONxDUS6xGNUWElAryX0sQm4iSvq5CkvL+NMbNCgnrQ7/9Y+Q9yaIlmuzOZyRvbwElWox+Acx+nxFf2II2Ro7JNloxGMTI9A9uCiaXhSofmLl3GenVtNrC42m1IQJo9RHKJCQ21ZnRZ3g8M3d92scog+mTbEW9qxgsivzpcUvtJns9MzJRE0FUQtx+hwvkeIv5B79tOaz380o7PUu4KTrFbAHAz9WLinIfsunVBy9oQy+y91BF+SuX5L9XBb6nAx6Vm4f7xbClGP9BBILCllPxjnwtQZFc3pGDXf3TDd07hUCbIxqczZJsFVGbIZSfChbQyiRno4JD3sCNMJG2AjJZtCK31NMjVIJEw3Uuv7auM7Fa5+2udKWq2np+4GEPFHtRovAqzGUngAxYNtq87wvF0rpJhf+0McQAJkCK7rU2iVI8BDed4Q6mYQ3T+F/lApbt1hZm21AGkLh1jY=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(376002)(136003)(366004)(346002)(396003)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(83380400001)(6512007)(26005)(2616005)(44832011)(38100700002)(8676002)(4326008)(8936002)(5660300002)(7416002)(6506007)(478600001)(6486002)(966005)(2906002)(66476007)(6666004)(54906003)(53546011)(66556008)(316002)(110136005)(66946007)(41300700001)(921011)(36756003)(31696002)(86362001)(31686004)(66899024)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVN1WVRyMU54enRjR0E0Q2QrQVJkb1VwZFpIS25mempCRmdmck8yejNNMUw4?=
=?utf-8?B?cGxhVDVCbnFLN1A1RVFTbnRhenVnY1Y4TFBhY0F4dVBRQm5hUDBVdyttNjJ4?=
=?utf-8?B?YUs0Z3QvMGxMZTZjQmNYT3NRbmh2WWQ5TUVSek5aV3dxYTMzS3JZcUsxdGlq?=
=?utf-8?B?RWY3czNmMjdGRFR4UmNtWWk4TkJYTkpUc0tsM0thYm9DQ1BxVlJZV3M5ajR4?=
=?utf-8?B?U1dGbUZuU1Yrb1oyVHJTcGRWZUw0SEF0dGZtMzlZTXFJeldqQ0MvYkJVQkdX?=
=?utf-8?B?U3hMcVJ0Q1JRMjZlZE5FcTF5WkdtTzJiVWNzNFRyUDAyZFYrcnVzK1RlOXF1?=
=?utf-8?B?Z3pyUElveXY1MVdQRjlkdWFsaHVXSkdVT2NHVEM5TDF5UXl2MzIxeU54R3JP?=
=?utf-8?B?cDFnelFzYXVrNmpsYzVscU9PcHhnMnB1bmRHYUQwRVAyaGZZM2tHOUEwZExr?=
=?utf-8?B?UG9laXpVQUJwSXFha2dpbzM1U0xtUE1HalczSUJjLytkTm9VV3plZm1LbU14?=
=?utf-8?B?SU9yVW1nbFBHeFROR2s5cm1RRTlNY0I3RHIwaUFzRTM3UHBtQk5SSzVaclRG?=
=?utf-8?B?SzFpdk1hbGF1bWtlaGxBYUVmdUJlejkybFpEN0dJYldVRlgyaDFOaXFWOUta?=
=?utf-8?B?Q0JWU2FTSXN2Tk5vbFNPb1hwL1plMCtNdERUT2d5QnROZ20xUEc2b2ZSRVRR?=
=?utf-8?B?aUtDTVYvUUhBbDJjTU5UanNiMy9wRVlncnh1dE1teHRVb3RBbERPOXQ3ZXBz?=
=?utf-8?B?d25VSmRPZ0xlVDVvWXZ4NHVYWnRNNzZDM2w1U1UxWG5jbVFGQ2I0Nm1NeE9q?=
=?utf-8?B?OTk5eFZ0MDJ5eFJWNzg4NjF6emk4UXA2REhqcVpsajd4QWM3WEY3SWxpRkxo?=
=?utf-8?B?UWhzWXdDTVFOVTR5RlBiS3R0NjR4MzFmdTFQeXdGSkFKbkxYRU9ySVB0K290?=
=?utf-8?B?T0VxMG9EcFZlTGVhRWdHdmZXN1JPTlhTL2NDLzFTWi95NnJuTmRIRVBvTVFK?=
=?utf-8?B?RlAraFRtc3ZqVDNJTVhPVEx4ZStjVEo0SDIwNXVnbDMxVTJGSDI2RSt3TzN0?=
=?utf-8?B?WWRkRmZpa2JsRHNtci90Vk14UVRiK05ialR1QnQyTHZsVUQvditYY0VqZTNR?=
=?utf-8?B?K0FETWlSajFVOU84Wjk2eUtuSnlXZ2NPT0JIejdIZXhONk05L2F3RVlxT1hM?=
=?utf-8?B?aitqYVZObG9xUWVjK3RQRWg5VTNzNHcweUxiaEhPNkdKM0t2L3o3akwrS001?=
=?utf-8?B?eDAyT0NvOGJZY1JCK2luYnhWR25wdDFucU1yd01PY2xzZjhKbUZHMndxMUhn?=
=?utf-8?B?cnhLZlB5OVRQTXZsNGxGKzhHbzZlNVlXaUNucFZDbnlxQWtON3FrQVhEODM2?=
=?utf-8?B?aFJiQTJZY3NvVVlZRElQZ0VvNG9kbXQ5b21obEdlYzZ6ZXJUWjdKMmc5K3Yv?=
=?utf-8?B?SGJ3SnlYRjM2SWJTaXVkTTVFdklHbC9rTnBvQ3I4UEZVeWp0TzlaQlBrVTZ2?=
=?utf-8?B?SjZ1elNmOU9XY2VlMFU3QTZua1FSVU9DU1d3cnh0K2x1bUYxcEZpcnlNbWVW?=
=?utf-8?B?dGxmZ1hta0NXSys1OStkY0xDd0FhYk9UWnp3MzhoNUJpc1d1eGJhMmhYOWZM?=
=?utf-8?B?aXQxbE5rUkRaMWVsajJOZXd4QkFvME1reWpIaGtCeEpOK2psV0dKbThqRmhT?=
=?utf-8?B?bUN4ejZJZHpPVGxNUXVObWE5eW4zNEdaQ041WE1BSTgvTThGbEYxQkdZdDZM?=
=?utf-8?B?Y0RQdU82N2w1ajVwVHEzdHh6WjJOWStmb2psV1I4OElDQ252S1ZOZTZWYTNC?=
=?utf-8?B?VXRoOTJRTG1pRG90bEtRUWdnZGJ3YmZzcFZuSVF0bUwxQW5ueTlkOHhhMnpn?=
=?utf-8?B?S0ozbWdQSmgraDI1OWhqNUxZZHlBc3Izc0lHeDdXaW9scXhaVXdFRDRrbWdy?=
=?utf-8?B?N2dzbm96WGdIVmFnMElQUUJGUVV2czhGZmQ2L0EzdFVGelJOZXFxMkJJZkR4?=
=?utf-8?B?SFBPVjl4NjBHYVhDYmVjdis1NXZuZzRoUUJzdy9lT0szU25WekhwaittUXNl?=
=?utf-8?B?YWNoanZlRnJDNFNLMkNWQ1VQZk9MOXFUbFVzL1NoTUQ0bVluVmlOMU14V3hq?=
=?utf-8?Q?YOBw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45367799-8289-496e-dd62-08dc1b31590b
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 10:03:14.9815 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L2dedT//zKzDjXmesR34OteUOiG9fpU5zN2A1Clrjc1UZf+qhwpdGxElimKX3c5x
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6936
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 1/22/2024 9:46 AM, Power, Ciara wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>> Sent: Monday, January 22, 2024 9:43 AM
>> To: Power, Ciara <ciara.power@intel.com>; Sivaramakrishnan, VenkatX
>> <venkatx.sivaramakrishnan@intel.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>; Zyta
>> Szpak <zr@semihalf.com>; Liron Himi <lironh@marvell.com>; Chaoyong He
>> <chaoyong.he@corigine.com>; Gagandeep Singh <g.singh@nxp.com>; Jerin
>> Jacob <jerinj@marvell.com>; Maciej Czekaj <mczekaj@marvell.com>
>> Cc: dev@dpdk.org; pascal.mazon@6wind.com; shreyansh.jain@nxp.com;
>> tdu@semihalf.com; qin.ke@corigine.com; jerin.jacob@caviumnetworks.com;
>> stable@dpdk.org
>> Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for ptypes list
>>
>> On 1/19/2024 5:10 PM, Power, Ciara wrote:
>>> Hi Ferruh,
>>>
>>>> -----Original Message-----
>>>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>>>> Sent: Friday, January 19, 2024 2:59 PM
>>>> To: Sivaramakrishnan, VenkatX <venkatx.sivaramakrishnan@intel.com>;
>>>> Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
>>>> <sachin.saxena@nxp.com>; Zyta Szpak <zr@semihalf.com>; Liron Himi
>>>> <lironh@marvell.com>; Chaoyong He <chaoyong.he@corigine.com>;
>>>> Gagandeep Singh <g.singh@nxp.com>; Jerin Jacob <jerinj@marvell.com>;
>>>> Maciej Czekaj <mczekaj@marvell.com>
>>>> Cc: dev@dpdk.org; Power, Ciara <ciara.power@intel.com>;
>>>> pascal.mazon@6wind.com; shreyansh.jain@nxp.com; tdu@semihalf.com;
>>>> qin.ke@corigine.com; jerin.jacob@caviumnetworks.com; stable@dpdk.org
>>>> Subject: Re: [PATCH v5 1/2] drivers/net: fix buffer overflow for
>>>> ptypes list
>>>>
>>>> On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote:
>>>>> Address Sanitizer detects a buffer overflow caused by an incorrect
>>>>> ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer
>> overflow.
>>>>> Fix the ptypes list for drivers.
>>>>>
>>>>> Fixes: 0849ac3b6122 ("net/tap: add packet type management")
>>>>> Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing")
>>>>> Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
>>>>> Fixes: f3f0d77db6b0 ("net/mrvl: support packet type parsing")
>>>>> Fixes: 71e8bb65046e ("net/nfp: update supported list of packet
>>>>> types")
>>>>> Fixes: 659b494d3d88 ("net/pfe: add packet types and basic
>>>>> statistics")
>>>>> Fixes: 398a1be14168 ("net/thunderx: remove generic passX
>>>>> references")
>>>>> Cc: pascal.mazon@6wind.com
>>>>> Cc: shreyansh.jain@nxp.com
>>>>> Cc: zr@semihalf.com
>>>>> Cc: tdu@semihalf.com
>>>>> Cc: qin.ke@corigine.com
>>>>> Cc: g.singh@nxp.com
>>>>> Cc: jerin.jacob@caviumnetworks.com
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Sivaramakrishnan Venkat
>>>>> <venkatx.sivaramakrishnan@intel.com>
>>>>>
>>>>
>>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>>>
>>>>
>>>> ("Cc: <email>" shouldn't be in the commit message, but not big deal I
>>>> can remove them while merging.
>>>> If you want to help, in next version please put them after '---', as
>>>> you are already doing with changelog)
>>>
>>> Thanks for the review on this one.
>>>
>>> The DPDK docs suggest adding the Fixes line + CC in the commit message
>> body - has the guidelines changed for this?
>>>
>>
>> Can you please point me the mentioned doc, let me check it?
>
> Sure, it's in section 8.7 here: https://doc.dpdk.org/guides/contributing/patches.html
>
>
Right, Cc the author of the fix added later to the 'git fixline' alias,
this is useful because 'git send-email' picks "Cc: ..." and cc the
author to the patch.
But this info is redundant in the commit log, so maintainers are
removing it from commit log while merging.
If the "Cc: ...", is after the '---', it is still picked by 'git
send-email' and removed automatically while merging, so this is better
option.
It is possible to update documentation but I am concerned to make adding
fixline more complex for new contributors. Perhaps can add a new line as
a suggestion.
But briefly, if you move after '---' it helps.