From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D96237CBD for ; Wed, 13 Sep 2017 14:35:04 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 389516005E; Wed, 13 Sep 2017 12:35:04 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx3-us4.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id B0A128005B; Wed, 13 Sep 2017 12:35:01 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1058960076; Wed, 13 Sep 2017 12:35:01 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 13 Sep 2017 13:34:56 +0100 To: Shahaf Shuler , Thomas Monjalon CC: "dev@dpdk.org" References: <223be6bf-510e-e34d-2359-c0f1becd5bad@solarflare.com> <07f35197-ed1c-a959-3518-3a541e259b3c@solarflare.com> From: Andrew Rybchenko Message-ID: Date: Wed, 13 Sep 2017 15:34:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23326.003 X-TM-AS-Result: No--18.874800-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1505306102-GhuzaUebh8je Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 12:35:05 -0000 On 09/13/2017 03:33 PM, Shahaf Shuler wrote: > > Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: > > >>return -EBUSY; > >>      } > >>  +    /* > >>+     * Convert between the offloads API to enable PMDs to > support > >>+     * only one of them. > >>+     */ > >>+    if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) { > >>+ rte_eth_convert_rx_offload_bitfield( > >>+ &dev_conf->rxmode, &local_conf.rxmode.offloads); > >>+    } else { > >>+ rte_eth_convert_rx_offloads(dev_conf->rxmode.offloads, > >>+ &local_conf.rxmode); > > > >Ignore flag is lost here and it will result in treating txq_flags > as the primary > >information about offloads. It is important in the case of > failsafe PMD. > > > > >Sorry, I mean rxmode (not txq_flags). > > Am not sure the ignore_offload_bitfield is lost on converstion. The > convert function does not assign to it. > That's true. My bad.