From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 59E095F1C for ; Thu, 8 Mar 2018 11:46:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2018 02:46:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,440,1515484800"; d="scan'208";a="206499504" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.141]) ([10.237.220.141]) by orsmga005.jf.intel.com with ESMTP; 08 Mar 2018 02:46:47 -0800 To: Pavan Nikhilesh , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Cc: dev@dpdk.org References: <20180308101805.GA9526@ltp-pvn> From: "Burakov, Anatoly" Message-ID: Date: Thu, 8 Mar 2018 10:46:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308101805.GA9526@ltp-pvn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 10:46:54 -0000 On 08-Mar-18 10:18 AM, Pavan Nikhilesh wrote: > Hi Anatoly, > > I am trying to verify this patchset and have encountered few issues. > > Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ > eal_common_memzone.c files. Thanks for the heads up, i'll fix those in the next revision. Out of curiousity, which compiler version are you using? > > diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c > index a7cfdaf03..ad4413507 100644 > --- a/lib/librte_eal/common/eal_common_memzone.c > +++ b/lib/librte_eal/common/eal_common_memzone.c > @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) > struct rte_fbarray *arr; > struct rte_memzone *found_mz; > int ret = 0; > - void *addr; > + void *addr = NULL; > unsigned idx; > > if (mz == NULL) > diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > index 1008faed6..32b0d5133 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, > unsigned int msl_idx; > int cur_idx, start_idx, end_idx, i, j, ret = -1; > #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > - bool have_numa; > + bool have_numa = false; > int oldpolicy; > struct bitmask *oldmask = numa_allocate_nodemask(); > #endif > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > index f74291fb6..d37b4a59b 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) > struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; > struct hugepage_file *hp = NULL; > unsigned int num_hp = 0; > - unsigned int i; > + unsigned int i = 0; > int ms_idx, msl_idx; > - unsigned int cur_seg, max_seg; > + unsigned int cur_seg, max_seg = 0; > off_t size = 0; > int fd, fd_hugepage = -1; > > > > @Hemanth > Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on > `rte_eal_get_physmem_layout` that is depricated > http://dpdk.org/dev/patchwork/patch/34002/) > So, generic arm64 linuxapp build is broken. Should the deprecation notice have been accompanied with marking that function as __rte_deprecated? > > Regards, > Pavan. > > On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: >> This patchset introduces dynamic memory allocation for DPDK (aka memory >> hotplug). Based upon RFC submitted in December [1]. >> >> Dependencies (to be applied in specified order): >> - IPC bugfixes patchset [2] >> - IPC improvements patchset [3] >> - IPC asynchronous request API patch [4] >> - Function to return number of sockets [5] >> > > -- >> 2.7.4 > -- Thanks, Anatoly