From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84825431E0; Mon, 23 Oct 2023 11:05:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FDDA406B4; Mon, 23 Oct 2023 11:05:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E805940689 for ; Mon, 23 Oct 2023 11:05:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698051957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aByG5IG3U5XL54qB3r4RklWKuNAplDe+mGLr1UBrYtU=; b=OqHg4D0tDWySQUc9TL4QA1WEDKgh+zCRlsb+TP3Vkkyszc/dbT8W8kem7eWS/rCM2l+P0D Mzx4DNRbz4auI4xPSPQ54mjamf1Eo9mHMQLIbA3ht5j+WenBe4Kq/TaVsHYxjVVdvm6WOd Pm/I1yuXlgdFoEEO5ymklBKwqzCtnlc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-MpCSLDklPZCs938TURGaWQ-1; Mon, 23 Oct 2023 05:05:53 -0400 X-MC-Unique: MpCSLDklPZCs938TURGaWQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD9E18564EC; Mon, 23 Oct 2023 09:05:52 +0000 (UTC) Received: from [10.39.208.17] (unknown [10.39.208.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7005940C6F7E; Mon, 23 Oct 2023 09:05:51 +0000 (UTC) Message-ID: Date: Mon, 23 Oct 2023 11:05:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for queue configure To: "Chautru, Nicolas" , "Vargas, Hernan" , "dev@dpdk.org" , "gakhil@marvell.com" , "Rix, Tom" Cc: "Zhang, Qi Z" References: <20230929181328.104311-1-hernan.vargas@intel.com> <20230929181328.104311-7-hernan.vargas@intel.com> <2b343232-93ce-445f-b47c-064a018ff93b@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/19/23 14:12, Chautru, Nicolas wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, October 19, 2023 10:47 AM >> To: Chautru, Nicolas ; Vargas, Hernan >> ; dev@dpdk.org; gakhil@marvell.com; Rix, Tom >> >> Cc: Zhang, Qi Z >> Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for queue configure >> >> Hi Nicolas, >> >> On 10/19/23 10:41, Chautru, Nicolas wrote: >>> Hi Maxime, >>> >>> Do we really want to make these kind of changes on to the stable release, it >> tends to artificially increase the amount of churn on the stable release which >> can be counterproductive for such changes which don't add much value if any >> to user/developper. >>> Happy to follow your suggestion but a general feedback is lack of appetite for >> very large amount of changes in stable patches which inhibit adoption, so >> would expect to put things there that we would genuinely flag as a bug. >>> Kindly share your thoughts. >> >> Checking for configuration failure in a test application is quite useful in my >> opinion, as it can help catching regressions, isn't it? > > I don’t personally think this (or for other commit on that serie) hits that bar for being required in stable release. This ends up being counterproductive having stable release with a huge amount of commits that are not really required, and it ends up being a reason for people not to move to stable release. > But if you are really convinced, ok to follow your reco. Adding LTS maintainers if they want to step in. Personally, I think ot should be backported. Maxime >> >> Maxime >>> Thanks >>> Nic >>> >>> >>>> -----Original Message----- >>>> From: Maxime Coquelin >>>> Sent: Tuesday, October 17, 2023 9:43 PM >>>> To: Vargas, Hernan ; dev@dpdk.org; >>>> gakhil@marvell.com; Rix, Tom >>>> Cc: Chautru, Nicolas ; Zhang, Qi Z >>>> >>>> Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for >>>> queue configure >>>> >>>> >>>> >>>> On 9/29/23 20:13, Hernan Vargas wrote: >>>>> Stop test if rte_bbdev_queue_configure fails to configure queue. >>>>> >>>>> Signed-off-by: Hernan Vargas >>>>> --- >>>>> app/test-bbdev/test_bbdev.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/app/test-bbdev/test_bbdev.c >>>>> b/app/test-bbdev/test_bbdev.c index 65805977aead..cf224dca5d04 >>>>> 100644 >>>>> --- a/app/test-bbdev/test_bbdev.c >>>>> +++ b/app/test-bbdev/test_bbdev.c >>>>> @@ -366,7 +366,8 @@ test_bbdev_configure_stop_queue(void) >>>>> * - queue should be started if deferred_start == >>>>> */ >>>>> ts_params->qconf.deferred_start = 0; >>>>> - rte_bbdev_queue_configure(dev_id, queue_id, &ts_params->qconf); >>>>> + TEST_ASSERT_SUCCESS(rte_bbdev_queue_configure(dev_id, queue_id, >>>> &ts_params->qconf), >>>>> + "Failed test for rte_bbdev_queue_configure"); >>>>> rte_bbdev_start(dev_id); >>>>> >>>>> TEST_ASSERT_SUCCESS(return_value = >>>> rte_bbdev_queue_info_get(dev_id, >>>> >>>> If should be a fix IMO. >>>> With fixes tag added and stable cc'ed: >>>> >>>> Reviewed-by: Maxime Coquelin >>>> >>>> Thanks, >>>> Maxime >>> >