From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 94B882C60
 for <dev@dpdk.org>; Tue, 19 Mar 2019 14:29:02 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D518519F995;
 Tue, 19 Mar 2019 13:29:01 +0000 (UTC)
Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id E4A43614C1;
 Tue, 19 Mar 2019 13:29:00 +0000 (UTC)
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
References: <20190319064312.13743-1-tiwei.bie@intel.com>
 <20190319064312.13743-6-tiwei.bie@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <a8b1969f-231a-163d-0669-db560a825099@redhat.com>
Date: Tue, 19 Mar 2019 14:28:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190319064312.13743-6-tiwei.bie@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 19 Mar 2019 13:29:01 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue
	structure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Mar 2019 13:29:02 -0000



On 3/19/19 7:43 AM, Tiwei Bie wrote:
> Put split ring and packed ring specific fields into separate
> sub-structures, and also union them as they won't be available
> at the same time.
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c           | 71 +++++++++---------
>   drivers/net/virtio/virtio_rxtx.c             | 66 ++++++++---------
>   drivers/net/virtio/virtio_rxtx_simple.h      |  2 +-
>   drivers/net/virtio/virtio_rxtx_simple_neon.c |  2 +-
>   drivers/net/virtio/virtio_rxtx_simple_sse.c  |  2 +-
>   drivers/net/virtio/virtqueue.c               |  6 +-
>   drivers/net/virtio/virtqueue.h               | 77 +++++++++++---------
>   7 files changed, 117 insertions(+), 109 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 49180A00E6
	for <public@inbox.dpdk.org>; Tue, 19 Mar 2019 14:29:04 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1D76B44C3;
	Tue, 19 Mar 2019 14:29:04 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 94B882C60
 for <dev@dpdk.org>; Tue, 19 Mar 2019 14:29:02 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D518519F995;
 Tue, 19 Mar 2019 13:29:01 +0000 (UTC)
Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id E4A43614C1;
 Tue, 19 Mar 2019 13:29:00 +0000 (UTC)
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
References: <20190319064312.13743-1-tiwei.bie@intel.com>
 <20190319064312.13743-6-tiwei.bie@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <a8b1969f-231a-163d-0669-db560a825099@redhat.com>
Date: Tue, 19 Mar 2019 14:28:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190319064312.13743-6-tiwei.bie@intel.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 19 Mar 2019 13:29:01 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue
	structure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190319132859.w-19mpMhzzqtilP4s_bq50mWwDEJXP52hukL2E9F-qU@z>



On 3/19/19 7:43 AM, Tiwei Bie wrote:
> Put split ring and packed ring specific fields into separate
> sub-structures, and also union them as they won't be available
> at the same time.
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c           | 71 +++++++++---------
>   drivers/net/virtio/virtio_rxtx.c             | 66 ++++++++---------
>   drivers/net/virtio/virtio_rxtx_simple.h      |  2 +-
>   drivers/net/virtio/virtio_rxtx_simple_neon.c |  2 +-
>   drivers/net/virtio/virtio_rxtx_simple_sse.c  |  2 +-
>   drivers/net/virtio/virtqueue.c               |  6 +-
>   drivers/net/virtio/virtqueue.h               | 77 +++++++++++---------
>   7 files changed, 117 insertions(+), 109 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime