From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0081.outbound.protection.outlook.com [104.47.32.81]) by dpdk.org (Postfix) with ESMTP id 1447D3195 for ; Thu, 28 Sep 2017 13:40:33 +0200 (CEST) Received: from DM5PR03CA0057.namprd03.prod.outlook.com (10.174.189.174) by DM5PR03MB2700.namprd03.prod.outlook.com (10.168.197.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 28 Sep 2017 11:40:33 +0000 Received: from BN1AFFO11OLC001.protection.gbl (2a01:111:f400:7c10::120) by DM5PR03CA0057.outlook.office365.com (2603:10b6:4:3b::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Thu, 28 Sep 2017 11:40:32 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11OLC001.mail.protection.outlook.com (10.58.53.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Thu, 28 Sep 2017 11:40:32 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8SBeTaw005474; Thu, 28 Sep 2017 04:40:30 -0700 From: Shreyansh Jain To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-26-shreyansh.jain@nxp.com> <5b28593b-5d6c-f77a-80a2-9e8332820b8e@intel.com> <0c4268d8-04e0-4e68-d7e9-8b639e3154d2@nxp.com> Message-ID: Date: Thu, 28 Sep 2017 17:21:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0c4268d8-04e0-4e68-d7e9-8b639e3154d2@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131510724327693867; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(39860400002)(346002)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(24454002)(189002)(377454003)(65826007)(54906003)(5660300001)(50466002)(47776003)(8656003)(77096006)(86362001)(31696002)(53936002)(498600001)(68736007)(104016004)(189998001)(316002)(58126008)(23676002)(2870700001)(33646002)(6246003)(93886005)(65806001)(6666003)(2906002)(305945005)(2950100002)(4326008)(64126003)(106466001)(76176999)(356003)(6916009)(65956001)(31686004)(83506001)(36756003)(85426001)(50986999)(54356999)(97736004)(53546010)(81166006)(105606002)(81156014)(8676002)(8936002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2700; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC001; 1:DQ8vNCnD4/lvWmIbCQNtnkHM+2mjYAHQXHlpU5mLfRDE64sK0uH2fBnETuKGN+9rVO8z4St3SInNxtTm4T+rua2QyemGU6ikXij4bsSCDO8wxWEXKAaaQpNeCdLw956s X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27941783-fc40-4bf6-1b71-08d50665ba27 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:DM5PR03MB2700; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2700; 3:x4pxfVhBM/JkASUzH0a4kM5FMr8cU1PgxQ53fI+LMe2xHRnOp2VcefDg6zf9G8ssiFJ4kB2oxgshpXZF6chUFl02JUeDwfD3NJyGxVRo/UX9s3eeGgx7yRd5vIVHY9IPBmyKVJvwssceKkivEMfKOo9nsZtVZwn3xkFoDgnK0eLgG9WrLG9Wyq8qyE72oddG8Qe5hdyiq56M1pv3CHheYRJpQQjrWg3su8xijG4iQZzspx2VrXl3d0fogheuGhGVgP3wnKeHtKSYczUOqdpAJjgdUNH9zlP7qHkFWQfT+T4WJ4IzarGVz1RP9oRiC133CAtCflG4Enfinh1QCsAkOXuj4OjD2pjuraU//Fnp6rg=; 25:mpI+R9iKZgD5wIROXbCK7NDzcx2s/dRZn5EyLsH3x9p4SNXqH3OQexytJ9a39h0mfglzBhzG+PPvn23NygI7212BvIqQ/u6ek4IQBFep384G4rX9tLCI76brdizgao3NLjTeDUmr6QfYIYTGFJTcP9tHd9yL2fZ6P4LipMjkEMEXYmmsn7tQj4yNp5Y5ujur6PolhY4KMLsgyLDMVm/X4soL66V2sCmF6EMzPb7sZEafkmbZLsNJ86C4K0f3m5EIXJrHCYOCgQB89HXn/hRTpKtMaKCOYvXuVdHJJ+tRfXxYb/0Kv29N7DJkWXxHNo3m1iPeUroQSvzxJScyJzpeDw== X-MS-TrafficTypeDiagnostic: DM5PR03MB2700: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2700; 31:rw48XdPTYD/rM9J+82VCvmtS7qYP8HFJ03AGfPe56DtE+4Fr9FjgPJEh4ZgYS6PxdRJOpfKDDFtQoQJc6FhwZcibzW8s/gPwa4C2z65mLQHfY1fwo3f/fjSwm9PZkByEkrZuuLVH0SaLYv/8NVu/QLNzXVJYANR/9JVB1bXc0KaPCgbbMVc/gTq+GJcGMwiiCtiDJjTrqeyHpC86bempEg86HokukhcwYn0cc9sfs44=; 4:1+YzUFEAOVL1GUzR/afaYa8x9AIoUGch5vhc3CJcMJQ/AzS/Hzif8Pf9r9Td+Z/iodanS41i7MaKCX8vnxgTrlSJVLG4M0Ax01ez9It/ZyrsdD+AGuqUI4CkruJMgJSd5zr6O74xOmpFGBpqj+M6nrEWhjebRDz9cCgy/7tVonQaGRPeSxLwns7m7cXqPWH2FwPl2a3wvWPe3GsbbvHN/TlYh895h1JrblZaq4f7LWglqIz7H6FQx3nDaMcSKeMeu+IWnpQb3ZjOCGdkUtmd37U5xJP/5+P4oyJS46MBKao= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123556025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123561025)(20161123565025)(20161123559100)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR03MB2700; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR03MB2700; X-Forefront-PRVS: 0444EB1997 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIyNzAwOzIzOkcwRTkzZngrblNTeFRMb0RJR05zQVNJbzVK?= =?utf-8?B?UDdVVnREa0F5RDk5Tm50MzBGYkdVcGNSNG1ITXBjc3ZZU1o0SGM5MDZISW12?= =?utf-8?B?akJmTkJqWGpONWh6YTlONkVyYTdrdWFvTEJ5L3pTNnV3UnptVEVKNzZrSmRu?= =?utf-8?B?R1YwNXE5UFpTMWhGSmhpK21PaEc4ZXNYcjc2TzZkV1d5clBzWHFtVlpyT1B1?= =?utf-8?B?MzM5Z0FnekJpWEZuSDEzTWgxRGxvSlFZVXgyMzdhSE8wK0ZKTVVxZ0Q3NWZw?= =?utf-8?B?azhkTmFOVmVqUUpYRzArMDV4NzJKU1NQYXduTnc4U1crMlZEQlY3UmpzMVFm?= =?utf-8?B?cWpKM2tHRXd1ZTk4c2Z5Mkx1WU1QOXdGZ2RJdjUraWpZNlNKNmJyZDZJaFY1?= =?utf-8?B?SVI4YWJJb1FXOEZKSXdDQWtvM21HL3dlZnFqQU4rWTFIdytLL2prd2xobmc2?= =?utf-8?B?QU1EYkhjWEFOY3JMNXh6aGNjM2N0eDZOc2E3Q3l3RzhVM1U1aDBtSHI1YWlu?= =?utf-8?B?bDJBUzZmbEczaW5TcmdsTUxHNDh6NDlYYTZJRVMvcGNkdzNPU28vdStJbWt5?= =?utf-8?B?ZC82OFR1dFU2aTFjOEI4OFJPRGR2Q0hLeW1VZ0pBdXhrWFhqZ0gxRUdkNGtV?= =?utf-8?B?d0NSdGRoWXA2VUhhMklJQTZtUmJCb0VwR2cvT2doM0xpUE1KdjhCRUxSMGVp?= =?utf-8?B?NTVHbCs2QWxOdmE5VVl5WmF5dFFJUkJWYll1K3E4UTMzTW1MWFd1K01WQUNM?= =?utf-8?B?ckNDMmZYeVQvN1hFT1FPdVl4MXpPWUpKcDdzWTRnaHZyZy9YNmw0bk0zb21U?= =?utf-8?B?cHhLZkRDV3RlWUVNbXVCZ3lLYVFLNVpxakxqeExaODIvd1hRd2xVcjRKUzJv?= =?utf-8?B?SjJUZ0VsTkZsU2FFYUpUU1kvaEFzQkNCWTgyZ0IyRCt4bkhjdldTSnRKc1pZ?= =?utf-8?B?NWZDbjFSL0RoRERhc0tmVDZRQXl6bXpyRGNCK2tqS0J4UkNONnZlK0dSUmxH?= =?utf-8?B?OC9YUzEvSmVRV3pjYXhFVVZwenZacFF6Z05qTjVrN3NoV2JsZTM3RXVPS0NT?= =?utf-8?B?WmZSditpaGozYVNQM1ByUVdDM1hBcWRweG9JZ0RCMmpJc2pQWkVYdUVac2ZJ?= =?utf-8?B?eS9kUm1tZmJNQzBZUXhJT0RLa1J1ZzV2TFlsYUxFM1JIMVdrT3ZhT3g3TFB1?= =?utf-8?B?cWpwZ1RteHhKVkhpdkVKdlUrZGNoYjdVS3oxSzJuNVRJbEVxdHpTVm54WjBx?= =?utf-8?B?VVlid3VHMnlEd3B4ZVV5NGhLdVMvclBpeXFoL3NjM0VxeVFwblFrZSt3Tzd3?= =?utf-8?B?TmNCSzNzVElQVnc3NXJNd1lHb1FsZlpJaFQ3QTBLajJMQjlCZis3WTNHZjZP?= =?utf-8?B?eThYUHhRYUdEdkgxVlp4WTNuMzlRMzRJS1lhOWh3M2VuN1MvUDJuRUJqcWhr?= =?utf-8?B?aUpFWlZ4L0JrWHVVWVNsNW5WMGhydUxaWDM5NnR0amd5eDU1NzV4QytTVEpK?= =?utf-8?B?R29rSTZ2alJxemxLelUvNzhGMU5ReVlwQVllZWxJS3RvSWdmY1JMYjh4cStW?= =?utf-8?B?WFBBbDNKTmYvazNkbS9WQTNWaHFQTm00Z1p2OHpWVlhMSTYveVBHeklMSGsy?= =?utf-8?B?NEFET04vTXhNaUpyUWwzempGdXRETEJIMkRlNE5sbks5Vkt6cUJoc3ZONmxu?= =?utf-8?B?NG1sTHdQdXZRN2YvTmxlbjI3TzZoeHF4bWpRdGUyOWZUSFdsdVZwRzhSdHJY?= =?utf-8?B?Tk1SaG1udU5SVzBkZDZNVEt6RU5ZUUpPV3l3MjhkTE1STmpyZThOck5kNFIy?= =?utf-8?B?SllZTzNWQjNITGpMcTJHeFA3bjJTdjBtWXk2NjNzcXVRRStzTTFnNHRUNXJh?= =?utf-8?B?NnNKd1FJTU1WeW9VNFNuODVUai9ubE9lbmdnOGZOSVZlNUNTcWVlVzg4UVpG?= =?utf-8?B?MnpEREQzb05BbXkzWmVrbTFPMlMrc1FhaEU4T0k4VGF5aGF0dmN2T3EyMHhq?= =?utf-8?Q?dXSlic?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2700; 6:DUq20mhPPnZpO4WmFfb+B5sF63CVC50jHi7GQ46JRAio7tnGt2JBNYezFZDe/Whyk4Ucg1VuHF0IMPo8Iy08bHg818wJJyi/ltFyM1aivBUCay2Q3IqmSFZyX2UCFlhUo74f6lFPsK76JPEjVsbyOE/jJNLpr1t41tUEa9wJ7CJdTBeuVz5YmBExRXmShKreTX/6VgWbBmkgsiStu1aHbD7olAVx6kLNad7JK1D8XJjls1m/ZrY4cqxngKIhNNrCYBZTpOl3s+ETLOllg+q/Oc/4T/XKJHGRxgObOGg6j6zjxUCSAnQJ+DtZdmd3u9UUJxQ4eXkn4+YBI+XPlvSzkQ==; 5:7+TRnkVxKwjaCYxbdMMbPk33Zt2lISHhltP5eJA3qQfYRsmyjzvaghHa0/SZzacTmZ3TS0MUyt2g10eyLYaDREHAC67rl7uBZHtXGnSPCL1DdLpKXaMI6oj3RxvK2QxacCGpwmCL9yFxlhfnhKpz7A==; 24:Bo1B6v1Aw0PAh4w8UvRJkjE8hPePsavOGu/Xt+OCGpj3+GZ2DxrGBJ+UT7bBYAOoW7jaTJ/+MsVXiGdfrHC3EAfr4KYhQU5v1vJSPIxU1zk=; 7:8F0GCUy8A3sDd+5KLDuQphJn189sygha46qgW/78JDPQrZxR9wtXmtMXTtT8/4XQ0nc+NK/lMrK1qjeqk8zt1Xf+jRbk/rTmEbNCkAt1qxnfciWjimlnxtNo137sYgCAWBMrHELzIJAjjVxwCPPILHvzjG/f3HkwwX16gD7Tf8rSDsP/gauwe252y9C2xu80RzaUvo0sVXaC5dJWpk2fTiHm9TyO0ePOhVfLXTYKl0U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2017 11:40:32.5821 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2700 Subject: Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 11:40:34 -0000 On Thursday 21 September 2017 06:29 PM, Shreyansh Jain wrote: > Hello Ferruh, > > Apologies for delay in response for these, I am already working to get > the next version based on your comments. Meanwhile, some comments inline... > > On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:21 PM, Shreyansh Jain wrote: >>> Signed-off-by: Hemant Agrawal >>> Signed-off-by: Shreyansh Jain >> >> <...> [...] >> >>> +    } >>> + >>> +    /* Populate ethdev structure */ >>>       eth_dev->dev_ops = &dpaa_devops; >>> +    eth_dev->rx_pkt_burst = dpaa_eth_queue_rx; >>> +    eth_dev->tx_pkt_burst = dpaa_eth_tx_drop_all; >>> + >>> +    /* Allocate memory for storing MAC addresses */ >>> +    eth_dev->data->mac_addrs = rte_zmalloc("mac_addr", >>> +        ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER, 0); >>> +    if (eth_dev->data->mac_addrs == NULL) { >>> +        DPAA_PMD_ERR("Failed to allocate %d bytes needed to " >>> +                        "store MAC addresses", >>> +                ETHER_ADDR_LEN * DPAA_MAX_MAC_FILTER); >> >> free dpaa_intf->rx_queues, tx_queues ? > > yes, certainly an issue. I will fix it. I have fixed this in v5. > >> >>> +        return -ENOMEM; >>> +    } >>> + >>> +    /* copy the primary mac address */ >>> +    memcpy(eth_dev->data->mac_addrs[0].addr_bytes, >>> +        fman_intf->mac_addr.addr_bytes, >>> +        ETHER_ADDR_LEN); >> >> Instead can use ether_addr_copy() instead. > > :) Yes, I can. Unfortunately, I forgot to fix this in v5. If you want, I can send a small patch against this. Sending a v6 because of this would be overkill. But, this is definitely a valid comment. Sorry. > >> >> <...> >> > >