From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7F2BAA052A;
	Wed, 27 Jan 2021 18:30:27 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6A97C140FC0;
	Wed, 27 Jan 2021 18:30:27 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by mails.dpdk.org (Postfix) with ESMTP id C0108140FB4
 for <dev@dpdk.org>; Wed, 27 Jan 2021 18:30:25 +0100 (CET)
IronPort-SDR: zVtRacrVNTNJ1K5286XpaJspyJwYZKIJwawjcK9t2focfMvUfcgscu2CIjN1QeKFiR5cOn9lEN
 lGWZSnaRp6ig==
X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="176593666"
X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="176593666"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Jan 2021 09:30:24 -0800
IronPort-SDR: Pd0Ouf5Bzl5monpF8v3jH0NgETjNy6c9A+WhWi75HXN6md2XXHWb925m6s7vyHeY8ZNKAMSRlu
 S5FSGbX/bB0Q==
X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="430175536"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.215])
 ([10.213.208.215])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 27 Jan 2021 09:30:23 -0800
To: Andrew Boyer <aboyer@pensando.io>, dev@dpdk.org
Cc: Alfredo Cardigliano <cardigliano@ntop.org>, Ray Kinsella <mdr@ashroe.eu>, 
 Thomas Monjalon <thomas@monjalon.net>
References: <20210118203508.1332-1-aboyer@pensando.io>
 <20210118203508.1332-7-aboyer@pensando.io>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a90e9d91-7c68-e712-5ce2-c10ddac917ea@intel.com>
Date: Wed, 27 Jan 2021 17:30:19 +0000
MIME-Version: 1.0
In-Reply-To: <20210118203508.1332-7-aboyer@pensando.io>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version
 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/18/2021 8:35 PM, Andrew Boyer wrote:
> The ionic PMD only supports TX queue version 1 or greater.
> Version 1 introduced a new SGL format with support for more
> fragments per descriptor.
> 
> Signed-off-by: Andrew Boyer <aboyer@pensando.io>

<...>

> @@ -925,6 +925,11 @@ ionic_lif_alloc(struct ionic_lif *lif)
>   
>   	ionic_lif_queue_identify(lif);
>   
> +	if (lif->qtype_info[IONIC_QTYPE_TXQ].version < 1) {
> +		IONIC_PRINT(ERR, "FW too old, please upgrade");
> +		return -ENXIO;
> +	}
> +

Will this affect the end users, if they were using old FW?

Can you please document this new limitation in the diriver documentation and in 
the release notes?