From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E79D2A034E; Fri, 4 Mar 2022 17:31:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C4A2427CA; Fri, 4 Mar 2022 17:31:09 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 43983427A9; Fri, 4 Mar 2022 17:31:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646411467; x=1677947467; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=g036IN82Hya3YY2ophy1XeLIiRIrpiuJ2QlZJmcv1vo=; b=Tzp3SbeYDcyUXCZ1zEmauSrniwjNqprxq9/jJh6ReXIA/LpTOigsIhzn mGa9iKnr/tVxTbynVQvBOcsKyMyLz4+Q8K6vZNv/2IAtMuk7xno60OVr6 ohgVaUAV+F1/xI5xpGboDgFoXx+WaB/moH7/o8nUQSy8cx6Iewe96OOVh jPyxZvfF023vvk4/KjemndeQcCORgRWRKoe4IH6W0Lu7QLAnAu9Bi7fl3 4uBQ4C1BVOV1EWeenjUZtDDGTlI3knrdZI/numOovhrGgsRwrfOqv5OVO MDt1e2ySoIJ/T3NYUber2sOq124Mzsd8Z778tYno8PfRpaOLaCcNxZiet w==; X-IronPort-AV: E=McAfee;i="6200,9189,10276"; a="252836314" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="252836314" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 08:30:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="552277475" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 04 Mar 2022 08:30:54 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:30:53 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 08:30:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 08:30:53 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 08:30:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kcCPPJ7WYhZ32ea3RRnTqMR7X2JyPf4Yy+3CT6dVKTKxwMogYD21WQLj9zNR31nsWeAR7Vm21NRa769K9pZnOdr8H5vYzJirVcvoKgM0mLhNuEw1EXqZKr4IXInzjbbaeKDloqSoTupyEddW5Si8Hr7vqVAwvyxZSpJagLz1ufOKFqxi5n+CXTny7XIlAJltyFcTLnF+5z1kq/OPhGLOHqJFCTe3284q1DKP/Eack/oIvplqElFHUaUhRc1+IwmbN1KOaXChFSbBDJuB/PhmpUKfI3rvfnnAsZkCiwnZ4qLNeBGZYvwBC+RN/ra0bTsCSF/d/yQb0zYVB5Onsa39TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GfAFbD0gup9bB/8HKRVpBlEZjQA4mf7KtFS2VKBs/EI=; b=hJO4lYOWwLwJY+cuqmUgWFguHFArdFn6jxvqX4Rk9BY0nojpIJJCc7dSpSolSusM8IfGRDNLBLwRcPIMUwBHxDhay1uhlB33g3fzeY9HTR5IntoCuf/uzTuPV9FYyeuECxTCNycsKZ+g4uv/OwTfLFzyY4y9zU8uVtRy5q66hu5z5P9CGQHwg6DBwL2a12n0Oa8GmrUmVzhgs/cdRvUGogd8jhb3r1F1kAC3P8v28pLEkrviQDbD7DEztPPdfeM58gpbs1YS1bc4if77yG/TiKtZEcpAQJDMwt+MYBdf/0I1ehWX9rTWS5ESq9u4gFN9EPyfqHKja4pDjlGZfJ0lTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MW3PR11MB4522.namprd11.prod.outlook.com (2603:10b6:303:2d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 16:30:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 16:30:50 +0000 Message-ID: Date: Fri, 4 Mar 2022 16:30:44 +0000 Content-Language: en-US To: Harold Huang , , Ophir Munk , Raslan Darawsheh CC: , Keith Wiles References: <20220228082724.1646930-1-baymaxhuang@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH] net/tap: do not include l2 header in gso size when compared with mtu X-User: ferruhy In-Reply-To: <20220228082724.1646930-1-baymaxhuang@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR05CA0007.eurprd05.prod.outlook.com (2603:10a6:10:1da::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad661eb1-47a4-4a0e-8806-08d9fdfc583f X-MS-TrafficTypeDiagnostic: MW3PR11MB4522:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BTr21gj3iSPx1J4SldMbKLTen/MLUbjFyQdytg8Q1pyFaIggGlGSHEMKeNpGtV01Y+lToL4jSWRvzeZlk5xhBxgX+tihOsdjV/CYNFCl2CgofjYHbrPjYAV4mK2EHk8tie9uCb0iS2gOa3DTFFO/RQ4KPztYocREJMYQfUeaf5L7nt9cRfIJ1VYioll8AHgbaF9Ztqj+6ZeaKVqMhLF53MEKrQqtG8DK/wo+g8AqSRkymLh8KjI5ffUgcfHPmTrOXqxoRvl1+Qtd86hkSHxaRfwR+axEHPpEOw7W8YbC632b0cnQXFpv/sTOGUXzg15XNMzZ4/4no4BLc82beKAmCaNJidy559CILb2FggH4bu9L27KSGuaLUKEaDlO9dFSZ1ODWZMBTfYUTHGpgC2nevseiUqUhZKZfBpzvtmVW2/5qWhIHn832aDyXxQbvIuZVa79skrlKHZl/GqpFAHUczhHGfchu0yVJrM2ZLGrbNKWVCvBWzrjHthWL21zthR7hiljwHsvYj69VuGFyRCbkkOSM7iz2PkF0UZqrp7H9jwJbFEctl+QnQWt+DL9ZnvSf95zugbSthmxOi1Py2k00dhC6H1R1md8VqIiXJbl/06S0rn/+3+PDBsdnsraRsISrj/0hOkc7NuFQqcpjn4IJ5Kd36Ccv5+ECff9gAWuF0NvOOnHuZQvN/aMI9C//yBn09k7u/49cemDSpEhcyWZc9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(316002)(26005)(6486002)(6666004)(53546011)(6506007)(4326008)(66556008)(8676002)(6512007)(44832011)(66946007)(66476007)(2906002)(8936002)(38100700002)(31686004)(36756003)(31696002)(86362001)(2616005)(107886003)(82960400001)(83380400001)(508600001)(110136005)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnI4RS94b1cvcmpXNXo0cHlXNFNoWTFNQ1pudlpBaityTWFyU0kyOW81TmhW?= =?utf-8?B?MTRPeXBXSjFWYlBBbzlUTnEzVDVDYkUzdjFRS2xkb3U4cDVRUHZPZ0hPNnNv?= =?utf-8?B?RmpKWEFrdGFrMUM5bFAvSVVDdkFyTXJRREtPVGl5QTZZM00rdWl0RlRndXZD?= =?utf-8?B?R1ZvcFFQb0lNOFU4K2dpMEF6bkFxOHA5WHFJYUovMkg2eFRHajJXU2pWcEZZ?= =?utf-8?B?NWVITVFBblpyUnN0RWQ3eGJ3eEQvMDNTeUM4OVZoSklBWFZYNmdGY00wNHdF?= =?utf-8?B?U3dhd0ZzcXZHR1pGNGVkYWFpYnRiRGVjK1ZuaUFhNWZ0dnVvV3ZJK3dtNXcw?= =?utf-8?B?Wk52anBVRW0rOGtsdmxEMDBlUC8zT2wwdDlQSEtRM1ZsWWo5SUxaNVg1RW8v?= =?utf-8?B?Y2FIZksvVEZ0QWV3b0Y2cnRTbkt2ZTJjaDZ3TkZFdHloaEc5U05mYjIySXFJ?= =?utf-8?B?bkNoTWdrdGpMa1Y3V20rZkFzdHB5cGtSYzZpb05JczhwL2JWajQrOWhQaTll?= =?utf-8?B?blhQa0w3MEM4b2JwdmtEbXRNYXBxdTFaMVlNdFVEV3crVmJYWHdNNkV3dTVG?= =?utf-8?B?MmpPQmxRUkJHYmh5eEx6U2tDd0hJeGYyWU1HZzBxWE82dGdBMjZxbFJGRUVH?= =?utf-8?B?WFpGeEszd2ZIbk5IWUpzYUhLeDBUb1FSWkRJRzJqeFptNlRYbHRNcnJlcXpF?= =?utf-8?B?WnFEQkszYjZGZ095dzZyc1dGbkhxdStlNFJDWWYrdUcvWDNLaGxROE1WYWNm?= =?utf-8?B?aHRBTnVZVmpzNWhpMlgwZS9YaUNXanhaOXh4NlRRSGIvUnlRaEZBcytKeEpO?= =?utf-8?B?UmRSbmVUYklYOS8vZlJwWGZQUnpxYVBhdzhpY211VUVEeEsrQXN3aFVtTTNM?= =?utf-8?B?bS9vcFp4WHJsRi9OZlltcFByQWVTNzJxSjcyZzhManF1dVZWeGEvY3NrcExa?= =?utf-8?B?dmZQRS9PUnhCU1FydUV6amNOM2xoaHhzckNVdzBIY1FZYWFpMUxrK1ZvaXZk?= =?utf-8?B?MmZPcGdzNUFNVmRUdkdyRUZZNmtnbUZLVE4yRDcxN2REc3FHWEtlYUtCaXEw?= =?utf-8?B?MlhYbTFVaFcwVFlDVS9GU0l0ajBrTGs3b2FwckxQNHc2cyt6Z3lQRkNJWkxY?= =?utf-8?B?QVVJSkJhZVZCU00vQWhRbzExOG85Ni9ISzRmRU5KMUM3SjhhdkZPNlV2VHg4?= =?utf-8?B?VWh2M2FUNi92dVlHUWx5aWIvczltNmdUb0VDYTh1Y3JTOXY3VFl0K20xd25z?= =?utf-8?B?VmhkWUhQVEd1eGUrbU1QUzdDVld4dWZBOTU5SFBGVjdka2VrOHVBbk9yWTZH?= =?utf-8?B?Mm1BdUppaG5Jb1E1UTBudWlYYkhmdEYrVXJ6VlBEVXFVdm53TllDUGh3VVNQ?= =?utf-8?B?NTRCRGZManFlb1l2Mm02L01Ja0hScVdFalNBdHhwMVhMMStNcjd2ZXRPVi9p?= =?utf-8?B?eWJIVWlCMGRTQmdVSXJuTTlUQTIzRXpGcHpzckMwWEovMy9CYng4MlZqMGhv?= =?utf-8?B?alRGU1NqRHdGeEdQd0FYcHV0c2xVTGNPQTkxZW90WUVTN052SjJTakc2MG1x?= =?utf-8?B?bTA2ZHIwNkVrdGdaalZwakdpdUNFZDQ2ald5Slc2YzRqNUU3ZXlmU0w5dG5a?= =?utf-8?B?NUx2UERLMENiZFZUTDByTWo5YVkyN2w2d1l6NWlKOTVDcjM4L01zakxKT2FF?= =?utf-8?B?aGIvTlRMS2U2c0E4YzEvaTV5MTRjaTNpTStmUG9ocWZseXFyR2l6a1FmV3ky?= =?utf-8?B?VU1JQ01jZWx1aVJxL1hEN1JIL3VnL1JFTTNSa2tiSWVJY2JJYm9ydW5VeFRB?= =?utf-8?B?QjRCSTNCYStPdjY1UHlLdWFaVWVxdFUyMHBIZDhzWEV3OHZpNjdhUCtNTHdZ?= =?utf-8?B?QVlsenR1blByVHJWVWJSUExkMnBaNHlCS3cvYnZxb0I4UDlZREJIUlhrb0lz?= =?utf-8?B?RlMzSU5FTUFXU1JpTElhd0ZualJSdXhWNUs5bmZ1V1BPYUgyaUNWbUtXNWR0?= =?utf-8?B?dXE4RUpJMjdkeVh5ekRpS3lWbi9pNElkYk5LT2ljMmVMK3d1RS9zb1dtRWor?= =?utf-8?B?Vkg4cm9tWElxcjZFcGlaVzd0ekFXVEd3dFRRWGk2N0FPaXMyZ0VzNUVjNkNG?= =?utf-8?B?V0hBZW5qRFJaWVI3Q3djeE0zam0wc2NiYmQwVThZeE5rWTBiWVliR3ZUbDh5?= =?utf-8?Q?fiDPdveIGPayt/vZohCMqnk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad661eb1-47a4-4a0e-8806-08d9fdfc583f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:30:50.6748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZS2bP4Sfe7fNMILC3utHpKcHMdTBiQZ8GQMqRz8xxxJeSo4gjddIoiB9cNFuKfcjstp3A/O8oMzIeKC8PdWwNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4522 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2022 8:27 AM, Harold Huang wrote: > The gso size is calculated with all of the headers and payload. As a > result, the l2 header should not be included when comparing gso size > with mtu. > > Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") > Cc: stable@dpdk.org > Signed-off-by: Harold Huang > --- > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index f1b48cae82..2b561d232c 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -731,7 +731,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > mbuf_in->l4_len; > tso_segsz = mbuf_in->tso_segsz + hdrs_len; > if (unlikely(tso_segsz == hdrs_len) || > - tso_segsz > *txq->mtu) { > + tso_segsz > *txq->mtu + mbuf_in->l2_len) { > txq->stats.errs++; > break; > } update emails for Ophir & Raslan. Hi Ophir, since original code is from you can you please help on review?