From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A52A0C4C; Tue, 28 Sep 2021 15:01:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49BA2410DB; Tue, 28 Sep 2021 15:01:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D0279410D7 for ; Tue, 28 Sep 2021 15:01:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="288349886" X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="288349886" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 06:01:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="518990361" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 28 Sep 2021 06:01:16 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 06:01:14 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 06:01:14 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 06:01:14 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 06:01:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GygyUNebKMkwuItoWF5g+zGWsGn4/od/dFkab+IMcXj5bN3z97uebnGJLxdgNg4x529DqJ8G2A19wRVwjGK16XTzwnOq8VswnISmABozJb77kfblcH84m1VoblN59LsdRAs37eoOoERSlZLggF1Gwh0pc57vkh4MtxHTdSYAmt1Dr8iPbLpTNPj5FEngqTTWPEWCyte6BTW4Bn15EiwRy02PiDapJGA/7I8IHAwHTPz7U4xF5XoubVKFmFctCK4f0HZVmizMnYG89MRhLHb48eHX7OlyIy6NtJ9W6oc6hQSiOxFBfRVCXGJCEkriFX3n84mEIFUHONRUxFqq0rdctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k9zDgCV0+q1pT1XKEUWzxWy6UQWHTYSjS0fR/QKPvdA=; b=Qh+O8xoKHWP4lgbDgMLfQLmyJe9gz9s7pCdxwLbVyZ8RNKEVjwVxo6R05kF6aZqnbyxTbgzHoBSQXy55jwmGAQ1PgSRzvnKYd42pHdJRJuw2RZYBVjayAU9i9nuVzwV3tN9zhaILMdRyli/0NKaryEO1VRLOjxskkOTjwtkVMoaMMxa90t/pkK1bEPeaHKPDAcoRnNm145Qyd/Xs5xdd4zjAiUAwQ90rLFpmNEYOOJkRlf2ORiAjNaF8AWnWkumeZVycIJX81C/1hv4yJ7tUjC3Wn96GiMsGmc50/BDS9c2QlxHj8a1aOT7cuTcjnHj3yE1KQ+5zz+8pAcO7e2nI0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k9zDgCV0+q1pT1XKEUWzxWy6UQWHTYSjS0fR/QKPvdA=; b=NvomrelqvrTsmcUbBqdQDgPPTGzMMvK/CdAO/GHGC7+K5ny7ROB20v8/tIk1yIjejaomCW7Q1IeG1R4DE7gPw8Y3YINXYnAb8q81J4Qbft5HHE556ag1+eju5Y3xcxqflKnVAEe9PftrSpDHPIU32cE8FY3HsGkle17zNSurvwQ= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4998.namprd11.prod.outlook.com (2603:10b6:510:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Tue, 28 Sep 2021 13:01:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 13:01:12 +0000 To: Tudor Cornea CC: , , , , References: <1631553801-75072-1-git-send-email-tudor.cornea@gmail.com> <1632420804-398-1-git-send-email-tudor.cornea@gmail.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 28 Sep 2021 14:01:06 +0100 In-Reply-To: <1632420804-398-1-git-send-email-tudor.cornea@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0402CA0010.eurprd04.prod.outlook.com (2603:10a6:4:91::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0402CA0010.eurprd04.prod.outlook.com (2603:10a6:4:91::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Tue, 28 Sep 2021 13:01:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73f08eea-aacc-4dd1-2028-08d982800c48 X-MS-TrafficTypeDiagnostic: PH0PR11MB4998: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Wf9oXy7VhJz/UBxMykab80p6guN9Ux7hLPMHgwii1ozM7gFH5K4yzpFu66+9RSo4q9Xi+yRx1U+W5hFZh5kzvjun7RG/MeLU6v3oDO5r60B0Ote8vAOzaygdXddfU3LvVZiqNqvzsuT0esPBTjxWDL1rSfAEhR49imrKHUO+7N7+Jylcot+h7RGWtlfc20KycGLzGNob9B5oo1Hs3GOSgEd5ao1guzdnkrso0d7GqRci6xsvFRFI7z8o/QVRdgePKwrfheMF9FaW0HKPKRlbNwkQoysb8jg9frBxEW/QnAnbNtvD1pcG5BUUy3L1/0YeoTE4Y7UOFDxumTtghpV5xGsr0ZGsbPwAiczDpElam2Cy4Xpepd/Bvv3RoSAm0XhJB7MJ4RXzbeAIOY3HXqUqeFApy492tkXEJSP7XR30yKVJt5hoIcXKRq0gXLm/j2j+N2cAz5vNbYaOR9RyODNEVeuvATOvOSGajSY/8enpMgH6kJfFP9Lz8yceo5ciIyLzr2tLP1feQK6yVUrcfxJcbpPKBEAhlx7ZLShzpLzgeFT2gaD/FIXRht9ji9MrsnixQN3Qx1sMJ2syaiP4qN4Mma0OQaIlNHwIz9CqCRtICJZJJOuGi/7c4ZO+dWelZXtTKVl0E4TRt88YQK9X5EcUeQFQax1yZlQt9x/A/KaieKCNPmkk5VkVQVSHsJtHJ6axylcZ0sSkRUk09dWFSErcwmF5rwfayLDmM5jBk+Lq2FKHAPHCeAfczdFbYfTLtLYmkW/SV/nnnAGldl9KgjCoQ7r3ABOii4P5HTBdWQIJYo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66556008)(6486002)(2616005)(316002)(6666004)(508600001)(956004)(31686004)(44832011)(2906002)(966005)(16576012)(38100700002)(66946007)(66476007)(86362001)(31696002)(4326008)(83380400001)(8676002)(5660300002)(6916009)(26005)(8936002)(36756003)(53546011)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGY0U1huSWd2TGRHcjZyY0tEOWtTRzZ3MUVNdEw2aytvd1Nldm9WbDVEZlB0?= =?utf-8?B?NUhlYzd5dTlmc3FuS0xkd1R0ZWZvL2NIREFSRnluN0llWlpFOGJRTDhEUHpZ?= =?utf-8?B?alFUT3V1bWU5U01YMjF5ZGdhc2tDcWN5Y2dIbjE5aE8zK1JtQjdGNUFRdmdJ?= =?utf-8?B?RTNCbVFWL3JHbzBZV1dhanFwSmc3ZysrWGtBNDMyVUQ3YlA0aE4vdXpqYmw1?= =?utf-8?B?c2FsZUNabW1tVlc5L3I3UU52WDAvaHFkTXJYT3ZmVHQ1eGsvbzVIdFNkYU1R?= =?utf-8?B?MHJ1Zm9IVUh2WjZ2SkVlSTlSS20rN3B1VGNiTE93VUlkVkFXempPcWZxSFRF?= =?utf-8?B?a0N1MmhSZ1ZnV0VsZGoyeE5vWFI4eXhXelB6QWxoS3U4YWpta0tFOWtseE1I?= =?utf-8?B?SGEwUENFa3hsRWVLQXZ4SDY0d1Z0VUl3aHJVV2YyUFRCd29Rdlh3MlFDM1Nq?= =?utf-8?B?ZVFhb1F1T1drQ3NSbHlQaEJURXdsRWw2Z3BuTDRyclV2VU1DekhxTU1EcXpm?= =?utf-8?B?Yk53SFJ4bXFlMGUwQ1RKRytFby9RekVPQXVxaUUwZ3d5M2V6bmpWaW9PUGlC?= =?utf-8?B?Zm44QWxWL0JkelMzNmsvMDM4elhKd3NQMkNNZW15VnhuMmM4Rkg0VmVNalFW?= =?utf-8?B?T0xrMC8yYnhoU2hUTW02TzFHWFhXT3dPQWg2L1BNb0xtWGRKMFRGWXovZFFX?= =?utf-8?B?OURWbjJGRCtEeGFDMmRHVzdTZmNGREVGU1NlRmdacTNyZEJob2hTTWtrZnRF?= =?utf-8?B?RnFPbE9sNE9ZbFpWSlg2bEFlQTRERm4vb3hZTEdGUTQ1ZXZvZ1ZzMlBHRG5l?= =?utf-8?B?TldXR1RneWlHK0M4bkpNSHd6YmsybXV5TWlqRmh3SENVb0d2ZWtmSVNwNmlu?= =?utf-8?B?R1A0UGFKUkgvb3loY1VjMGVrYyt3S0xzbWM4Y28vWW0ySk1sUk1XM2RKMmsz?= =?utf-8?B?THpYaHk1YjVlN2tEUlZlbVcrZk1HSlphTEh3K3pLK3U0RFU1WmNpSFhoRkpr?= =?utf-8?B?MlFKSzZ2RUJIRDFHV2tuVnVBZEJqOG5HdXhyUnRnUHdrWjBqeGpCZW52RExv?= =?utf-8?B?R3BLQU1nUHNrWHBNYldKeUliMXhMaW1GbFdud3RFcUJHaitEK2x4RWNFdEht?= =?utf-8?B?YmxFMktBQVh6NzdFSERlbHAvck9JOEZzWUprU1A5NDhuaEgvU0xNVVVuS3JV?= =?utf-8?B?VHh2YkNWSnQ5dDZTb1RCd3pYa3lFTTRUMS9BSFZrYlgvVjFuY1FvSGVHaXBF?= =?utf-8?B?WVJ5R2ZEdSs3Ky8yVE5WT2tQb2hqVTNMSU9NS1h0UkxpYTBNdW85aGtpMVR0?= =?utf-8?B?d29URldTVm54cEFUaXE4djAra2FXRnd3cHFzQk4xTjNocmJZYkgzbHhDeWVi?= =?utf-8?B?RE5qVGJlaVVWL1ZuYVZCL1RjWUo4ci9FQ1RDc1VTY2c4OVRHUnhVdVJDakQ5?= =?utf-8?B?blMwVUVISkRrZ2xBQnFDZUNLWEFQVjRhOU14ZDhnZlpYdUcyMzJJTjU3SUpZ?= =?utf-8?B?b2tJdWF0MTNJKzZacWlPMHRmTWYwMXh6a2VUcnFFZjBxRFlpaDZkaXhudGRw?= =?utf-8?B?bnJqdzJySWpwdFdnaHB0UzNBdXB0TysxZWRxcVFoUk9mZ2x3VFRWZHFZaENS?= =?utf-8?B?LzVZdkZvdHJNdHNKbHZhcnNRamhON1NZRW12dlNRTWJkWEF2eTJOZnFySUtP?= =?utf-8?B?aFV0dXV3emYxOHJRTlBleEk2RXVBRFRNTVFGMTh3UGZkSTN1T05OVHpuZ0dX?= =?utf-8?Q?Q98miuMmJZITXGfl9acQvRflCc2AKlhU3hOhiwP?= X-MS-Exchange-CrossTenant-Network-Message-Id: 73f08eea-aacc-4dd1-2028-08d982800c48 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 13:01:12.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQtR8GRw33WgFgW4jsjpIuWKVS6kBH+k2uhGk6OkVNJwbB8VscuifDsnalomefg1Uy03zrahCVjEvpGo6LBebA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4998 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/af_packet: remove timestamp from packet status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 7:13 PM, Tudor Cornea wrote: > We should eliminate the timestamp status from the packet > status. This should only matter if timestamping is enabled > on the socket, but we might hit a kernel bug, which is fixed > in newer releases. > > For interfaces of type 'veth', the sent skb is forwarded > to the peer and back into the network stack which timestamps > it on the RX path if timestamping is enabled globally > (which happens if any socket enables timestamping). > > When the skb is destructed, tpacket_destruct_skb() is called > and it calls __packet_set_timestamp() which doesn't check > the flags on the socket and returns the timestamp if it is > set in the skb (and for veth it is, as mentioned above). > > See the following kernel commit for reference [1]: > > net: packetmmap: fix only tx timestamp on request > > The packetmmap tx ring should only return timestamps if requested > via setsockopt PACKET_TIMESTAMP, as documented. This allows > compatibility with non-timestamp aware user-space code which checks > tp_status == TP_STATUS_AVAILABLE; not expecting additional timestamp > flags to be set in tp_status. > > [1] https://www.spinics.net/lists/kernel/msg3959391.html > > Signed-off-by: Mihai Pogonaru > Signed-off-by: Tudor Cornea > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.