From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C931FA2EDB
	for <public@inbox.dpdk.org>; Fri,  6 Sep 2019 13:26:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EB6761F32A;
	Fri,  6 Sep 2019 13:26:06 +0200 (CEST)
Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by dpdk.org (Postfix) with ESMTP id E97B81F323
 for <dev@dpdk.org>; Fri,  6 Sep 2019 13:26:04 +0200 (CEST)
Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59])
 by Forcepoint Email with ESMTP id 22326F81982632E2C978;
 Fri,  6 Sep 2019 19:26:03 +0800 (CST)
Received: from [127.0.0.1] (10.57.115.182) by DGGEMS403-HUB.china.huawei.com
 (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Fri, 6 Sep 2019
 19:25:55 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>
 <1566568031-45991-14-git-send-email-xavier.huwei@huawei.com>
 <c336a8a2-af82-8779-cfea-0629716b2f4b@intel.com>
CC: <linuxarm@huawei.com>, <xavier_huwei@163.com>, <liudongdong3@huawei.com>, 
 <forest.zhouchang@huawei.com>
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Message-ID: <a992e4b7-0b38-206a-9d5a-872e00beb038@huawei.com>
Date: Fri, 6 Sep 2019 19:25:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <c336a8a2-af82-8779-cfea-0629716b2f4b@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.57.115.182]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox of
 hns3 PMD driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh Yigit


On 2019/8/30 23:08, Ferruh Yigit wrote:
> On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
>> This patch adds support for mailbox of hns3 PMD driver, mailbox is
>> used for communication between PF and VF driver.
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> <...>
>
>> @@ -27,6 +27,7 @@
>>  #include <rte_io.h>
>>  
>>  #include "hns3_cmd.h"
>> +#include "hns3_mbx.h"
> Why need to include the new header if .c file is not using from the header? Same
> for other .c files below.
We will fix it in patch V2.
> <...>
>
>> @@ -0,0 +1,337 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018-2019 Hisilicon Limited.
>> + */
>> +
>> +#include <errno.h>
>> +#include <stdbool.h>
>> +#include <stdint.h>
>> +#include <stdio.h>
>> +#include <stdlib.h>
>> +#include <string.h>
>> +#include <sys/queue.h>
>> +#include <inttypes.h>
>> +#include <unistd.h>
>> +#include <rte_byteorder.h>
>> +#include <rte_common.h>
>> +#include <rte_cycles.h>
>> +#include <rte_debug.h>
>> +#include <rte_dev.h>
>> +#include <rte_eal.h>
>> +#include <rte_ether.h>
>> +#include <rte_ethdev_driver.h>
>> +#include <rte_io.h>
>> +#include <rte_spinlock.h>
>> +#include <rte_pci.h>
>> +#include <rte_bus_pci.h>
> Same comment for all .c files in the driver, above inclusion list feels like a
> copy/paste, can you please include only necessary headers?
>
    We will fix it in patch V2.
    Thanks for your suggestion.

    Regards
Xavier

    Regards
Xavier