From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Dhanya Pillai <dhanya.r.pillai@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Ian Stokes <ian.stokes@intel.com>,
"Paul Greenwalt" <paul.greenwalt@intel.com>,
Alice Michael <alice.michael@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v3 02/10] net/ice/base: fix typo in media type check
Date: Mon, 2 Jun 2025 10:44:44 +0200 [thread overview]
Message-ID: <a9aa62aa-d6b9-4215-8ee1-1d99297d487e@intel.com> (raw)
In-Reply-To: <20250527131741.7606-3-dhanya.r.pillai@intel.com>
On 5/27/2025 3:17 PM, Dhanya Pillai wrote:
> From: Paul Greenwalt <paul.greenwalt@intel.com>
>
> Found a typo in original implementation of ice_set_media_type,
> where one of the checks for FIBER checks for C2C media type
> instead of C2M. This results in failure of this check for some
> AOC devices, consequently setting the media type as AUI.
> Bug was found in ethtool.
I don't think mentioning ethtool is necessary here, we can leave that
out of the commit message.
>
> Fixes: e7bd7d54a26b ("net/ice/base: improve PHY media capabilities handling")
> Cc: stable@dpdk.org
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
> ---
--
Thanks,
Anatoly
next prev parent reply other threads:[~2025-06-02 8:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 13:17 [PATCH v3 00/10] Update ice base code Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 01/10] net/ice/base: fix type conversion Dhanya Pillai
2025-05-27 16:54 ` Bruce Richardson
2025-05-27 13:17 ` [PATCH v3 02/10] net/ice/base: fix typo in media type check Dhanya Pillai
2025-06-02 8:44 ` Burakov, Anatoly [this message]
2025-05-27 13:17 ` [PATCH v3 03/10] net/ice/base: fix integer overflow issue Dhanya Pillai
2025-05-27 17:06 ` Bruce Richardson
2025-06-02 8:55 ` Burakov, Anatoly
2025-05-27 13:17 ` [PATCH v3 04/10] net/ice/base: set speculative execution barrier Dhanya Pillai
2025-05-28 13:07 ` Bruce Richardson
2025-05-28 14:59 ` Bruce Richardson
2025-05-28 17:55 ` Pillai, Dhanya R
2025-05-27 13:17 ` [PATCH v3 05/10] net/ice/base: fix typo in desc for dev ID 579F Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 06/10] net/ice/base: ptp minimal refactoring Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 07/10] net/ice/base: support for MAC rule with own filter flags Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 08/10] net/ice/base: configure PHY FEC error in logs for GNRD Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 09/10] net/ice/base: increase reset timeout to 20 seconds Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 10/10] net/ice/base: update version info Dhanya Pillai
2025-05-29 8:29 ` [PATCH v3 00/10] Update ice base code Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9aa62aa-d6b9-4215-8ee1-1d99297d487e@intel.com \
--to=anatoly.burakov@intel.com \
--cc=alice.michael@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dhanya.r.pillai@intel.com \
--cc=ian.stokes@intel.com \
--cc=paul.greenwalt@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).