From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Bing Zhao <bingz@mellanox.com>,
viacheslavo@mellanox.com, matan@mellanox.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix the compatibility with MISC4
Date: Tue, 28 Jul 2020 09:15:11 +0200 [thread overview]
Message-ID: <a9aad9dd-7663-b1e2-97c3-d4186ac15986@redhat.com> (raw)
In-Reply-To: <1595319220-173871-1-git-send-email-bingz@mellanox.com>
On 7/21/20 10:13 AM, Bing Zhao wrote:
> When dynamic flex parser feature is introduced, the support for misc
> parameters 4 of flow table entry (FTE) match set is needed. The
> structure of "mlx5_ifc_fte_match_param_bits" is extended with
> "mlx5_ifc_fte_match_set_misc4_bits" at the end of it. The total size
> of the FTE match set will be changed into 384 bytes from 320 bytes.
> Low level user space driver (rdma-core) will have the validation of
> the length of FTE match set. In the old release that no MISC4
> supported in the rdma-core, and this will break the backward
> compatibility, even if the MISC4 is not used in most cases, like
> in vDPA driver.
> In order not to break the compatibility old rdma-core, the length
> adjustment needs to be done. In mlx5 vDPA driver, the lengths of
> the matcher and value are both set to 320 without MISC4. There is
> no need to change the structure definition, all bytes of the MISC4
> will be discarded if it is not needed. Since the MISC4 parameter
> is aligned with a 64B boundary and so does the whole FTE match set
> parameter, there is no need to take any padding and alignment into
> consideration when calculating the size.
>
> Fixes: 32132fb8517c ("net/mlx5: add flow translation of eCPRI header")
>
> Signed-off-by: Bing Zhao <bingz@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_steer.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-07-28 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 8:13 Bing Zhao
2020-07-28 7:15 ` Maxime Coquelin [this message]
2020-07-28 11:11 ` Bing Zhao
2020-07-28 15:25 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9aad9dd-7663-b1e2-97c3-d4186ac15986@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bingz@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).