From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0051.outbound.protection.outlook.com [104.47.1.51]) by dpdk.org (Postfix) with ESMTP id C3AAC2BEB for ; Mon, 17 Sep 2018 12:34:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iChTMiETStVjUmR5WxCdo/w3P8Z8rPPJSmQln5mlugg=; b=QJeTjDUY3klgBsv3h0sprIERo9Dgx1tYOqUDJ7zlvqoqxtaIJQHUTfw1towv7P9tK1HbLCJr6T2ZtWNSJuvErPeV+T4hfaRyfiG1dzKnDRoPANgJVxsC3MU3gk9++imYYuP+zceYdcmJ8szcdidVUHHqCIt30p35qrM88WbGJpw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by AM6PR04MB4888.eurprd04.prod.outlook.com (2603:10a6:20b:6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 10:34:34 +0000 To: "Joseph, Anoob" , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-4-git-send-email-ajoseph@caviumnetworks.com> <5d7c6f9e-5865-a356-e1c2-5a85908055a0@caviumnetworks.com> From: Akhil Goyal Message-ID: Date: Mon, 17 Sep 2018 16:04:19 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5d7c6f9e-5865-a356-e1c2-5a85908055a0@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: PN1PR0101CA0015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::25) To AM6PR04MB4888.eurprd04.prod.outlook.com (2603:10a6:20b:6::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3df7a2f7-9a12-414f-310d-08d61c892a6a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4888; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4888; 3:kAtS+yeJqamzPeldRSR06op5i5NWSevnIie5jhkHTWqmtomWEghNjYQnOtBa/TDziJBchC8UTcwZnUz4xWS6VbGvCXrZCTfEyldDs1Gi7SMKhgLjKwtc8H3Ej3XSc6dzza0WOzWUs9dEC5UDINSoHavpRA+RTLEJSc1EN8TKL2EFaT4U7hF4IRwgu4WAbipTBNtMPt885DpQWjzOyx3fHAn3gKBDiailH072YDvI2pYJJfpb4GFM1a/LGmCcvcTm; 25:lB5mhDssb+y1+ndvwnevn6gLakvW75iPAKxY0Ov4ZXzdqvGS/8R1xkLO0VCDjAv0089edgFgra5eXh67PmjlPRokQw00sI3x1pFhccdQ2E3g88HIGD6aMubPkGMePuXeqtJos3YSM26SQdNEW5rWggPQXn+0XL/eY9jHVXXs/m+DcuI8MkJoMePZxfFKjr/pGIu/Wdr+Vgjhj1rmna7WrKr41vw0iJjeY7imjEtvknSilHiRCvZtZrPEb1LiGI5TITYcrP8adJZts3kQNnv2bGqj0+FOPeNXGjB1VS3tWDtfBb8TKMKhwHxpxLQxqwOKKF0A22npfk1YA7Idtyc1aQ==; 31:l/z4jxyjW58IPWseO0ztS2i2gRxC6x9oEaXyunYA0TA4p4Z99F2i/8W8Ml6fGOoTjZGKllow/N4Gulm8jGO8n5cU/ofim9SiOCIhVd7HViqSRDmGAdPbSRlvdGnatNhVrQzp9BF8+Bv+fL5TObbOKrtcutEcm80dUtYmHK5kAbZfY6h9J9r8BbM6dFycH+41U/Z5X4r5t31+FcwQ3mIw0zMpxCNKpUr9lL86vlXHqBg= X-MS-TrafficTypeDiagnostic: AM6PR04MB4888: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4888; 20:/Wkc+VMZBGg9FmgASe2ZOCV8ELEVMHDi3YYAXeKeWAD+JiXC/M9xx6jXtaPfnpo9ppOLebcMldB5kyfSzWp5MLqfP2n1nrpaRXeOuQ8bd60H98qNVjKsNv49ulFSmVMkV/h+zfauDxaXJRYXxsoFe0MLO+zc5QHtfL/66B7RBQ32NwlnsmZ6UzBtacugUPhWWelcyasU9wxkKY6fVKZkjAUfnvkRYYb2GI0Q/5WurMPfLMpfS70SZMMAYMO/6zcMjUikIpH/b51K4NeAE7eAfL422+kN47H8lfcqDGhZROcA3klu7Nqy8Ma6v3nZtGo/rdIuJYe9i8Xof17TU0gkylHIFjhEU3E9XgIO2CijUvzyZ8gMPJUIFlNbDDyLW6ZkjXw9pJfNP8MbsHRhdXaWFWO+1yOlkLoTfuu7vRvToRpQXrkC86e8WQzGgyQ/MMtix6PDxzEljD/JKwgffy2k4sfQCPSJdxLKgyWfy+ibH6R2swbbmlahG38p+nxOe7ZA; 4:JMQd1ZbwresrAcr38+18bFfHgEePw7jc5ytlfYM2NpUZ3+DVaEWKf54NI87HeZj7e8ae4ziJK5ONw3cS2ewZZJ3oooCleCmDGPRP4LOyXkFsBJRYK9c+bJ4aS2JHy3u23W/zn7Lz2U1oWzo1/awWsfZMVFMyR2GY7euvtI8Xj/tbF5TabE5dmf88tNpKJtmaqIeEyqtBGVb1+L60yvSYGs0qUxm5rWGDCfYayzUzGWMV0oyKtsei6qapH/fQf5/ymRPgIFz7Y3u63kI93Qsc5nZEGb9cVbGg08wA6jh2clUYHxg8aUBZeDmS9JzKY3bT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(201708071742011)(7699050); SRVR:AM6PR04MB4888; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4888; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(346002)(376002)(366004)(39860400002)(136003)(189003)(199004)(3260700006)(25786009)(77096007)(446003)(2616005)(11346002)(956004)(105586002)(52116002)(186003)(53936002)(31696002)(6666003)(65826007)(8676002)(67846002)(8936002)(4326008)(68736007)(97736004)(305945005)(386003)(44832011)(16526019)(81166006)(81156014)(486006)(7736002)(26005)(6116002)(3846002)(23676004)(316002)(106356001)(16576012)(58126008)(2486003)(52146003)(31686004)(110136005)(476003)(6246003)(76176011)(54906003)(7416002)(66066001)(65806001)(65956001)(47776003)(64126003)(36756003)(229853002)(2870700001)(478600001)(6486002)(86362001)(2906002)(5660300001)(93886005)(50466002)(5009440100003)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4888; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTZQUjA0TUI0ODg4OzIzOnlmMzNndTFaNWs3S2FHZWNkdGtuNDRjWkkw?= =?utf-8?B?RGNvVS9FcVBtMHA4RXRSM09hSVo1bW0xVWVwdndZQnoxOXFqaGVSVnM4NVNz?= =?utf-8?B?eDlSc05TVHlyMUtjdHFNa1Foc1dJOFpldGV4dktvYzBMSzVnOGczYTVFZUpw?= =?utf-8?B?eVNLd0lrclBha2tKT2Q0eE15b1VoR3pkTXJJcG9paTlnS2xsMEN2dFo2L0Y2?= =?utf-8?B?K2FCSmRKb3BsOGtqYmJLcTFBdGtOb3VnV0sxMGJIWlRkQ0dZNTBQWVd6R0lt?= =?utf-8?B?cWMxalh1NFpUaG1ERFBhdmR6VHJRakpva1FIN3VWVEZEN29vaHN6QW5EV3Bt?= =?utf-8?B?Y2hlL3ZqaU42dkovK3lsUWtXNEFWKys4d1ZuNkRVcjFDd0lvNVdCYU1kSWd1?= =?utf-8?B?dnRhRjB0a1Bkd3JLdTh1QW1KS1FzNllLdUlrajhDbGl2bFZsRTlvLzh0dW9u?= =?utf-8?B?QmxYSC9mUnR0ZmlVM2QrR3BHRXJiK3pqWnhBdGtBaGlsemNicExySEFBckRU?= =?utf-8?B?K3dsbzh2TExxM29JNDFuU0czTlRzWmM4TGFENWgwN3o2RmI0Nmx4WTdzT2sx?= =?utf-8?B?VlcyRHRTV2VSMFl5Zzh2UG15NXEvMXA5OXgxVWhTZ1IxOFgxMW9SekRCUmlt?= =?utf-8?B?OWNxRDZkYWhrem1tRjl3SVBLRnZRMUFOMi90NndHS1VBdmh1QWhGbS9UTVFX?= =?utf-8?B?WWRLZm9lVkRsZnlQOURSVER3VVhxazFOZk13eWNrSHEwWmhHNU0yWWV1aHVv?= =?utf-8?B?d0hha211ZW80WmhWdFlLZmpSQjhTaFJ2cHIwdi91MGtWZUMvN25FTzhIdURv?= =?utf-8?B?THFRS09zUitBV21yVWR2c3FTY3JVR3pDTkZ1OUwrbTMycE1SZmw4VkY3NG1q?= =?utf-8?B?OCtaVThheVVxNDRYcDU2K0dPMkkyVEozanNQcXJjT2ZyV2VRdStwZWxQd3R6?= =?utf-8?B?NHZhMVI3SGtPSWo1QWh3WUhhMUlpOFBMVDZuUEFpcTdTcXhEaCtWa0swbTUy?= =?utf-8?B?N09FZE83MkdHSm5EYWJyT1VDbGd3QXJmMzNDVFVoaGdPY1M1TVNKeTY2d2ta?= =?utf-8?B?MWNrdGJkRCtJWVRCUGxId3EzcUlqR1Y4Njd3Y3JVL2cyTER1YVI2d1Nza1F6?= =?utf-8?B?L2FIQUV4ZzJEcWZWRHV4T1ZMWXZrV3I0blR2SjM3MmVEMCtjOFFmUWFoajFs?= =?utf-8?B?YVVlM0FhVktUY2dEdTkxYVcrd1lmMmJlTmtUaUQ2QlQ5VFhqWFBidGppN0dN?= =?utf-8?B?bnh6Y2Z3M3lTV1hqU1JLVzRsaXh4aWhqUnFMZ3pVN2tQWDI1OStZWHkwZHZH?= =?utf-8?B?Q0xGbG1pNm9IalJYcGR5cmd4TWVxOURDdWVrV0ZqU1pqN09iR0Z5dzBlQzBI?= =?utf-8?B?ZWh6c1dKY1NxTGovV0RWSHNobnZPOU9LYXhkL0QzNFNSTVNBNnJtaTJjU3dy?= =?utf-8?B?aFUxclJEWGhNbGZtbkovMFBuT2ptWjZzY1ZyY1RUL0IvUnkvWmZBVDJuZXpS?= =?utf-8?B?eU00SWxmS1dwWlNlVlQrMWVTaVV5S003bFh2c3g4c2Jkb3ZTL1ppM21yaXRQ?= =?utf-8?B?UExLd0FOWCtjU2ZLeVpnUkdFdFc5SlZPR0pnakFENVlrekZIcytRdVRmcWdx?= =?utf-8?B?NWhiT2pIaFVRdDd1ampYeEZ0RVQzeTAyVmhOZHRWeXRuSW56aHlUYitUaEli?= =?utf-8?B?UFp4UXUwWWN5MEZwS0IxY25BeDhja2xaL3VVM2NXL0VSdWFrZTFqMmUvdzZx?= =?utf-8?B?NEdMREltWWR0V2EvUUE4QmFBMFg0RmdPUUQxOVBjV3NmMXluditBZmtWMUJN?= =?utf-8?B?Rm1YZWdZRGtvdnVRTTJsV21YVEZ1Nm56aitzSFVxamtwUTh6MUlONWQ5UGp5?= =?utf-8?B?cCs4M2tTRk1KRWRTL0VkVHgwcUVUaWljSG5MVjMzclBuNDIvdnl5dkJNR21B?= =?utf-8?B?cXpxNzZqZWJHVG12T0Y0NG8xaWNRbU1zVlZadUluSUhMSkZ5eG11OVRYcjZ4?= =?utf-8?B?MjA1Q0tSdXZFTXhUcnJaT05TVnJOaFZGNUI5NGxzd1YyMk1RZVVVd0xOdHZO?= =?utf-8?B?U0M1dFExVVZqdmNmcWIrV2VNUW1sM0RRZU5NVkJBWTJPQThPS1l6RmdGRWUy?= =?utf-8?Q?gr1UoDiF2zUR2oobLYUc33U=3D?= X-Microsoft-Antispam-Message-Info: 4JdM2X/7w3/LgiLpW25V9YYbF0Bo8NEtX/8NujGooB72p+v4wnPSrboesEJZkqFc1C5IaePaD9e4DVNKqla25iVkRmkhckoS4JF3j002w2rAp0PDIZyaNoZ4PAIL3xISSPIEYgp0hj+0mBqplkEK4hI2VmQ8D5eyKpxfpEXjSyPQM1UIyQKCtxAuVqkSkgD6J30cb14MsAmERd1kTaaDk9FO8omYK+ClGRnSwVf7k66UWoJ83qH7IftQAuERhcKLxaxlX2JoOHaUkP2oroiX4FzwcFdglgR518xvHWXSagOOotBpLxpZj22NqyDtFkkSIfPY7md8mEhBpDU78184JLCCp3yhAjV9hg+RlhrVT6c= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4888; 6:JLbNkLA/jKLOOul9XfPBizE/ra8yB7MCzpX2H1xUrDjxtImfQlagaS8hjefUVDSQrzIrFDI7BpYRC1O+aR4jjAVueW2VuYL+UgQ1S/1TkyCd0TdVo0MH8QHqFCZAp8lGeyA1FnbfJaZwkn/wuS+tZnkdonJG2RS4yvJ1jubDsfyrBQ3hTe94Ixpr+l3XImYx1aTpP2+MH8U6CNOMtb88u35J9xpTwlBKMJa8I3M4d1CEVlb/MN/T07tZ9ZvE12/TcKnALSygq62Ym8b5hB/S+8MiGorvimYkaI80VKhTWWkxPSEVhrPeL9vq3O/ai3eLBaS5F+RYgEHoRLg8Yn7mq9V9oT8iOtQxclGZGjSfkyI4KQSKyjfvyfNs6paE49xfJl/YfdvB4Sm8X8qv26N2DI8Slo4ZC4LYdOAFWt0Gk16CEDZ3qQWM++D0o8spUK0cSnzNQs1JBc+wwsW53215sQ==; 5:zLmWSufwR1CZ/ykVKa+VNZyFJfCB/SiPzYrfRMNdWdFcMQnJ1TbDpO7GBSoz4XjGam0GoVAXKYxRS8qvkvRXe3wwv0de6kO3DaP/Y66KfOY/PSmR39GVD+orcN+W7zsmrXFckBA6VH3wJ8XobgkAGy8E/n6+2EXgj3kRm6bf+po=; 7:SjlwDZCp24pTNnYGjYqhkoV/q+355H8X2MY926UvaZc/MXVUei1XxkU1wmG2EMXPI2f9bROYiNwvaxyy+37O3HZXxqJmIU1h0Ay9FyQ/32Am52TuE8WQEZoSBizm14MeqRNsRCpSVfWf30ZdPykZNuFcCGpw6iXeoxDWeO4oHx6ESNlMMvG56Ft9+p4axmMMNIKCWFmuwEOEcz+/lgrYN17q/HjGYvvMKnQmUcuvhoeTFMq2vJq3mAARQORZwe4l SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 10:34:34.3696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3df7a2f7-9a12-414f-310d-08d61c892a6a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4888 Subject: Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 10:34:38 -0000 >>> +static struct rte_pci_driver otx_cryptodev_pmd = { >>> +             .id_table = pci_id_cpt_table, >>> +             .drv_flags = RTE_PCI_DRV_NEED_MAPPING, >>> +             .probe = otx_cpt_pci_probe, >>> +             .remove = otx_cpt_pci_remove, >>> +}; >> remove extra spaces/ > Between otx_cryptodev_pmd, otx_cryptodev_drv & > RTE_INIT(otx_cpt_init_log)? Which all ones you want removed? It looks there are 2 tabs for the elements of the above structure.. It should be a single tab.