Re: [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 24-Jan-20 3:37 PM, Bruce Richardson wrote:
> While icc builds without the "werror" setting build successfully, there are
> a lot of warnings. To make the output cleaner, and to allow building with
> warnings enabled, we can add a list of warning ids to ignore.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   config/meson.build | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/config/meson.build b/config/meson.build
> index 28a57f56f..6c46767e3 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -197,6 +197,12 @@ if not dpdk_conf.get('RTE_ARCH_64')
>   # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!
>   	warning_flags += '-Wno-pointer-to-int-cast'
>   endif
> +if cc.get_id() == 'intel'
> +	warning_ids = [188, 2203, 2279, 2557, 3179, 3656]

Maybe worth it to add short warning descriptions in comments? e.g.

# 188: unused blah
# 2203: wrong foo

> +	foreach i:warning_ids
> +		warning_flags += '-diag-disable=@0@'.format(i)
> +	endforeach
> +endif
>   foreach arg: warning_flags
>   	if cc.has_argument(arg)
>   		add_project_arguments(arg, language: 'c')
> 


-- 
Thanks,
Anatoly