From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 608BDA0C55; Wed, 13 Oct 2021 23:45:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CA4B410E0; Wed, 13 Oct 2021 23:45:46 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 42D4D40E50 for ; Wed, 13 Oct 2021 23:45:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214702560" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="214702560" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 14:45:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="717498282" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 13 Oct 2021 14:45:42 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 14:45:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 14:45:42 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 14:45:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAoxqF7+cjmPmNoJrqOYMU09C3pS8wzu9jR9Ode1kViugPA0HbGaA4KIJYoThGNaEfCkr9Z3s2sd+SFs2RNcFGUf4hy/pbSz4Cclz16MRNCRQPraktWfETUSYzdwBSlabvju/Bato4aL9l1KtLwvo+Xtmz+fYQ0i9p/vmn9O1LEshB/X9RZ3Z8TyF0F4luDyNoXNXidih8BOhDi5sptAV7n9g9YJRkh9SMVB5FLJG0I0Gz6ZuZOtl8pxqegaFgB0pX9bwejCqTTzx63AfNL473HeAB5L9AEboar+yB/ZMxYECcTk+HdO8vRhC4iWP99nAOsYui+qQP1397uK8+2qQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lowEkOQq8E1dLPwIg0mUGfb1SR0jDRbRGD+HWcITDEg=; b=F5y7J2FJnmDx5obJGBicuuXV30iv49zhp2JWCHq2VrzSkfC0dGzHOzL6ERGuuxKRyHKxESNgg/mk9uLPMXCgqzkm0HhrozPdOPtSehEbDVaVOfrWLfOwwo5kXrhehRtsuNOc8oMzMgc0fFwWAfcblhBw92jXJlUEFn3Rq+cbt3puQt91aVLOYLr/eTZj82YcvJBvIKvnxjiQW60cKFnxpDt9xvUE8h9LbcLh7jDX/sp6Cndg+ZBWkkxOiANqcpPUZpbV/KWisUL1G7dR+cxvrLjKRUmLxwoQI0K1FQ+/ooNEZ37buuALhs6PU6otzHuaVxPA/KC1TCs/e647D1pyZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lowEkOQq8E1dLPwIg0mUGfb1SR0jDRbRGD+HWcITDEg=; b=W4mEqaTru4/LsUjbjTH0pDrN58qN/BXxZ3FPZezGrvo9GN+qaA8oXWSOMHxBA5hZxD3glAB9uFP/u65EoaONG3hcbwVfSrKBlEO0luMQ1GjES6bP567NwOrSWNsc3gCWiRGNUSOZlySeWehWondzPCCgTAufN29K2f26/oD+h74= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4983.namprd11.prod.outlook.com (2603:10b6:510:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 13 Oct 2021 21:45:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 21:45:41 +0000 Message-ID: Date: Wed, 13 Oct 2021 22:45:35 +0100 Content-Language: en-US To: "Singh, Jasvinder" , "Dumitrescu, Cristian" CC: "dev@dpdk.org" References: <20211004172722.3461540-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8PR09CA0009.eurprd09.prod.outlook.com (2603:10a6:10:a0::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR09CA0009.eurprd09.prod.outlook.com (2603:10a6:10:a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.26 via Frontend Transport; Wed, 13 Oct 2021 21:45:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dee44a3a-360e-4d04-e5b6-08d98e92cd5a X-MS-TrafficTypeDiagnostic: PH0PR11MB4983: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: be6kdtqlrWSHnsxNqDWueJ//gJYOj5PW9SCdIdC2vXvvSDK7j7HG4+zWoz+fQE3ets7ZDQfy1b8jQ6j3rvWNaKoa5dvAlNOf8GstsBSABWUwQKT1n9Q+5sXX0Q776R5T66CetJyx5Sbs1c7zHeBTg65IijKtJsEAaTdMRVtBynE/eCCinq5j504QSi/DFDDWIn8ZeXApCk3Th0dz1rh8hmplY20Zn6nYxJITM76twTbBFkq0SLdU0uk/bLmCdiag8AmVrYk/kGuu+dHTlr+WMNDLKMdEZ9keXO/f7P12Yr/APSyV2bnD/9Eg0bC2RqtEfr04GCAGw5POkC8V88D45uzrvaiFPTewZRMG0/dHUwZ3QDp34y++VF4JxCFjezaYpQMGJAf2zUmkuC4hemKZYP+0IkwhOaxwqBY+dsHYDJz7W1Y8SL+bBj/3zF7RPHnnLbpJEYrkWchWTnYWi/UsVT6aHTjyinDcP8WpEKoSIRMioyFL9RJXGQcpHZxoMRQ73PkqestwuIQIv2E158WN9+uLPUpu67W4jki098LbMQuTovS+/GfH4i5wzECDGhqO9DpS1ZZKXrkaYhmlxRT5+UvkmYQanzLcXEczzNKeQ04tnR3DqE+KXakEgWH8CGTzZhS5ZvMjxMLPwzTPfh/s5/HjXP/lIGEt3kuXd7/5k+WF1R3mKD0Opv6dyPPXv4JXDE8f9o18LEaAlKweLepefg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(6666004)(4326008)(66946007)(66476007)(53546011)(8676002)(6636002)(31686004)(186003)(26005)(2906002)(82960400001)(86362001)(2616005)(956004)(5660300002)(6486002)(110136005)(16576012)(44832011)(31696002)(316002)(36756003)(83380400001)(8936002)(508600001)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU1VVjhaOHMwMWhtMlE1aUtUNlJQOVIvWXpJUUNvSzRDcW53ZG1RWGRkQVF1?= =?utf-8?B?eDNEZWEyb3ZjMTR1L0hLRWZBVGlpNUZOK2UyN0dBM0pzdUpCSWZRaUhCTTB3?= =?utf-8?B?QWM5VDRLQkZqOHJTeXkwVldYMmJ2QjhmNmpKdE9oOGJDR3JlS3NYOVhqYkxu?= =?utf-8?B?amFhZ0l3K2FmRk15MlRDY05tdU44NWVBMko1MFBQdEJwbnNZeXQyYjE4UkU5?= =?utf-8?B?aEdsbWN6YlFmdFlRMndFdTZSdUwxbHM5V0pYV3dBZXFuWFRkQmZRc1I2Vkpu?= =?utf-8?B?dFBYWHBMZjRTamtGRXNNMHQrdVBwU3NNK1hlMFJHd1htc2dnMVY5bWpvSEh0?= =?utf-8?B?R2pwQ2tKaTJEWHNWeTQ2cm1KU3JVMExxTEsvbHMzelExUk0zZXA0Yml5SU9Z?= =?utf-8?B?UXpFZU8zeEkvT2JGSi9adTFybDFZRHJLTzFxaURhYXpKTG9JSHk4aE5oMzZm?= =?utf-8?B?SFdSVVZqWDZhbDBmRHBJb0FvVnRIekJmV0M0Y0J2dDVUdDJkUitDdm1uTTBM?= =?utf-8?B?KzlRK05mYXN1ZzN6a25zYitUczZRRysrbGo3WmM2VVZPaFpPQ2F4TnUyMUgz?= =?utf-8?B?MjBJVWNDQkRrVk5yMlJoYUVvVyt2N0NkMWkwMXdVVmpERXkrWkZTMlBBdVRL?= =?utf-8?B?MUpKcHRFVUovVzQ4NWdKYVQ1SlUvRmhVQzI5S2tURjlLZFFQMVRvQWhDQ2Ny?= =?utf-8?B?eXJjRUdRUlpYbDhYSm5weTl2QkFaUkRmYWNZb1N2ZmlKMUJpZjFNM01ZMk00?= =?utf-8?B?a00vaDNtYnJMQVVQbmN4NWlhMk5ZQ3dJaUZGTTBzREtydkRTUEp4dFhaMnMx?= =?utf-8?B?cHhVblVLVmJZU050bUZiM2FFQm03NUpvU21RUUxEbzZ0RXVqTGhwRC8xS0tS?= =?utf-8?B?enF2NkhIQmFiemlFK3hncUEza3Vld2l0bytqOVE3ZWEwV2c4N3NSTWVYWlVm?= =?utf-8?B?NEhSTUFjeERtTVBING5ITjAzVG92RSs4Ull1UkFOSElCVjlZbUpKYVZ2bGpn?= =?utf-8?B?dWQzdWJFKzV1UU8zUW9iK1IwT2g4aXM2R3l4bGJ2STNIMjNKMmtSSWFkZU5r?= =?utf-8?B?cTZVMmFDYitSdnFKUThsZ0x4Z3pqc3FoL3pyMm15dHA3S0cvcUV6NG1tU3Vx?= =?utf-8?B?VzFxeXRoL0JQdy9PL1MvTlhIemZsN2w5ckM3aWRPVk8zRUFxM0lZalFic0Zx?= =?utf-8?B?c1NDVUxKS0orWTVGbVM2dWlYWTc4YU16cjdFSzN6WWlHTE52cUxhc0NwRzNk?= =?utf-8?B?TjVJMDJWMG1qR2NNZVBvWllaTll4Tmx1a1BGZXZqSmJMVm96dklFRjVhRWcx?= =?utf-8?B?OEkvZThEdTRDRFNqYzRxcHVCeU5ueW9aV0tVWmczc2hTUmF2SVNjcW50ZzFU?= =?utf-8?B?WkQxVHZwQVhhNVpWandKcGFMVmdKS1dma01RYjc1ZitVMEtkMXFIdEd6OEJi?= =?utf-8?B?WSt6RzRPc2J2SUdSbXUwZTdMMklmV0loSUFkemp4Wm9McnNGemo4RXZhMTRD?= =?utf-8?B?TXc3a2tEKzlVaDc3VExFeTBkQVpLZWxHK09oNG5JNFRkYUwvZ3ZkTmFhdnFm?= =?utf-8?B?YTY5RWtNZUkrVUt4ekxVRWwzTTV3TWZoNWNHU0QyUC9adm14dnh3Mk4vc2ZX?= =?utf-8?B?TmRNVWpZbHNnVUQwR2JnaENRalhKdmE2eHV2WFFXTmdRN2dMbXVSby9IM3hX?= =?utf-8?B?anpZN3Rkbkd1WWVKbTdTWjhpVUlta0VKY1UrTUxUcWVjWThBVUpYLy85T25I?= =?utf-8?Q?7huaRayo+pafrcvxBGnWeqGyunDo3QXxknfETLB?= X-MS-Exchange-CrossTenant-Network-Message-Id: dee44a3a-360e-4d04-e5b6-08d98e92cd5a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 21:45:41.3949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gtdGSyyW68zy0H+c52inbRUPyxeXmnfe459FBz3rui5muOQYjNdavYPQ3QxtNqwVIBcZzT0S+dukdJ+vpeUzJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/softnic: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 4:54 PM, Singh, Jasvinder wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, October 4, 2021 6:27 PM >> To: Singh, Jasvinder ; Dumitrescu, Cristian >> >> Cc: Yigit, Ferruh ; dev@dpdk.org >> Subject: [PATCH] net/softnic: remove useless address check >> >> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": >> >> ./drivers/net/softnic/rte_eth_softnic_cli.c: >> In function ‘tmgr_hierarchy_default’: >> ./drivers/net/softnic/rte_eth_softnic_cli.c:634:73: >> error: the comparison will always evaluate as ‘true’ for the >> address of ‘tc_valid’ will never be NULL [-Werror=address] >> 634 | (¶ms->shared_shaper_id.tc_valid[0]) ? 1 : 0, >> | ^ >> >> Fixing it by removing useless check. >> >> Signed-off-by: Ferruh Yigit Fixes: 1af2dc5111ce ("net/softnic: add command for default tmgr hierarchy") Fixes: 5eb676d74fc8 ("net/softnic: add config flexibility to TM") Cc: stable@dpdk.org Acked-by: Jasvinder Singh Applied to dpdk-next-net/main, thanks.