From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90D7F43892; Thu, 11 Jan 2024 10:01:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E32640266; Thu, 11 Jan 2024 10:01:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B54040042 for ; Thu, 11 Jan 2024 10:01:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704963685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hYXCyqx8T22OkGJYrCycHTc5ixkPGWXM/UHpDez0ZIE=; b=Zdr4p84T1kQQsXqD37B9HW1nvxvN/kjf2nb6Ay5w6UVPeUyOctcd1WS2tqPcS0rKd+cAu/ xMwahiYpM7mEsEaEUzz8PdG8o8dKAjb0WPFGvIqHsFZj+WEhGD1ddvRcZcmtPUr2jE/gmi EKdpCQoq0y9xbDrCm/mCbIq3C/+cjIg= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-U2mo5wUjNWuNRe0epyWsfA-1; Thu, 11 Jan 2024 04:01:23 -0500 X-MC-Unique: U2mo5wUjNWuNRe0epyWsfA-1 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-7cd48e88c17so1308106241.2 for ; Thu, 11 Jan 2024 01:01:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704963683; x=1705568483; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hYXCyqx8T22OkGJYrCycHTc5ixkPGWXM/UHpDez0ZIE=; b=QWtKS/DmQEvDEaFjgvJsFihe1IRR0+RfhyULLbNFMcwGu2KG/GxmbXmznoY2ekb8J4 aSg+k5w4/66J6zk/w82gHNQv4JYwzTbMYodauRiDY0HBKkfzSH2QhFDjApG1Xwy1SlFJ wo2Y6qC6aYenU4nDiwIDgAn2jJyYjoFDeeMNP1oygNiv/RazTLefHSM6qh5UVwLna7mj 68qwSOLRBh3t/FoxMMCjfKQRLyQ5jj6nnlLXMQFP4/FwZv6i7oPYNCGBDI4sBx9lgUu1 vvuTCxjvAEA26AwCH0Rj5bYibTUB/Xv+9Lb/unPjjBSxfdUM3d0QcDI8jMVZzVOfMuI1 lRuQ== X-Gm-Message-State: AOJu0YxNH/SKm847uKb+gzZFkzNzl+5TIvJ6cVzKX5U91ohKES5GH8i0 NLV3A5cIw5+ZTKuNmLkdEmQ6qxPm4Pr8Iun9nD5gPnb1kcAqnYeb5BWzlSxIKxAGS589mKQ5Ts+ Zj23S4wfQmi4= X-Received: by 2002:ac5:ce1c:0:b0:4b7:41f2:9e9f with SMTP id j28-20020ac5ce1c000000b004b741f29e9fmr172048vki.9.1704963683371; Thu, 11 Jan 2024 01:01:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9oJhIADb0uOYRD18nzOY4TIFua17TlMASZntUXTQzXpozw1UNJkbhWiJAZoeZYKtiH3lMJQ== X-Received: by 2002:ac5:ce1c:0:b0:4b7:41f2:9e9f with SMTP id j28-20020ac5ce1c000000b004b741f29e9fmr172039vki.9.1704963683112; Thu, 11 Jan 2024 01:01:23 -0800 (PST) Received: from [192.168.0.12] ([78.17.185.107]) by smtp.gmail.com with ESMTPSA id m1-20020a05620a214100b00781df3924f3sm210700qkm.129.2024.01.11.01.01.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 01:01:22 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 09:01:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s To: Ferruh Yigit , stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com Cc: dev@dpdk.org, Ciara Loftus , Shibin Koikkara Reeny References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> From: Maryam Tahhan In-Reply-To: <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/01/2024 15:21, Ferruh Yigit wrote: > On 1/10/2024 2:58 PM, Maryam Tahhan wrote: >> Hi folks >> >> Just wondering if there's any other comments re this patch after all the >> review comments were addressed? >> > Hi Maryam, > > There was a request from David, to the previous version, that fixes > (either to code or document) should be separated into its own patch, so > that they can be merged to our LTS (say 21.11.x) releases, to make sure > LTS release has correct info/code. On top of it your changes can be > another patch. > > As document completely changed, it is not easy for me to say, can you > please confirm that there is no fix to the documentation unrelated with > your code change? > Hey Ferruh Yes - I should've clarified. I took David's comments into consideration. The old use_cni implementation is broken (so if a DPDK pod wants multiple AF_XDP interfaces it will not work). So IMHO it doesn't make sense to patch documentation for something that is broken. The whole change would need to be back ported to LTS. However, I have a second change to apply on top of this - so I will send a series. So please hold off merging for now. BR Maryam