From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66B14433E4; Mon, 27 Nov 2023 13:24:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 390E740273; Mon, 27 Nov 2023 13:24:52 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by mails.dpdk.org (Postfix) with ESMTP id 81F034014F for ; Mon, 27 Nov 2023 13:24:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hqu8j55tyWzNvH8PHhzwuMAPiLq+gsSJBi7tt5+mg2ElnJ0bojmK8nQgYgo0skOkR6ZLqZn2Z76bahQ3DQ2PCTFy0Gf7/caSTOxhD9byWQmSt0TaB2OjUG0RxG6My7Zgw/3IEn2J6Ucoz+bygI4epG2SHIJC5PjS0+asLI7rQf2HPQ8U8FJqM+EdCIXTLYJPLG/GFY5CESJHUhwGFRtPwuUjnkMfelIvb3shOisD7OzgwCW3kMcsMpGafOr2hHfNdo7oMi9jwvDoSmJsCUAKTfocq0rfrYgxww5Ac8A41jAlqoPHXVxtqUTx7W3Ah+fT+xg1qR39q4u+NIHHpr+6FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQKbo/Y8TIaks0XIQhTxN0pfZ+OrKkDO0gPD2vVqboY=; b=KWqii01bRqzCBd1umjgVHG13bDaP7smc51njQ+n5hdEi7XTiR0uzwMEWcEJv0Y1fOIcVeumTJf1j/hanD/Y2vcfLLRIP9nZ+5y0lSg47wYuL1vkuj35M5tymtslP7v+4mTjJP7Sz/nLp/b87srMCA48gRcsxzAZdcIT6Lt3eP1LmUO8gkRF1seKhRWoZwoI8POZ+WxdNeD0RArvsU56jpIMwBAaoqWyA2V17R4NzxaaKXOg98g+It2rk4qCC1WeRvm+mi8KhPrIxT3QzURix58tjQh4nKPbmp0L80fOzjThrA8qcoK6Cv/+/D0Q18yWSBnAS+4ep44PiV8Zt0Ik33w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQKbo/Y8TIaks0XIQhTxN0pfZ+OrKkDO0gPD2vVqboY=; b=bfRVX38DQhyH5MQf9vWAtos0QcIxEORF7mPb3Ou6cC3ydQqX/WpHaSLtoTbhQsYBCos+SsT91sPRasJm5rHDZ8wZmM5shwAJnm/lenVuSNo7a70ytf7sv8uKRm5LBmXEs4khjm45okUd7m+n4F0QQZWtopzZxZ+HTIKNo6tkqmo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5038.namprd12.prod.outlook.com (2603:10b6:5:389::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 12:24:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 12:24:46 +0000 Message-ID: Date: Mon, 27 Nov 2023 12:24:40 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] doc: add link up/down feature Content-Language: en-US To: Huisong Li , dev@dpdk.org, thomas@monjalon.net, Changchun Ouyang Cc: liuyonglong@huawei.com References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-3-lihuisong@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231125014745.61348-3-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0313.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f6::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5038:EE_ X-MS-Office365-Filtering-Correlation-Id: 31a9aebd-5986-4a3d-c80f-08dbef43d73d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z/lZGEPn4Llt9fPxOK2ZUXzKeX7dtv+eIYseo6eRAasTrTD6Ww2p3VEnUu9YGZ98yGikb/++5FHVIqpsi95vC1qg3GdeuN0NjS5i7uXj56aOqaDXLMtZw+STXQSTEMOMwWogY5/+SYEQX7A1GZIvF9Aa7My9q1NtcOOKI3A7qvmiVusiT8p0rGDDfWSlM0t4f3afElFLiA+5VDz7uapg2gVBnJPWArWWfQA8GUFcd736QT0jTF+4dE75P/C8n7tjT72QyW4cJqBty+Z6xtg+8iXIGkJlH1Vl7xsItRc6QlB4fo/FJepFvw9NiBdPxGYeHFn/BMP379UK6EfepY3NopHH8TKD5hlQRS9Q0tnNWBF+dJr80barfkmoN60yUg8g0uTaV8qzxCV5WiGk3A6mCbug6X+rBd+HTzXwMNfSvtBMaNtqh5CZ2DSkslWKtoTwicyty3VV4vdRRfbbbtYDAFV/p7PbvQxmwzIcqVSYm/OR59u5pCwFRJW6r5E08Hf5MJzS6xVyZOvRU10h0som/K4s0Ge+qSy5nC93JC7qDB/lI9kfcI+qaFInEZ5JVT+60q0mtoQ4Tk/4bt80SASEPtYGh1TX3velKl7RpgPNxapuYFmwCSFHLuClckeAtOFThywnxI3qGwSj3LHR0fdGNw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(136003)(39860400002)(346002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(8676002)(8936002)(4326008)(31686004)(44832011)(5660300002)(110136005)(66946007)(66556008)(316002)(66476007)(41300700001)(6512007)(53546011)(478600001)(6666004)(6506007)(6486002)(2616005)(26005)(83380400001)(2906002)(38100700002)(86362001)(31696002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWFoeTNKVkVlYjdSWlZ0eDlXU0xRS1l1bU1IbDV2blozVGhrRmFFeDVmdGhS?= =?utf-8?B?ajJtU2hXRUVtZXdpeWxnclhKS2FyS3NoWUExejNBYU9iNWxUeCtuUnpjcU5x?= =?utf-8?B?OVNqOHZEd1hwamZxRjQ4b3JTVEZqcGxVVGcwTytiWitCeVQ5b1U2WGI2dzUv?= =?utf-8?B?ZTJPNFp2UllRYVZOQzFHSXZ0RkVZb0lZOVoxWUtCMU5DM0MzbXVObEY0Vloy?= =?utf-8?B?NHRlcGlRRjVzSmVucDE1MjVEeEdUSE9zdDBkaHpibmVhclFCTkFIR0NkcUhr?= =?utf-8?B?eUVTWldCRVVPM1d3Z2xaVldtT1pwZmo4OUU5eUxURkdpQ05mTHM1SG55ZWdP?= =?utf-8?B?ejRnaHRLMWxOV1VFWVE4WXVjOHc2aHhsckZJYmR4MXhJNWdJaVBWRUF2S2Mv?= =?utf-8?B?TDk0MEVyQlJEK0hRd3hqcjRaZVVTa2lCck9ncWRpc0FXak1iU1JBSU5WY1hx?= =?utf-8?B?a0tOYnZBQ2pKa29YeW5OS0t3QzBpeG5RaW01b2dacGJuUHZ4ZC9nQXVOaVNS?= =?utf-8?B?a0g2dE92QlFxU0VrNjRJeXRqTzZ1dEV3QTJLSFFqTE9PcjJvTktvSVJrMnhN?= =?utf-8?B?aVdlaWE3cURnNVQxUTJYbEpadFlkNmg0aDVsSStXM3VOTjRDYmtQakRhMjJI?= =?utf-8?B?SThMNitpb0E3TDVsY252QmkzMm9IZXFEMHk5VzEwQkdsRUk4djFTREJGZmJl?= =?utf-8?B?N1gvZzJNMG1iVDdjRE9ad1hDM1RVeDhmZTRDUHRaWU9zclU0cjRwYTB1QUcy?= =?utf-8?B?Z2ZIVkoxazJXSUwyYllCZVNjd2hnclpxM0wrTmwrVEd2ODk2eis0elU1RDBD?= =?utf-8?B?TTBFNjhTaHd5NCtFZFR5OGhuVkpwVTI4amhPVDh6b0p4RzFOZ3p6VDZDM0xK?= =?utf-8?B?bmMzZy8wczNCVDQ3dWVxN0RtR2VGczFCUWZGQXA1a3JBS3l4UEsxcFpucFVt?= =?utf-8?B?OGtUczB1NFoxcUt6ZnJZMUJMRDVZUHNvajFqNC9ZT1k1ZDNRTHlMV3JKV3hN?= =?utf-8?B?Vmdobkd4VUhMSzR2N0JseWlnUjFHOC96N05iQWdBcmhLNXE0bFpvZGNEdldt?= =?utf-8?B?RnpqQ3E4ZVdqM2Y4aEt1YjhIMUJlL2cyMlRKQ3BYVStoZm9iM014OW1UNlgz?= =?utf-8?B?dndHRlVqTlYzU2tGRXhrRnVraGxITDRrYnUyZ0Z6NTIxMVpLbHE2ZXFqUS95?= =?utf-8?B?RldIMnpaZHpSMk9Sb0pXc01hNnNkOFRMenovN0J1c09MREtHYzBvdFNGeWcr?= =?utf-8?B?SHhyQTNsaWdSdDYyMnJIdHdrMnVrcVl4RUl5RUFnMXpxbUtzS1Y5U01Ea0U0?= =?utf-8?B?N1h0MXN2UU1RZlVEL1dMWlFiSXgvV0l0cGd4ZXNvT1I2emV5UmZwTUVZeC9Z?= =?utf-8?B?aklBNEI5eTdkODhRTENjUkd3bngybWFVY2ZzQmJKQ2VFK3J0NmpWWDMxNTQr?= =?utf-8?B?elZUVXk5SnNyRktPdHBJM3V6Ymk5dmR5dDZtS293cUhjUG9tenE5WktJVmY4?= =?utf-8?B?V1pUcFA2OGgxUzNyREpycktOcm5ieWxMZ2w4N2NDR1lwKzJaZFd6dVFjUFA5?= =?utf-8?B?YTM4cW5lcXU4YXJoQXNZRWdzK0grWWQ3T2dVZHp3a2x0czRrbjVPeFJwWm5M?= =?utf-8?B?blJ5YXJZSTQ3Zkd2djhzbzZxVnN5elFybVBVcnpxaFBmcHJBcGdkZ1Q5MW1n?= =?utf-8?B?ZWdPVU9RZG1HMlVZT2Q2TDl4NDlJMlpZNHA2SDhBYkNVYUNvZkdkYXhPazE2?= =?utf-8?B?VXRwdHVVYTU2R0J4MFI3V3dqVktBTmUwM0VHK1g1ZmhIZjV2NDBNN3pHejV0?= =?utf-8?B?TmM0RVdJR2trS3ZOMnlMNnZTWHVNdnRCSDZ4d3JOK3U2bzdJajU2cWNZSU5S?= =?utf-8?B?TDFqRUJPd1Zrdkpjak4yb212MnpTSHpsZjllZnh3ellkbTVVRUFJazJtMU5C?= =?utf-8?B?M3RaT0RNMWhBaFNiODl0UFlDVzZOVHQwMVVkVzdUOThVaHBWKzRoZk44Nk5J?= =?utf-8?B?N3lvc1B3L01udWFyZ25lQXkwTUpCdHZGdE9yMzA1ZVUyRUNrU3Q4VHg3T3Ex?= =?utf-8?B?MG9meVRsVk9WY3lZeFpuUzRPdUVFSVQraUZCM3pKc1JscHhJa0RLNlpNUWhV?= =?utf-8?Q?vb5Y=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31a9aebd-5986-4a3d-c80f-08dbef43d73d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 12:24:45.9682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DcOC99dd4MR5EbHN6/FhPYk+pVgiZ1YMQ0Yj/t+YrQcQyQ8p3OypLBVmyOnTUQVI X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5038 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/25/2023 1:47 AM, Huisong Li wrote: > Add link up/down feature for features.rst. > > Fixes: 915e67837586 ("ethdev: API for link up and down") > Cc: stable@dpdk.org > Documentation is added after feature, so above fixes line is not correct. I am not sure if this is fix, I think more like it is extending the document. With fixes line fix, Acked-by: Ferruh Yigit > Signed-off-by: Huisong Li > Acked-by: Chengwen Feng > --- > doc/guides/nics/features.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 0d38c5c525..f14962a6c3 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -45,6 +45,10 @@ Supports getting the link speed, duplex mode and link state (up/down). > * **[implements] rte_eth_dev_data**: ``dev_link``. > * **[related] API**: ``rte_eth_link_get()``, ``rte_eth_link_get_nowait()``. > > +Set link up/down an Ethernet device. > + > +* **[implements] eth_dev_ops**: ``dev_set_link_up``, ``dev_set_link_down``. > +* **[related] API**: ``rte_eth_dev_set_link_up()``, ``rte_eth_dev_set_link_down()``. > > .. _nic_features_link_status_event: >