* [PATCH v2] net/ice: fix flow creation failure
@ 2025-05-15 11:23 Dhanya Pillai
2025-05-21 10:34 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Dhanya Pillai @ 2025-05-15 11:23 UTC (permalink / raw)
To: Bruce Richardson, Anatoly Burakov; +Cc: dev, Dhanya Pillai
In non-pipeline mode, priority is ignored, a flow rule can be created
as a flow director rule or a switch rule depends on its pattern/action.
Hence removing the priority field check from ice_fdir_parse which is
causing valid flow creation to return failure.
Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
drivers/net/intel/ice/ice_fdir_filter.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
index 2ff0090aca..b11c8f170c 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -2446,7 +2446,7 @@ ice_fdir_parse(struct ice_adapter *ad,
uint32_t array_len,
const struct rte_flow_item pattern[],
const struct rte_flow_action actions[],
- uint32_t priority,
+ uint32_t priority __rte_unused,
void **meta,
struct rte_flow_error *error)
{
@@ -2461,8 +2461,6 @@ ice_fdir_parse(struct ice_adapter *ad,
item = ice_search_pattern_match_item(ad, pattern, array, array_len,
error);
- if (priority >= 1)
- return -rte_errno;
if (!item)
return -rte_errno;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net/ice: fix flow creation failure
2025-05-15 11:23 [PATCH v2] net/ice: fix flow creation failure Dhanya Pillai
@ 2025-05-21 10:34 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2025-05-21 10:34 UTC (permalink / raw)
To: Dhanya Pillai; +Cc: Anatoly Burakov, dev, stable
On Thu, May 15, 2025 at 11:23:44AM +0000, Dhanya Pillai wrote:
> In non-pipeline mode, priority is ignored, a flow rule can be created
> as a flow director rule or a switch rule depends on its pattern/action.
> Hence removing the priority field check from ice_fdir_parse which is
> causing valid flow creation to return failure.
>
Fixes: 14b12c939f3a ("net/ice: remove pipeline mode")
Cc: stable@dpdk.org
> Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-21 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-15 11:23 [PATCH v2] net/ice: fix flow creation failure Dhanya Pillai
2025-05-21 10:34 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).