DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] build: fix disabling developer mode
Date: Mon, 12 May 2025 16:28:25 +0100	[thread overview]
Message-ID: <aCITmVz7OAjbNvCo@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250508044230.133966-1-david.marchand@redhat.com>

On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> A recent change broke disabling developer mode:
> $ meson setup plop -Ddeveloper_mode=disabled
> ...
> drivers/meson.build:150:14: ERROR: Unknown variable "fs".
> 
> Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 8436d1dff8..dfb4cb3aee 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -13,10 +13,11 @@ project('DPDK', 'c',
>          meson_version: '>= 0.57'
>  )
>  
> +fs = import('fs')
> +
>  # check for developer mode
>  developer_mode = false
>  if get_option('developer_mode').auto()
> -    fs = import('fs')
>      developer_mode = fs.exists('.git')
>  else
>      developer_mode = get_option('developer_mode').enabled()
> -- 

Simple fix, LGTM.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


  reply	other threads:[~2025-05-12 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08  4:42 David Marchand
2025-05-12 15:28 ` Bruce Richardson [this message]
2025-05-12 15:45   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCITmVz7OAjbNvCo@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).