[PATCH] net/ice: fix flow creation failure

[PATCH] net/ice: fix flow creation failure

[Dhanya Pillai]

In non-pipeline mode, priority is ignored, a flow rule can be created
as a flow director rule or a switch rule depends on its pattern/action.
Hence removing the priority field check from ice_fdir_parse which is
causing valid flow creation to return failure.

Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
 drivers/net/intel/ice/ice_fdir_filter.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
index 2ff0090aca..d71d14b013 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -2456,13 +2456,12 @@ ice_fdir_parse(struct ice_adapter *ad,
 	uint64_t input_set;
 	bool raw = false;
 	int ret;
+	(void)priority;
 
 	memset(filter, 0, sizeof(*filter));
 	item = ice_search_pattern_match_item(ad, pattern, array, array_len,
 					     error);
 
-	if (priority >= 1)
-		return -rte_errno;
 
 	if (!item)
 		return -rte_errno;
-- 
2.43.0

Re: [PATCH] net/ice: fix flow creation failure

[Bruce Richardson]

On Wed, May 14, 2025 at 06:15:26PM +0000, Dhanya Pillai wrote:
> In non-pipeline mode, priority is ignored, a flow rule can be created
> as a flow director rule or a switch rule depends on its pattern/action.
> Hence removing the priority field check from ice_fdir_parse which is
> causing valid flow creation to return failure.
> 
> Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
> ---
>  drivers/net/intel/ice/ice_fdir_filter.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
> index 2ff0090aca..d71d14b013 100644
> --- a/drivers/net/intel/ice/ice_fdir_filter.c
> +++ b/drivers/net/intel/ice/ice_fdir_filter.c
> @@ -2456,13 +2456,12 @@ ice_fdir_parse(struct ice_adapter *ad,
>  	uint64_t input_set;
>  	bool raw = false;
>  	int ret;
> +	(void)priority;
>  

Rather than casting to void, you can use the RTE_SET_USED macro (which is
just an alias for casting to void) to achieve the same thing with better
readability as to the reason for the cast.

Perhaps an even better solution, though, is to just put "__rte_unused" on
the definition of the "priority" parameter, as:
 "uint32_t priority __rte_unused,"

/Bruce