From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
"Patrick Robb" <probb@iol.unh.edu>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] build: automatically report minimum meson version
Date: Thu, 15 May 2025 13:54:28 +0100 [thread overview]
Message-ID: <aCXkBNE30KbzhMYc@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8z842+xoRs2P8YCrG9EvFD_S-aC-0oaiV_7Dz41qiVZnQ@mail.gmail.com>
On Thu, May 15, 2025 at 01:39:47PM +0200, David Marchand wrote:
> On Thu, May 15, 2025 at 11:37 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Thu, May 15, 2025 at 09:09:22AM +0200, David Marchand wrote:
> > > On Tue, May 13, 2025 at 11:00 AM Bruce Richardson
> > > <bruce.richardson@intel.com> wrote:
> > > >
> > > > Add a script to buildtools to report the minimum meson version given in
> > > > our meson.build file. Then use this script in two ways:
> > > >
> > > > 1. in the .ci/linux-setup.sh script, use the auto-determined minimum
> > > > version to set up the CI, rather than hard-coding it.
> > > > 2. in meson.build call the script to report the version. This serves as
> > > > a sanity check to ensure that any changes to meson.build file do not
> > > > break the script.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > Reviewed-by: Patrick Robb <probb@iol.unh.edu>
> > > > ---
> > > > v2: rebased to latest main
> > >
> > > This patch is reverting dbcd72f3fba0 ("ci: fix unit tests with Fedora 37").
> > >
> > > There were some strange errors raised by UNH, though I don't see the
> > > same python backtrace.
> > > Let's try again:
> > > Recheck-request: iol-unit-arm64-testing, iol-unit-amd64-testing
> > >
> > If we have issues using 0.57, I don't see there being issues with us
> > marking the min meson version to 0.57.2 rather than 0.57 alone. I can do
> > that in a v3, or else we can abandon this patch, if you prefer.
>
> Retests show the same error, so I think we are hitting the issue fixed
> with dbcd72f3fba0.
>
> Bumping the minimal version to 0.57.2 seems fine.
> I looked and can't find a distrib that ships meson 0.57.
> So either a user relies on the distrib version (with a version >=
> 0.58, from my quick search) or the distrib provided version is too old
> and then the user relies on pip.
>
Ok, will do a new revision with the version bump.
/Bruce
next prev parent reply other threads:[~2025-05-15 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:24 [RFC PATCH] " Bruce Richardson
2024-10-09 16:40 ` Stephen Hemminger
2024-10-14 16:31 ` Patrick Robb
2025-05-13 8:59 ` [PATCH v2] " Bruce Richardson
2025-05-15 7:09 ` David Marchand
2025-05-15 9:36 ` Bruce Richardson
2025-05-15 11:39 ` David Marchand
2025-05-15 12:28 ` Patrick Robb
2025-05-15 12:54 ` Bruce Richardson [this message]
2025-05-15 13:46 ` [PATCH v3] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCXkBNE30KbzhMYc@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=probb@iol.unh.edu \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).