DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: <dev@dpdk.org>
Subject: Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour
Date: Wed, 16 Jul 2025 20:46:59 +0100	[thread overview]
Message-ID: <aHgBs5DGU48mTnwz@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CABD7UXPtChUUOdz3gfiyKqY4Rn2_0F8Ck4O6ypq9woATD7hfCw@mail.gmail.com>

On Wed, Jul 16, 2025 at 03:24:55PM -0400, Dean Marx wrote:
> I've created a list of test cases which I'm planning on implementing
> in future QinQ testing. After talking with Bruce about some Intel test
> results earlier, I've got a solid idea of what the expected behaviors
> are in five of these, but I'm unsure about the other three. If anyone
> is able to provide some insight as to what they believe these expected
> behaviors should be, please let me know as it would be immensely
> helpful. Thanks!
> 
> Vlan Strip ON and QinQ Strip OFF:
> 1. Single VLAN:
>     Expected result: VLAN Stripped
> 2. Double VLAN:
>     Expected result: Should strip outer VLAN
> 3. Single 0x88a8 tag only:
>     Expected result: 0x88a8 tag stripped
> 4. Single VLAN + 1 0x88a8 tag:
>     Expected result: 0x88a8 tag stripped, inner VLAN untouched

Technically, the result goes for the test case of "0x88a8 tag +
Single VLAN", since the 88a8 tag is first. :-)
The "Single VLAN + 0x88a8 Tag" would be a 5th test case if you
want to try it. Expected result should be again that outer tag is stripped.

As for the expected results you quote, those may or may not be expected
depending on whether hardware supports multiple VLAN tag eth-types or
configurable VLAN tag eth-types. From my testing, in at least some of our
NICs by default, they ONLY strip VLAN tags if they have a 0x8100 tag.
However, I would be surprised if that is not configurable.

> 
> Vlan Strip ON and QinQ Strip ON:
> 1. Single VLAN:
>     Expected result: VLAN stripped
> 2. Double VLAN:
>     Expected result: Unknown (Outer VLAN stripped?)
> 3. Single 0x88a8 tag only:
>     Expected result: Unknown (0x88a8 tag stripped?)
> 4. Single VLAN + 1 0x88a8 tag:
>     Expected result: Unknown (0x88a8 tag stripped and VLAN tag stripped?)

Again, the expected result would likely depend on what are configured
ethtypes for recognised VLANs.

/Bruce

      reply	other threads:[~2025-07-16 19:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 13:30 Bruce Richardson
2025-07-14 15:06 ` Stephen Hemminger
2025-07-14 15:11   ` Bruce Richardson
2025-07-14 16:33 ` Morten Brørup
2025-07-14 16:49   ` Bruce Richardson
2025-07-15 15:04     ` Morten Brørup
2025-07-15 16:20       ` Bruce Richardson
2025-07-14 20:09 ` Dean Marx
2025-07-14 21:41   ` Patrick Robb
2025-07-15  7:47   ` Bruce Richardson
2025-07-15 21:15     ` Patrick Robb
2025-07-16 10:11   ` Bruce Richardson
2025-07-16 19:24     ` Dean Marx
2025-07-16 19:46       ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHgBs5DGU48mTnwz@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).